2.6 - "reviewed" column no longer getting ticked off?

[Mark Derricutt]

Hey all,

Noticing under 2.6 that as we go thru files during a review they no
longer seem to get ticked off in the 'reviewed' column when looking at
the review.

We have noticed that someones 1 or 2 files will get ticked off, but as
yet we've not noticed any pattern to why some do and the rest don't.

Is anyone else noticing this?

Mark

[Grégory Bougeard]

Yep, I did.

[Dariusz Luksza]

Yes, we also noticed that

> --
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to repo-discuss...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>



--
Best regards

GSM: +49 017 445 41235
Blog: http://luksza.org
LinkedIn: http://www.linkedin.com/in/dariuszluksza

[Dariusz Luksza]

but, unfortunately cannot reproduce this during gwt debug session :|

[Edwin Kempin]

2013/7/3 Dariusz Luksza <dariusz...@gmail.com>

but, unfortunately cannot reproduce this during gwt debug session :|

On Wed, Jul 3, 2013 at 11:55 AM, Dariusz Luksza
<dariusz...@gmail.com> wrote:
> Yes, we also noticed that
>
> On Wed, Jul 3, 2013 at 11:38 AM, Grégory Bougeard <gbou...@gmail.com> wrote:
>> Yep, I did.
>>
>> Le lundi 24 juin 2013 04:40:08 UTC+2, Mark Derricutt a écrit :
>>>
>>> Hey all,
>>>
>>> Noticing under 2.6 that as we go thru files during a review they no
>>> longer seem to get ticked off in the 'reviewed' column when looking at
>>> the review.
>>>
>>> We have noticed that someones 1 or 2 files will get ticked off, but as
>>> yet we've not noticed any pattern to why some do and the rest don't.

Have you checked in the user's diff preferences if 'Manuel Review' is enabled?
Only if this option is not checked files are automatically marked as reviewed when looking at them.
 

[Dariusz Luksza]

On Wed, Jul 3, 2013 at 3:32 PM, Edwin Kempin <edwin....@gmail.com> wrote:
>
>
> 2013/7/3 Dariusz Luksza <dariusz...@gmail.com>
>>
>> but, unfortunately cannot reproduce this during gwt debug session :|
>>
>> On Wed, Jul 3, 2013 at 11:55 AM, Dariusz Luksza
>> <dariusz...@gmail.com> wrote:
>> > Yes, we also noticed that
>> >
>> > On Wed, Jul 3, 2013 at 11:38 AM, Grégory Bougeard <gbou...@gmail.com>
>> > wrote:
>> >> Yep, I did.
>> >>
>> >> Le lundi 24 juin 2013 04:40:08 UTC+2, Mark Derricutt a écrit :
>> >>>
>> >>> Hey all,
>> >>>
>> >>> Noticing under 2.6 that as we go thru files during a review they no
>> >>> longer seem to get ticked off in the 'reviewed' column when looking at
>> >>> the review.
>> >>>
>> >>> We have noticed that someones 1 or 2 files will get ticked off, but as
>> >>> yet we've not noticed any pattern to why some do and the rest don't.
>
> Have you checked in the user's diff preferences if 'Manuel Review' is
> enabled?
> Only if this option is not checked files are automatically marked as
> reviewed when looking at them.
>

This looks like a problem with Apache reverse proxy configuration.
"Reviewed" is set by REST call like:

http://localhost:8888/changes/1/revisions/6/files/path%2Fto%2Ffile%2Ffile.txt/reviewed

and this REST call is then transformed to something like:

http://localhost:8888/changes/1/revisions/6/files/path/to/file/file.txt/reviewed

by Apache. This results in 404 error, because this not matches servlet
regex (this I'm assuming). From my point of view this looks like a
problem in rewrite rules configuration on Apache (they are to eager
and convert '%2F' to '/') but I'm not a rewrite rule expert. Can
somebody confirm that?

[Grégory Bougeard]

I effectively get 404 when doing PUT through file_path/reviewed and th url contains %2F.

I'm gonna check with my sysadmin the reverse proxy conf.

Thx

[Dariusz Luksza]

On Wed, Jul 3, 2013 at 5:07 PM, Doug Kelly <doug...@gmail.com> wrote:

> On Wednesday, July 3, 2013 9:50:42 AM UTC-5, Dariusz Łuksza wrote:
>>
>> This looks like a problem with Apache reverse proxy configuration.
>> "Reviewed" is set by REST call like:
>>
>>
>> http://localhost:8888/changes/1/revisions/6/files/path%2Fto%2Ffile%2Ffile.txt/reviewed
>>
>> and this REST call is then transformed to something like:
>>
>>
>> http://localhost:8888/changes/1/revisions/6/files/path/to/file/file.txt/reviewed
>>
>> by Apache. This results in 404 error, because this not matches servlet
>> regex (this I'm assuming). From my point of view this looks like a
>> problem in rewrite rules configuration on Apache (they are to eager
>> and convert '%2F' to '/') but I'm not a rewrite rule expert. Can
>> somebody confirm that?
>>
>

> If this is truly a reverse proxy issue, maybe check if you're using the
> current "suggested" method of configuring the reverse proxy at:
>
> http://gerrit-documentation.googlecode.com/svn/Documentation/2.6/config-reverseproxy.html
>
> I just tested this with Apache 2.2, and it appears to be working as
> intended. I'm not sure how the mod_rewrite version of the documentation
> will work, because the version of Apache I'm stuck on doesn't support it...

Thanks, that solves this problem!

[Doug Kelly]

Cool, glad it worked.  Dunno how I somehow sent the email only to you. :)  I was wondering where my reply to the list went...

[Dariusz Luksza]

On 07/03/2013 06:11 PM, Doug Kelly wrote:
> Cool, glad it worked. Dunno how I somehow sent the email only to you. :) I was wondering where my reply to the list went...

You need to use 'reply to all' instead of 'reply'... this is how this list is configured :|

[Grégory Bougeard]

AllowEncodedSlashes On was missing on our apache config too.

It's ok now ;)

[Mark Derricutt]

Grégory Bougeard wrote:

AllowEncodedSlashes On was missing on our apache config too.

Sweet - this means http://code.google.com/p/gerrit/issues/detail?id=1980 can be closed that I raised.