Submitting a new patch set always resets review scores

574 views
Skip to first unread message

Alan Evangelista

unread,
Apr 22, 2015, 12:27:37 PM4/22/15
to repo-d...@googlegroups.com
Hi. I'm currently using Gerrit 2.11, but I have also used some previous versions and I'm aware this behavior is the same in all of them. When I have a patch set (v1) with several review scores and I resubmit this change, I get a new patch set (v2), but all scores are reset, even if the diff between v1 and v2 is null. I can see the value of rerunning code verification and resetting its score, but human reviewers do not need to review that patch again. That generates rework (if reviewers review again) or an inconsistent list of changes to be reviewed (if reviewers do not review again). Is there a reason for this behavior?

I'd like to keep old scores if diff is zero. Is there any customization I could do to achieve this or any development work in progress related to this?

Lawrence

unread,
Apr 22, 2015, 2:00:07 PM4/22/15
to repo-d...@googlegroups.com

Alan Evangelista

unread,
Apr 22, 2015, 6:30:40 PM4/22/15
to repo-d...@googlegroups.com
I ended up enabling copyAllScoresOnTrivialRebase, exactly what I was looking for. I wonder why Gerrit doc recommends to enable this option for Code-Review label, but its default value is false.

Thank you very much!

Martin Waitz

unread,
Apr 23, 2015, 8:29:23 AM4/23/15
to repo-d...@googlegroups.com


Am Donnerstag, 23. April 2015 00:30:40 UTC+2 schrieb Alan Evangelista:
I ended up enabling copyAllScoresOnTrivialRebase, exactly what I was looking for. I wonder why Gerrit doc recommends to enable this option for Code-Review label, but its default value is false.

Yes, especially now that we don't resend mails for trivial rebases, we should really enable copyAllScoresOnTrivialRebase for CR by default.
What about also enabling  copyAllScoresIfNoCodeChange for V by default?

Alex Blewitt

unread,
Apr 23, 2015, 9:04:54 AM4/23/15
to Martin Waitz, repo-d...@googlegroups.com


> On 23 Apr 2015, at 13:29, Martin Waitz <martin...@gmail.com> wrote:
>
> What about also enabling copyAllScoresIfNoCodeChange for V by default?

I suggest against this, as it's possible that the build will fail if the code has been rebased.

Alex

Selberg, Sven

unread,
Apr 23, 2015, 9:45:00 AM4/23/15
to Alex Blewitt, Martin Waitz, repo-d...@googlegroups.com
" label.Label-Name.copyAllScoresIfNoCodeChange

If true, all scores for the label are copied forward when a new patch set is uploaded that has the same parent tree as the previous patch set and the same code delta as the previous patch set. This means only the commit message is different." [1]

So rebase triggers no copy of scores if enabled.

/Sven

[1] https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_copyAllScoresIfNoCodeChange
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Alan Evangelista

unread,
Apr 26, 2015, 11:44:58 PM4/26/15
to repo-d...@googlegroups.com, alex.b...@gmail.com, martin...@gmail.com
Should I open a feature request for this (change copyAllScoresOnTrivialRebase default in Code-Review to True and change
copyAllScoresIfNoCodeChange default in Verification to True) somewhere?

David Pursehouse

unread,
Apr 27, 2015, 12:16:32 AM4/27/15
to Alan Evangelista, repo-d...@googlegroups.com, alex.b...@gmail.com, martin...@gmail.com
Yes. Or just make the change yourself and upload it for review at
gerrit-review.googlesource.com



> --
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> ---
> You received this message because you are subscribed to the Google
> Groups "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to repo-discuss...@googlegroups.com
> <mailto:repo-discuss...@googlegroups.com>.

Edwin Kempin

unread,
Apr 28, 2015, 5:02:14 AM4/28/15
to David Pursehouse, Alan Evangelista, repo-d...@googlegroups.com, alex.b...@gmail.com, martin...@gmail.com
2015-04-27 6:16 GMT+02:00 David Pursehouse <david.pu...@sonymobile.com>:
On 04/27/2015 12:44 PM, Alan Evangelista wrote:
Should I open a feature request for this (change
|copyAllScoresOnTrivialRebase| default in Code-Review to True and change
copyAllScoresIfNoCodeChange default in Verification to True) somewhere?

 Yes.  Or just make the change yourself and upload it for review at gerrit-review.googlesource.com



--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google
Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to repo-discuss...@googlegroups.com
 <mailto:repo-discuss...@googlegroups.com>.
For more options, visit https://groups.google.com/d/optout.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

--- You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages