ESC meeting notes, April 21

[David Pursehouse]

Minutes from this week's ESC meeting have been published on the project homepage:

https://www.gerritcodereview.com/2020-04-21-esc-minutes.html

[David Ostrovsky]

Am Donnerstag, 23. April 2020 02:21:16 UTC+2 schrieb David Pursehouse:

Minutes from this week's ESC meeting have been published on the project homepage:

https://www.gerritcodereview.com/2020-04-21-esc-minutes.html

> https://www.gerritcodereview.com/2020-04-21-esc-minutes.html#additional-lint-checks-in-ci

> Additional lint checks in CI

> Bazel v3 doesn’t include the new version of errorprone, which would allow enabling more static analysis to the build and validation process of incoming Gerrit changes. David Pursehouse will continue the research with David Ostrovsky for understanding how to use a more recent version of errorprone and how to include in our Bazel build. 

Done.

PR in Bazel to upgrade Error Prone version to 2.3.4 is here: [1].

Custom release for java_tools that includes this upgrade is here: [2].

Note, though, that I have only built it on Linux, but could conduct a release

for Mac Os X as well.

The new version of EP broke rules_closure: [3] and rules_kotlin: [4], and

that was actually the reason, why last EP upgrade was reverted in Bazel.

The revert was unnecessary, though, because it was a missing dependency

in rules_kotlin itself, that I've fixed here: [5].

Here is the series that brought the upgrade to Gerrit: [6] and here is the

similar series to bump EP and activate all new and shiny bug pattern

checks in JGit project: [7].

First run of the enhanced build reveals, that both projects: Gerrit and

JGit violate Google Java Style Guide and don't provide Javadoc code

block summaries: [9],[10].

I wrote these issues for Gerrit: [11] and JGit: [12] projects to fix new

issues flagged by Error Prone 2.3.4.

[1] https://github.com/bazelbuild/bazel/pull/11271

[2] https://github.com/davido/java_tools/releases/tag/javac11-v11.0

[3] https://github.com/bazelbuild/rules_closure/issues/483

[4] https://github.com/bazelbuild/rules_kotlin/issues/321

[5] https://github.com/bazelbuild/rules_kotlin/pull/320

[6] https://gerrit-review.googlesource.com/c/gerrit/+/265493

[7] https://git.eclipse.org/r/#/c/161956

[8] http://google.github.io/styleguide/javaguide.html#s7.2-summary-fragment

[9] http://paste.openstack.org/show/793014

[10] http://paste.openstack.org/show/793015

[11] https://bugs.chromium.org/p/gerrit/issues/detail?id=12677

[12] https://bugs.eclipse.org/bugs/show_bug.cgi?id=562756

[Ben Rohlfs]

Thanks David! Much appreciated! -Ben

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/e1be2cbb-250e-4a69-8936-bfbc54d78df0%40googlegroups.com.