repo download a topic

735 views
Skip to first unread message

Arvid E.P.

unread,
Mar 20, 2013, 7:36:25 AM3/20/13
to repo-d...@googlegroups.com
So, topic branches are a nice way to mark changes crossing multiple repos, as one unified change.

However, repo download doesn't seem to have any way of downloading it as one package. Is that a matter of adding it, or is there a greater design goal i'm missing?

Magnus Bäck

unread,
Mar 20, 2013, 9:13:15 AM3/20/13
to repo-d...@googlegroups.com
On Wednesday, March 20, 2013 at 07:36 EDT,
"Arvid E.P." <darkwin...@gmail.com> wrote:

> So, topic branches are a nice way to mark changes crossing multiple
> repos, as one unified change.

Well, it's just a piece of metadata suggesting which commits belong
together in some way.

> However, repo download doesn't seem to have any way of downloading it
> as one package. Is that a matter of adding it, or is there a greater
> design goal i'm missing?

How would the command handle two changes in the same git that aren't
dependent on each other? It can't check out both of them. Just bail out
and ask the user to resolve the situation?

--
Magnus Bäck
ba...@google.com

Arvid E.P.

unread,
Mar 20, 2013, 9:25:09 AM3/20/13
to repo-d...@googlegroups.com
"How would the command handle two changes in the same git that aren't dependent on each other?"

Hm. I don't see any way to be smart about that.
What i'd do is just download _all_ of the changes in that topic, in the order of the commit id. I.e. just run "repo download" for each of them, which kinda means cherry-pick.
If that's broken, then well... nothing a tool can do about it.

Magnus Bäck

unread,
Mar 20, 2013, 9:39:21 AM3/20/13
to repo-d...@googlegroups.com
On Wednesday, March 20, 2013 at 09:25 EDT,
"Arvid E.P." <darkwin...@gmail.com> wrote:

> "How would the command handle two changes in the same git that aren't
> dependent on each other?"
>
> Hm. I don't see any way to be smart about that.
> What i'd do is just download _all_ of the changes in that topic,
> in the order of the commit id.

Presumably you mean change number.

> I.e. just run "repo download" for each of
> them, which kinda means cherry-pick.
> If that's broken, then well... nothing a tool can do about it.

You'd have to add cherry-pick abilities to the command since it
currently just fetches the commit and checks it out. Instead of
using the change number to determine the order of the commits it
must look at their ancestry.

--
Magnus Bäck
ba...@google.com

Arvid E.P.

unread,
Mar 20, 2013, 10:13:16 AM3/20/13
to repo-d...@googlegroups.com
"You'd have to add cherry-pick abilities to the command since it currently just fetches the commit and checks it out"

Aha! i was blindly assuming 'repo download' does a cherry-pick already. That changes the answer to "abort and complain" i suppose.
Reply all
Reply to author
Forward
0 new messages