How to switch back to old screen?

[Gaurav Negi]

Dear Gerrit Experts,

    We recently installed Gerrit 2.11.8.

There I do not see any option of "Change View" to "Old Screen".

Any idea what can be done to implement it?

Thanks

-Gaurav

[David Pursehouse]

On 04/15/2016 10:10 AM, Gaurav Negi wrote:
> Dear Gerrit Experts,
> We recently installed Gerrit 2.11.8.

> There I do not see any option of "*Change View*" to "*Old Screen*".

>
> Any idea what can be done to implement it?
>

The old screen is completely removed since 2.11. If you want it back
you'll need to build a custom version after reverting [1] (and possibly
some other subsequent changes).

I don't recommend doing that, though. The change included a database
schema upgrade that would need to be manually reverted.

[1] https://gerrit-review.googlesource.com/#/c/49601/

> Inline image 1
>
> Thanks
> -Gaurav
>

> --
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> ---
> You received this message because you are subscribed to the Google
> Groups "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to repo-discuss...@googlegroups.com
> <mailto:repo-discuss...@googlegroups.com>.
> For more options, visit https://groups.google.com/d/optout.

[Marcelo Ávila de Oliveira]

The old screen was removed in Gerrit 2.11 release:

https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.11.html#_release_highlights

--

Marcelo Ávila de Oliveira

mav...@cpqd.com.br

--

--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

[Gaurav Negi]

Thanks David and Marcelo,

   I also found "Edwin Kempin's" comment here

https://groups.google.com/forum/#!topic/repo-discuss/z8Ri7L4fDCE

To be honest, I like old screen only :-)

Just wish it can come back. 

Thanks

-Gaurav

[Michael Zhou]

What's missing in the current ChangeScreen in particular? The current diff screen is also much more powerful than the old one. See the screenshot at https://www.gerritcodereview.com/ for an idea.

[Clark Boylan]

On Thu, Apr 14, 2016 at 9:10 PM, Michael Zhou <zhoumoto...@gmail.com> wrote:

What's missing in the current ChangeScreen in particular? The current diff screen is also much more powerful than the old one. See the screenshot at https://www.gerritcodereview.com/ for an idea.

Note I too use 2.11 and have mostly figured out how to live with it, but you asked so I will give it a go.

Review page is now patchset oriented and it is very easy to get lost and confused as you navigate between changes and the patchsets change. "Why can't I leave any votes? Where did all the CI results go?" and so on. The old screen's change orientation was much easier to navigate.

The related changes list is very hard to navigate. The biggest problem here seems to be that instead of a graph we now get a linear list. You can navigate off onto a branch and lose the larger context. It can also jump around patchsets making the above issue worse.

The comment reply button is at the top of the review screen but all of the comments you want to reply to are at the bottom. (There actually is a small reply to this specific message in the existing comments button, but it isn't obvious).

Many changes do not fit horizontally on my 1920x1080 pixel display using a fullscreen browser. There is far too much horizontal space and horizontal scrolling is less than ideal.

For the diff screen we still don't have single page diff for all files.

The side by side diffs are completely unusable on mobile browsers, the old diff screen wasn't great but it was usable.

You can write inline comments on the diffs, go to save, find out you have to login and all of your comments are now gone. (I actually don't recall if this was an issue on the old screen but is a recent annoyance for me.)

Browser search using ^F is replaced with some javascript thing that only searches the "new" side of the diff. Why not bind this to another keybinding and let me use my browser's search functionality?

Hitting 'f' no longer brings up the file list on the diff page. This was a minor but useful feature.

When editing diff page settings the difference between apply and save is not clear. Why not just "save" and have it apply to the current page?

Ok, with that over, it isn't all bad. There are new features that are helpful like conflicts with and same topic lists. I hear that some people really like the ability to edit changes in their browser. The REST API is far more useful in newer versions.

Clark

[David Pursehouse]

On 04/15/2016 01:43 PM, Clark Boylan wrote:
> On Thu, Apr 14, 2016 at 9:10 PM, Michael Zhou
> <zhoumoto...@gmail.com <mailto:zhoumoto...@gmail.com>> wrote:
>
> What's missing in the current ChangeScreen in particular? The
> current diff screen is also much more powerful than the old one. See
> the screenshot at https://www.gerritcodereview.com/ for an idea.
>
>
> Note I too use 2.11 and have mostly figured out how to live with it, but
> you asked so I will give it a go.
>

Thanks for the feedback. A couple of the things you mentioned are
already fixed (see inline). I'm not sure how likely it is that the
remaining issues will get addressed though, given that most effort is
now focused on the new Polymer-based UI.

> Review page is now patchset oriented and it is very easy to get lost and
> confused as you navigate between changes and the patchsets change. "Why
> can't I leave any votes? Where did all the CI results go?" and so on.
> The old screen's change orientation was much easier to navigate.
>
> The related changes list is very hard to navigate. The biggest problem
> here seems to be that instead of a graph we now get a linear list. You
> can navigate off onto a branch and lose the larger context. It can also
> jump around patchsets making the above issue worse.
>
> The comment reply button is at the top of the review screen but all of
> the comments you want to reply to are at the bottom. (There actually is
> a small reply to this specific message in the existing comments button,
> but it isn't obvious).
>
> Many changes do not fit horizontally on my 1920x1080 pixel display using
> a fullscreen browser. There is far too much horizontal space and
> horizontal scrolling is less than ideal.
>
> For the diff screen we still don't have single page diff for all files.
>
> The side by side diffs are completely unusable on mobile browsers, the
> old diff screen wasn't great but it was usable.
>

Should be fixed by https://gerrit-review.googlesource.com/#/c/75879/

> You can write inline comments on the diffs, go to save, find out you
> have to login and all of your comments are now gone. (I actually don't
> recall if this was an issue on the old screen but is a recent annoyance
> for me.)
>

Should be fixed by https://gerrit-review.googlesource.com/#/c/71592/

> Browser search using ^F is replaced with some javascript thing that only
> searches the "new" side of the diff. Why not bind this to another
> keybinding and let me use my browser's search functionality?
>
> Hitting 'f' no longer brings up the file list on the diff page. This was
> a minor but useful feature.
>
> When editing diff page settings the difference between apply and save is
> not clear. Why not just "save" and have it apply to the current page?
>

IIUC: "Apply" applies it to the current page only. "Save" applies it in
your preferences and it will persist when you view another diff.

> Ok, with that over, it isn't all bad. There are new features that are
> helpful like conflicts with and same topic lists. I hear that some
> people really like the ability to edit changes in their browser. The
> REST API is far more useful in newer versions.
>
> Clark
>

> --
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> ---
> You received this message because you are subscribed to the Google
> Groups "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to repo-discuss...@googlegroups.com

> <mailto:repo-discuss...@googlegroups.com>.

[Michael Zhou]

Thanks David. I'll give more inline replies here:

On Friday, April 15, 2016 at 12:43:45 AM UTC-4, Clark Boylan wrote:

On Thu, Apr 14, 2016 at 9:10 PM, Michael Zhou <zhoumoto...@gmail.com> wrote:

What's missing in the current ChangeScreen in particular? The current diff screen is also much more powerful than the old one. See the screenshot at https://www.gerritcodereview.com/ for an idea.

Note I too use 2.11 and have mostly figured out how to live with it, but you asked so I will give it a go.

Review page is now patchset oriented and it is very easy to get lost and confused as you navigate between changes and the patchsets change. "Why can't I leave any votes? Where did all the CI results go?" and so on. The old screen's change orientation was much easier to navigate.

I'm not too opinionated on this but IMHO the change screen indicates clearly which patch set the user is on. Showing all the patch sets takes up significant vertical space.

The related changes list is very hard to navigate. The biggest problem here seems to be that instead of a graph we now get a linear list. You can navigate off onto a branch and lose the larger context. It can also jump around patchsets making the above issue worse.

Was there a similar functionality on the old change screen? I didn't remember seeing one. Personally I don't find the "Related Changes" tab too useful. I look at the "Confilicts With" and the "Submitted Together" tabs more often.

 

The comment reply button is at the top of the review screen but all of the comments you want to reply to are at the bottom. (There actually is a small reply to this specific message in the existing comments button, but it isn't obvious).

Many changes do not fit horizontally on my 1920x1080 pixel display using a fullscreen browser. There is far too much horizontal space and horizontal scrolling is less than ideal.

I don't remember ever having to scroll horizontally on the change screen. I also have a 1920x1080 display on my laptop. Can you share a screenshot?

For the diff screen we still don't have single page diff for all files.

I have a kind-of-working prototype at https://gerrit-review.googlesource.com/#/c/75968/ and I will improve it when I get some time. A naive implementation of single page diff comes with some performance impact. If a change is large, showing 100 long files on the single page makes the UI unbearably slow. I will need to alleviate the problem by hiding some files that are not scrolled into view.

The side by side diffs are completely unusable on mobile browsers, the old diff screen wasn't great but it was usable.

My apologies. CodeMirror introduced a breaking change in the behavior on mobile browsers and I didn't notice it until recently. Fixed by https://gerrit-review.googlesource.com/#/c/75879/

You can write inline comments on the diffs, go to save, find out you have to login and all of your comments are now gone. (I actually don't recall if this was an issue on the old screen but is a recent annoyance for me.)

Should be fixed in https://gerrit-review.googlesource.com/#/c/71592/

Browser search using ^F is replaced with some javascript thing that only searches the "new" side of the diff. Why not bind this to another keybinding and let me use my browser's search functionality?

This issue is a bit complicated. By default, CodeMirror does not render the entire file for performance reasons, which is extremely helpful when the file is huge. The old diff screen would just bail out in these cases but the current screen can handle them well. The side effect for not rendering the entire file is that the "Ctrl-F" browser search won't show results in the hidden portions of a file. However, CodeMirror's Vim search, which is the "JavaScript thing" you saw, can handle the hidden portions and show the results. By default, both "/" and "Ctrl-F" bind to the CodeMirror search. There are two ways to use the browser search, if you so prefer:

1. Focus outside the diff area and use "Ctrl-F", with the caveat that the search results might be incomplete.

2. Set "Render" to "Slow" in the diff preferences. This is telling CodeMirror to render the entire file as long as it is less than 4000 lines. 4000 is a hard-coded number derived from experience. A file larger than that is considered "huge" and will almost always choke the browser if rendered entirely. When CodeMirror renders the entire file, we tell it to not handle "Ctrl-F" so you get your favorite browser search back.

I might consider adding a diff preference that let's people decide whether "Ctrl-F" should always use the browser search.

Hitting 'f' no longer brings up the file list on the diff page. This was a minor but useful feature.

I might add this back if it isn't too hard. Can't promise.

When editing diff page settings the difference between apply and save is not clear. Why not just "save" and have it apply to the current page?

"Apply" applies the preferences to the current page but doesn't persist them in your personal settings. "Save" both applies and persists them.

Ok, with that over, it isn't all bad. There are new features that are helpful like conflicts with and same topic lists. I hear that some people really like the ability to edit changes in their browser. The REST API is far more useful in newer versions.

Yes the "Conflicts With" and "Submitted Together" tabs are very useful, The inline edit is great and I'm making it even better with a new diff / merge view being added in https://gerrit-review.googlesource.com/#/c/75967.