stream-events and 'ref-updated' vs 'change-merged'

[Bo Shi]

We recently upgraded from 2.9.2 to 2.10.1.  We have several projects which use the "Merge" strategy for CR submissions.  In 2.9, each submit would produce a 'ref-updated'.  This is no longer the case - and instead we get a 'change-merged' event which contains no information about the potential merge commit created as a side-effect of the submit.  Was this change intentional?  Is there any way to configure gerrit to emit a ref-updated event for all mutations of a particular branch?

[David Pursehouse]

AFAIK ref-updated should still be emitted. If it is not, it sounds like
a bug.

Saša, if this is a confirmed bug shall we try to fix it in 2.10.2?

[Bo Shi]

Also related:

https://gerrit-review.googlesource.com/#/c/61834/3

For what it's worth, +1 for inclusion into 2.10.2.

[Alan Grosskurth]

Bo and I work together. We figured this out---it was an issue on our side caused by two different plugins. Removing these two plugins resulted in us getting ref-updated events again as expected.

Details: First, we saw the following problem in logs/error_log:

    ERROR com.google.gerrit.server.git.ChangeMergeQueue : Merge attempt for experiments,refs/heads/master failed
    com.google.inject.ProvisionException: Unable to provision, see the following errors:

    1) Error in custom provider, com.google.inject.OutOfScopeException: No user on merge thread

The full stack trace (attached as its-stacktrace.txt) points to a problem with the ITS plugin. After removing this plugin, we got

    ERROR com.google.gerrit.server.git.ChangeMergeQueue : Merge attempt for opsconfig,refs/heads/master failed
    java.lang.NoSuchMethodError: com.google.gerrit.reviewdb.client.PatchSetApproval.getLabelId()Lcom/google/gerrit/reviewdb/client/LabelId;

The full stack trace (attached as reviewnotes-stackstrace.txt) points to a problem with the reviewnotes plugin. After removing this plugin, we started getting ref-updated events normally as expected.

Anyway, one thought I had---if plugins could declare which versions of Gerrit they are compatible with an error out early, that might help track down issues like this faster in the future. Not sure if this is feasible, though, with the current plugin design.

Thanks,

---Alan