Re: Gerrit Plugin Download Command

[Edwin Kempin]

On Wed, Nov 17, 2021 at 11:20 AM Dr. Ole Hansen <ole.h...@jutlandia.de> wrote:

Hi Mr. Kempin,

I am installing gerrit in Azure Cloud, where we use
email adress as username.

The download commnd shows then Clone messages in Gerrit Interface like

https://ole.h...@externe.dfs.de@gerrit-staging.dfs.de/a/cloud.dcc.dfs.de

This looks like a bug to me, you may report it in the issue tracker as described at:

https://www.gerritcodereview.com/support.html#bugs

Since Gerrit is an open source project, there is limited support for fixing bugs (see https://www.gerritcodereview.com/support.html#response-time-and-slo) hence you may want to attempt fixing this yourself and contribute a fix to the Gerrit project (requires signing a CLA: https://gerrit-documentation.storage.googleapis.com/Documentation/3.4.1/dev-cla.html).

It would be easier, if one of the following messages were shown:

https://ole.hansen%40extern...@gerrit-staging.dfs.de/a/cloud.dcc.dfs.de

I agree that this is what it should show.

I think this would need to be fixed here:

https://gerrit.googlesource.com/plugins/download-commands/+/refs/heads/master/src/main/java/com/googlesource/gerrit/plugins/download/scheme/HttpScheme.java#67 

Adding the mailing list, so others can chime in.

 

or

https://gerrit-staging.dfs.de/a/cloud.dcc.dfs.de

Unfortunately there are no way to configure as far as I can see.


Best Wishes
Ole Hansen

[Edwin Kempin]

On Thu, Jan 13, 2022 at 10:27 AM Dr. Ole Hansen <ole.h...@jutlandia.de> wrote:

Hi Mr. Kempin,


I mailed you a while ago adressing the problem listed blow.

Please always write to the repo-d...@googlegroups.com mailing list.

 

I also posted a chnage request discarding this problem.

What's the link to the change?

 

I wonder if you and the gerrit community is planning any "fixes"
of this problem - for instance introduction of a configuration parameter
which could solve the problem.

I think I answered this here:

https://groups.google.com/g/repo-discuss/c/cWUYwuUD8Bo/m/LCr5JXbWAgAJ

 

Best wishes
Ole Hansen






> ---------- Ursprüngliche Nachricht ----------
> Von: "Dr. Ole Hansen" <ole.h...@jutlandia.de>
> An: "eke...@google.com" <eke...@google.com>
> Datum: 17.11.2021 11:20
> Betreff: Gerrit Plugin Download Command

>
> 
> Hi Mr. Kempin,
>
> I am installing gerrit in Azure Cloud, where we use
> email adress as username.
>
> The download commnd shows then Clone messages in Gerrit Interface like
>
> https://ole.h...@externe.dfs.de@gerrit-staging.dfs.de/a/cloud.dcc.dfs.de
>

> It would be easier, if one of the following messages were shown:
>
> https://ole.hansen%40extern...@gerrit-staging.dfs.de/a/cloud.dcc.dfs.de
>