CommentLink doesn't work same way in Gerrit 3.7.0?

370 views
Skip to first unread message

Pranab Panda

unread,
Nov 30, 2022, 6:50:05 PM11/30/22
to Repo and Gerrit Discussion
Hi 
After getting through challenges to do a migration test of current Gerrit2.14 to Gerrit-3.7.0,
Finding few things are not working , starting with Internal bug tool reference using comment link.
It is heavily used by Developers and so very important to resolve this for 3.7.0 migration

Following entry In gerrit.config   works on 2.14 current install
But on Gerrit3.7.0 install clicking on the bug link yields a page with
about:invalid#zClosurez.  <====

[commentlink "its-bugtool"]
        match = (?!.*(?:Revert|revert))[\\S]*(?:bugtool:\\/\\/)(\\d{8,9})
        html = <a href=bugtool://$1>bugtool://$1</a>
        association = SUGGESTED
[its-bugtool]
    url = https://bugtool-webservices.xxx.com
    username = wgerrit
    password = ************
    commentOnRefUpdatedGitWeb = true
    commentOnChangeAbandoned = false
    commentOnChangeMerged = false
    commentOnChangeRestored = false
    commentOnCommentAdded = false
    commentOnPatchSetCreated = false

Please advise
thanks
Pranab

Edwin Kempin

unread,
Dec 1, 2022, 2:28:08 AM12/1/22
to Pranab Panda, Repo and Gerrit Discussion
Why this is marked as abuse? It has been marked as abuse.
Report not abuse
On Thu, Dec 1, 2022 at 12:50 AM Pranab Panda <pra...@pacbell.net> wrote:
Hi 
After getting through challenges to do a migration test of current Gerrit2.14 to Gerrit-3.7.0,
Finding few things are not working , starting with Internal bug tool reference using comment link.
It is heavily used by Developers and so very important to resolve this for 3.7.0 migration

Following entry In gerrit.config   works on 2.14 current install
But on Gerrit3.7.0 install clicking on the bug link yields a page with
about:invalid#zClosurez.  <====

[commentlink "its-bugtool"]
        match = (?!.*(?:Revert|revert))[\\S]*(?:bugtool:\\/\\/)(\\d{8,9})
        html = <a href=bugtool://$1>bugtool://$1</a>

html comment links are no longer supported. Please have a look at:
 
        association = SUGGESTED
[its-bugtool]
    url = https://bugtool-webservices.xxx.com
    username = wgerrit
    password = ************
    commentOnRefUpdatedGitWeb = true
    commentOnChangeAbandoned = false
    commentOnChangeMerged = false
    commentOnChangeRestored = false
    commentOnCommentAdded = false
    commentOnPatchSetCreated = false

Please advise
thanks
Pranab

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/be568f42-0264-4769-8f39-3645d366f497n%40googlegroups.com.

Edwin Kempin

unread,
Dec 1, 2022, 3:44:26 AM12/1/22
to Pranab Panda, Repo and Gerrit Discussion
Why this is marked as abuse? It has been marked as abuse.
Report not abuse
On Thu, Dec 1, 2022 at 8:27 AM Edwin Kempin <eke...@google.com> wrote:


On Thu, Dec 1, 2022 at 12:50 AM Pranab Panda <pra...@pacbell.net> wrote:
Hi 
After getting through challenges to do a migration test of current Gerrit2.14 to Gerrit-3.7.0,
Finding few things are not working , starting with Internal bug tool reference using comment link.
It is heavily used by Developers and so very important to resolve this for 3.7.0 migration

Following entry In gerrit.config   works on 2.14 current install
But on Gerrit3.7.0 install clicking on the bug link yields a page with
about:invalid#zClosurez.  <====

[commentlink "its-bugtool"]
        match = (?!.*(?:Revert|revert))[\\S]*(?:bugtool:\\/\\/)(\\d{8,9})
        html = <a href=bugtool://$1>bugtool://$1</a>

html comment links are no longer supported. Please have a look at:

Pranab Panda

unread,
Dec 1, 2022, 5:58:44 PM12/1/22
to Repo and Gerrit Discussion
Why this is marked as abuse? It has been marked as abuse.
Report not abuse
On Thursday, December 1, 2022 at 12:44:26 AM UTC-8 eke...@google.com wrote:
On Thu, Dec 1, 2022 at 8:27 AM Edwin Kempin <eke...@google.com> wrote:


On Thu, Dec 1, 2022 at 12:50 AM Pranab Panda <pra...@pacbell.net> wrote:
Hi 
After getting through challenges to do a migration test of current Gerrit2.14 to Gerrit-3.7.0,
Finding few things are not working , starting with Internal bug tool reference using comment link.
It is heavily used by Developers and so very important to resolve this for 3.7.0 migration

Following entry In gerrit.config   works on 2.14 current install
But on Gerrit3.7.0 install clicking on the bug link yields a page with
about:invalid#zClosurez.  <====

[commentlink "its-bugtool"]
        match = (?!.*(?:Revert|revert))[\\S]*(?:bugtool:\\/\\/)(\\d{8,9})
        html = <a href=bugtool://$1>bugtool://$1</a>

html comment links are no longer supported. Please have a look at:

thanks Ed
Let me play around with the suggested workaround.

-Pranab 

Nasser Grainawi

unread,
Dec 1, 2022, 8:41:59 PM12/1/22
to Edwin Kempin, Pranab Panda, Repo and Gerrit Discussion
Why this is marked as abuse? It has been marked as abuse.
Report not abuse
On Thu, Dec 1, 2022 at 1:44 AM 'Edwin Kempin' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:


On Thu, Dec 1, 2022 at 8:27 AM Edwin Kempin <eke...@google.com> wrote:


On Thu, Dec 1, 2022 at 12:50 AM Pranab Panda <pra...@pacbell.net> wrote:
Hi 
After getting through challenges to do a migration test of current Gerrit2.14 to Gerrit-3.7.0,
Finding few things are not working , starting with Internal bug tool reference using comment link.
It is heavily used by Developers and so very important to resolve this for 3.7.0 migration

Following entry In gerrit.config   works on 2.14 current install
But on Gerrit3.7.0 install clicking on the bug link yields a page with
about:invalid#zClosurez.  <====

[commentlink "its-bugtool"]
        match = (?!.*(?:Revert|revert))[\\S]*(?:bugtool:\\/\\/)(\\d{8,9})
        html = <a href=bugtool://$1>bugtool://$1</a>

html comment links are no longer supported. Please have a look at:
Sorry, the correct URL is:

But that change is only on master, so shouldn't this still work with 3.7.0?
 

Pranab Panda

unread,
Dec 2, 2022, 1:27:22 AM12/2/22
to Repo and Gerrit Discussion
Why this is marked as abuse? It has been marked as abuse.
Report not abuse
On Thursday, December 1, 2022 at 5:41:59 PM UTC-8 nasser....@linaro.org wrote:
On Thu, Dec 1, 2022 at 1:44 AM 'Edwin Kempin' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:


On Thu, Dec 1, 2022 at 8:27 AM Edwin Kempin <eke...@google.com> wrote:


On Thu, Dec 1, 2022 at 12:50 AM Pranab Panda <pra...@pacbell.net> wrote:
Hi 
After getting through challenges to do a migration test of current Gerrit2.14 to Gerrit-3.7.0,
Finding few things are not working , starting with Internal bug tool reference using comment link.
It is heavily used by Developers and so very important to resolve this for 3.7.0 migration

Following entry In gerrit.config   works on 2.14 current install
But on Gerrit3.7.0 install clicking on the bug link yields a page with
about:invalid#zClosurez.  <====

[commentlink "its-bugtool"]
        match = (?!.*(?:Revert|revert))[\\S]*(?:bugtool:\\/\\/)(\\d{8,9})
        html = <a href=bugtool://$1>bugtool://$1</a>

html comment links are no longer supported. Please have a look at:
Sorry, the correct URL is:

But that change is only on master, so shouldn't this still work with 3.7.0?
 
I tried to run the perl command on gerrit config and see that it prints
link =  "bugtool://$1"
and 
text ="bugtool://$1"

So 
I tried with following entries but still getting the same  Error       about:invalid#zClosurez.  <====
[commentlink "its-bugtool"]
 match = (?!.*(?:Revert|revert))[\\S]*(?:bugtool:\\/\\/)(\\d{8,9})
link = prefix<a href="bugtool://$1">bugtool://$1</a>suffix. 
did't help

tried
link = prefix<a href="link">text//$1</a>suffix.
didn't help

tried
link = ""bugtool://$1"
didn't work

tried
link = text
didn't help

how is this supposed to work?
Please advise
thanks
Pranab

Pranab Panda

unread,
Dec 5, 2022, 8:17:54 PM12/5/22
to Repo and Gerrit Discussion
Why this is marked as abuse? It has been marked as abuse.
Report not abuse
 Any suggestion/hint , how to make this work?
The ability to click on bug# and then to bug details from commit-message is a very desirable and most used feature 
Please suggest.

Pranab Panda

unread,
Dec 7, 2022, 12:37:42 AM12/7/22
to Repo and Gerrit Discussion
Why this is marked as abuse? It has been marked as abuse.
Report not abuse
Ok after trying different edits found that the bug link os not clickable from commit message,
However it does show up as a link in commit-message entry and right clicking on it and 
selecting services ---> open problems in Radar  Works!
So although not desirable  but there is a way to open bugs from commit message

-Pranab
Reply all
Reply to author
Forward
0 new messages