Attention Set Trial

[Ben Rohlfs]

Dear community,

we have just turned on the new Attention Set feature at https://gerrit-review.googlesource.com/. 

Check out the original design [1] for motivation and details, but in a nutshell it means:

1. You can start ignoring all changes where you are not in the attention set. So the dashboard has a new section called "Your Turn", and most of the time this should be the only section of the dashboard you have to look at. :-)

2. Users in the attention set of a change are clearly marked as such with an arrow before their name. On the dashboard we have also introduced a new "Reviewers" column, so that you clearly see whose turn it is, even if it is not you or the owner.

3. When replying to a change the attention is automatically passed back and forth between owner and reviewers. But you can also tweak that in the reply dialog.

4. The owner of a change is responsible for the attention set being in the correct state such that reviewers don't waste their time. In turn reviewers are expected to treat it as a clear signal that they are expected to take action, if they are in the attention set. They should remove themselves, if they don't plan to do anything. So no need for pings anymore. :-)

5. You can use the hover card menu of a user to add a user to the attention set or to remove them.

The feature is not ready for broader release, so this is only enabled on gerrit-review, not on any other host. So please expect glaring bugs and very rough edges. We want to experiment and iterate on the feature by using it.

Please file *any* feedback you have using this Monorail template:

https://bugs.chromium.org/p/gerrit/issues/entry?template=Attention+Set

The more feedback you send the better! :-)

Note that the initial state of the attention set as you see it today is probably not very accurate, because the automated rules kicked in at some random point in time. So it is expected that you will have to do some tweaks to your own changes at the beginning.

Thanks for your help!

Ben on behalf of the Gerrit team

[1] https://www.gerritcodereview.com/design-docs/attention-set.html

[Matthias Sohn]

exciting :-)

I just looked at change https://gerrit-review.googlesource.com/c/plugins/replication/+/267812

and do not understand why everybody (authors and reviewers) seem to have the next turn at the same time

 

I rather expected ping-pong between reviewers and authors or did I get this wrong ?

-Matthias

[Ben Rohlfs]

Hi Matthias,

thanks for the feedback! Currently the "default rule" when an owner replies with comments is that all reviewers would be added to the attention set. If the owner does not want that, then they can change the attention set in the reply dialog to the desired state.

I think you could argue that the "default rule" should rather be to only add those reviewers to the attention set that the owner is replying to. Not sure which one is better. Maybe file a feature request with https://bugs.chromium.org/p/gerrit/issues/entry?template=Attention+Set.

-Ben