> On 17 Mar 2021, at 22:03, Ian Wienand <iwie...@redhat.com
> On Wed, Mar 17, 2021 at 09:49:31AM +0000, Luca Milanesio wrote:
>>> Could I kindly ask for some reviews on
>> I checked the change and is ready for merge: would you need more
>> input on it?
> Just merging it :) Do I need to propose ports to other branches too?
>>> After the upgrade to 3.2 the database is not doing very much. As we
>>> are looking up upgrades for our gerrit host hardware, we are planning
>>> on moving our production server from an externally hosted database
>>> (ancient MySQL version) to a local mariadb container running alongside
>>> gerrit. mariadb matches what we use in several other production
>>> services, hence the choice.
>> Why not just using H2 for that?
>> We have tens of thousands of active daily users, 45k repositories,
>> we do not have issues with H2 and the reviewed flag.
> The old documentation made some points about this , but I guess the
> performance side at least is moot with NoteDB.
Yeah, the  was at the ReviewDb times, but nowadays that H2 table is used only for the reviewed flag and that is a “best-effort” thing without keeping any history of it.
When we discussed years ago about the solution, I also proposed to get rid of it altogether :-)
P.S. We do regular cleanups (e.g. getting rid of it and re-creating it from scratch) in prod and nobody ever complained about it.
I wouldn’t even backup that DB because it is a temporary flag of which files the user has seen during a review session.