How to allow change owner to "edit topic name" for and abandoned change

[Matthew Webber]

According to the Gerrit documentation:
"The change owner, branch owners, project owners, and site administrators can always edit the topic name (even without having the Edit Topic Name access right assigned).

Whether the topic can be edited on closed changes can be controlled by the 'Force Edit' flag. If this flag is not set the topic can only be edited on open changes."

We want change owners to be able to edit (actually, remove) the topic on their changes that have been abandoned.

This didn't work (but I expected it to):

• Add an access rule with "Edit Topic Name", ALLOW, "Change Owner", "Force Edit" on refs/* in project A.
  
• Project B has "Rights Inherit From" project A, with no additional rights (A is a common parent project, which exists so a large set of projects can all have the same permissions)
  
• I did not restart Gerrit. This is Gerrit 2.12.1.

I expected change owners in B to be able to edit/remove the topic on their own abandoned changes, but they cannot (at least, through the UI - the edit button is just not displayed).

They can edit/remove the topic if they unabandon (restore) the change.

Have I specified the rule incorrectly, or is this a Gerrit bug?

To be honest, what I would like is to prevent changing the topic on merged changes, but allow it in all other cases.

Thanks

[Zaro]

When the change-owner[1] group was implemented it was setup to only be
applied to a label permission.

"To keeps it consistent with how the existing system groups (Project
Owner, Admin, etc..) are configured the Change Owner group's logic for
existing change context permissions like Abandon, Rebase, View Drafts,
etc. is untouched by this patch. In other words an Admin can only
apply this groups to a label permission."

You would need to add some logic if you want it to apply it to other
permissions.

[1] https://gerrit-review.googlesource.com/#/c/48254/

> --
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to repo-discuss...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Matthew Webber]

Ok, thanks, that explains it.

[Edwin Kempin]

On Fri, Nov 18, 2016 at 9:09 AM, Zaro <zaro...@gmail.com> wrote:

When the change-owner[1] group was implemented it was setup to only be
applied to a label permission.

By now it also works for Submit :-)

  https://gerrit-review.googlesource.com/84995

 

> To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to repo-discuss+unsubscribe@googlegroups.com.

> For more options, visit https://groups.google.com/d/optout.

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.