Disable auto conversion from windows line endings in web UI inline edit

[Bertram Karch]

hi,

we use during review process the feature to do updates in reviewed files online with gerrit web UI.

Our issue:

When file is created on windows system and has CRLF line endings, gerrit converts the line endings during the online edit.

How can we change that behaviour?

Is there a server setting to disable the conversion?

Thanks for help

Bertram

 

[Matthias Sohn]

Did you consider to use git's line ending configuration either using "core.autocrlf" [1]

or, if you need more control, using the "text" and "eol" git attributes [2] ?

[1] https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#_code_core_autocrlf_code

[2] https://git-scm.com/docs/gitattributes#_code_text_code

-Matthias

[Lawrence Dubé]

Sorry to necro, but is there a solution to this problem?

Gerrit's online web editor change the line ending from CRLF to LF during the online web edition

I saw this bug https://bugs.chromium.org/p/gerrit/issues/detail?id=3467 but it doesn't seem to work anymore in the new Gerrit UI

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Ben Rohlfs]

Hi Lawrence,

Unfortunately no, there is no solution. Gerrit's support of online editing is somewhat lacking. That is a known issue, but we are focusing on other areas of the product at the moment and we are accepting the fact that Gerrit's online editing does not work (well) in some scenarios. We would have to rely on more open source contributions, if we wanted to get this fixed short-term.

Sorry for not having a better answer for you.

-Ben

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAGKo9fZCh5Z%3Ds%3DcLFRG9x6PKjz%2BxVkRcJQn3VyOGFk6yB3A8Ag%40mail.gmail.com.

[Lawrence Dubé]

Understood.

We want to use the online edit for our technical writers to be able to update documentation made by devs directly, without having to download/re-upload.

Can't gerrit just keep the line ending present for each line edited?

[卞姗姗]

any update on this issue, we upgrade from 2.14 to 3.5.6。 This problem is troubling us