Upload new patchset to draft publishes the patchset

[Rich Schmitt]

If I push a commit as a draft, then update the commit and repush the change, the change transitions from draft to published.

For example

git commit -as -m "test"

git push ssh://review/test HEAD:refs/drafts/master

git commit --amend -as -m "test 2"

git push ssh://review/test HEAD:refs/changes/<change>

The change is no longer a draft.  Is there a way I can upload a newer patchset to a change while leaving the change in the draft state?

We don't use the commit-msg hook and associated commit-id in the commit message.  Does updating a patchset in a draft work when using commit-id?  Or is there some other way to update patchsets in drafts?

Rich

[Matthias Sohn]

why do you push to refs/changes/<change> after amending ?

Try instead to again push to refs/drafts/master, also ensure that the commit message

contains the correct changeId, the easiest way to achieve that is to install the commit-msg

hook [1].

[1] http://gerrit-documentation.googlecode.com/svn/Documentation/2.6/cmd-hook-commit-msg.html 

--

Matthias

[Rich Schmitt]

I know about the commit-id way.  We weren't using that approach (for various reasons).  I guess my post is more a question.  Maybe pushing to an explicit change branch doesn't support drafts.  That's would be fine, I'm just wondering if anyone knows for sure.  I can try a test using commit-ids in the commit-msg and see if updated patchsets to drafts leave the review in a draft state.

[Matthias Sohn]

On Fri, Apr 5, 2013 at 9:48 PM, Rich Schmitt <blue6...@gmail.com> wrote:

I know about the commit-id way.  We weren't using that approach (for various reasons).  I guess my post is more a question.  Maybe pushing to an explicit change branch doesn't support drafts.  That's would be fine, I'm just wondering if anyone knows for sure.  I can try a test using commit-ids in the commit-msg and see if updated patchsets to drafts leave the review in a draft state.

I didn't say commit-id but change-Id which isn't the same id.

The "Upload Changes" docu page [1] clearly states that change-Ids should be used for uploading new

patchsets and that pushing to refs/changes/<change> is deprecated. 

Hence I wouldn't be surprised if drafts don't work with this deprecated upload method.

[1] http://gerrit-documentation.googlecode.com/svn/Documentation/2.6/user-upload.html#push_replace

--

Matthias