How to browse branches and commit history and view _any_ commit in the Gerrit?Gerrit has nice web interface to show diff for the changes and even different patch sets, i.e. arbitrary revisions.I want to use this viewer for _any_ commit, not just the ones changes were created for.There are lot of cases when project commits are imported from alien sources, and they are not subject for review.
How to browse branches and commit history and view _any_ commit in the Gerrit?Gerrit has nice web interface to show diff for the changes and even different patch sets, i.e. arbitrary revisions.I want to use this viewer for _any_ commit, not just the ones changes were created for.There are lot of cases when project commits are imported from alien sources, and they are not subject for review.If this is possible, then how, if not then why not?
I would expect to have something like: https://mygerrit/myproject/<branch>/<commit>Sharing such URL with people would directly open the commit viewer, similar to how change URL behaves.Maybe even allow to enter comments, but just read only mode would be also good enough.I know there is gitiles and other web Git browsers but they all have dummy interface and diff viewers.
Especially when Gerrit is already powered with rich commit viewer out of the box.
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/f89ece49-7d34-4b6b-ac4c-8aa341feaf97%40googlegroups.com.
If this is possible, then how, if not then why not?No, because the expectation is to use the external browser (gitiles, gitweb, etc).
I know there is gitiles and other web Git browsers but they all have dummy interface and diff viewers.I'm not sure what you mean here with "dummy interface".
If this is possible, then how, if not then why not?No, because the expectation is to use the external browser (gitiles, gitweb, etc).That is what my question was about in first place: why this expectation exists?
Gitiles, Gitweb, etc. are generic web viewers for the existing Git repositories, which makes sense if you have absolutely nothing, but still wants to expose the history of your Git repository on the web somehow.In case of Gerrit this does not make much sense, at lease when it comes to the viewing particular commit.As I highlighted above, Gerrit has nice diff viewer, including side-by-side, unified layouts, image comparison, etc.Guess I don't have to explain to Gerrit developers why good diff viewer is important, because that is what they are developing exactly.I see no real reason why this commit/diff viewer cannot be used for arbitrary commit in read only mode, without having the change.
I know there is gitiles and other web Git browsers but they all have dummy interface and diff viewers.I'm not sure what you mean here with "dummy interface".They are very simple and follow the terminal like look and feel.Lets take gitiles: it shows plain diff format, no side-by-side, no unified view,
no way to see change in-the-middle-of-the-line,
no way to show more context lines above/below, no way to skip whitespace, etc etc etc.
On 18 Feb 2020, at 14:17, David Ostrovsky <david.o...@gmail.com> wrote:
Am Montag, 17. Februar 2020 07:15:54 UTC+1 schrieb Daniel Levin:If this is possible, then how, if not then why not?No, because the expectation is to use the external browser (gitiles, gitweb, etc).That is what my question was about in first place: why this expectation exists?Gitiles, Gitweb, etc. are generic web viewers for the existing Git repositories, which makes sense if you have absolutely nothing, but still wants to expose the history of your Git repository on the web somehow.In case of Gerrit this does not make much sense, at lease when it comes to the viewing particular commit.As I highlighted above, Gerrit has nice diff viewer, including side-by-side, unified layouts, image comparison, etc.Guess I don't have to explain to Gerrit developers why good diff viewer is important, because that is what they are developing exactly.I see no real reason why this commit/diff viewer cannot be used for arbitrary commit in read only mode, without having the change.Even if it is a good idea, to re-use existing frontend and backend Gerrit code to viewarbitrary commits, we are not there yet.
I know there is gitiles and other web Git browsers but they all have dummy interface and diff viewers.I'm not sure what you mean here with "dummy interface".They are very simple and follow the terminal like look and feel.Lets take gitiles: it shows plain diff format, no side-by-side, no unified view,Looking at Gitweb: [1], it offers many features you are missing in Gitiles.
no way to see change in-the-middle-of-the-line,This is actually a very good point. LibreOffice developers raised the same concerns:the ability to see the changes in-the-middle-of-the-line. LibreOffice infra team patchedGitiles and added that feature: [2]. It would be great, if this patch could be upstreamed.
no way to show more context lines above/below, no way to skip whitespace, etc etc etc.+1 to add these features to Gitiles.
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/30817c8a-dd19-4b6e-a9fa-75a0ba1ea9c5%40googlegroups.com.
Looking at Gitweb: [1], it offers many features you are missing in Gitiles.
no way to see change in-the-middle-of-the-line,This is actually a very good point. LibreOffice developers raised the same concerns:the ability to see the changes in-the-middle-of-the-line. LibreOffice infra team patchedGitiles and added that feature: [2]. It would be great, if this patch could be upstreamed.no way to show more context lines above/below, no way to skip whitespace, etc etc etc.+1 to add these features to Gitiles.
Even if it is a good idea, to re-use existing frontend and backend Gerrit code to viewarbitrary commits, we are not there yet.
“we have so much work and improvement to make in Gerrit on the code-review user exeperience, that we cannot and should not focus on a generic code / diff viewer, which is a huge effort if you want to make it right”.
Am Montag, 17. Februar 2020 07:15:54 UTC+1 schrieb Daniel Levin:If this is possible, then how, if not then why not?No, because the expectation is to use the external browser (gitiles, gitweb, etc).That is what my question was about in first place: why this expectation exists?Gitiles, Gitweb, etc. are generic web viewers for the existing Git repositories, which makes sense if you have absolutely nothing, but still wants to expose the history of your Git repository on the web somehow.In case of Gerrit this does not make much sense, at lease when it comes to the viewing particular commit.As I highlighted above, Gerrit has nice diff viewer, including side-by-side, unified layouts, image comparison, etc.Guess I don't have to explain to Gerrit developers why good diff viewer is important, because that is what they are developing exactly.I see no real reason why this commit/diff viewer cannot be used for arbitrary commit in read only mode, without having the change.Even if it is a good idea, to re-use existing frontend and backend Gerrit code to viewarbitrary commits, we are not there yet.I know there is gitiles and other web Git browsers but they all have dummy interface and diff viewers.I'm not sure what you mean here with "dummy interface".They are very simple and follow the terminal like look and feel.Lets take gitiles: it shows plain diff format, no side-by-side, no unified view,Looking at Gitweb: [1], it offers many features you are missing in Gitiles.no way to see change in-the-middle-of-the-line,This is actually a very good point. LibreOffice developers raised the same concerns:the ability to see the changes in-the-middle-of-the-line. LibreOffice infra team patchedGitiles and added that feature: [2]. It would be great, if this patch could be upstreamed.