VS code extension

207 views

Skip to first unread message

Roland Schulz

unread,

Sep 17, 2018, 1:50:42 AM9/17/18

to Repo and Gerrit Discussion

Hi,

it anyone else using Gerrit with VS Code and is interested in collaborating on an extension? There is an existing one [1]. But it is very bare bone and

the author isn't interested in extending it. In particular I'm interested in showing the inline comments in the editor with the new API [2] to provide a least a

subset of the what the github extension [3] provides.

Roland

1) https://github.com/tht13/gerrit-vscode

2) https://code.visualstudio.com/updates/v1_27#_comment-providers

3) https://code.visualstudio.com/blogs/2018/09/10/introducing-github-pullrequests

Martin Wallgren

unread,

Sep 19, 2018, 4:17:31 AM9/19/18

to Repo and Gerrit Discussion

I created an experiment a couple of weeks ago where I pulled the comments from a Gerrit change and added them to the current editor.

https://github.com/MartinWallgren/vscode-gerrit-review

Disclaimer, I have never written a vs code plugin before. I just wanted to see how hard it was (it was surprisingly easy). So the code might be a bit rough :)

It's a shame that it's not possible to build plugins on top of other plugins.

Then we could utilize what they did in the github plugin. The gitlens plugin also has a nice way of browsing commits and opening them in a diff editor, just loading review comments in gitlens would take us 95% there.