How to set verified on a commit in Gerrit 2.11.3

[Scott Ekberg]

I have searched all over the internet, I have looked through the documentation, and I cannot figure out what I am doing incorrectly in order to set verified to +1. Can someone please point out what I am missing?

My Gerrit version is 2.11.3

Things I have done:

• In Gerrit I added myself to the Administrators group thinking maybe I was having a permission issue
• I found this page on gerrit review, which appears to be the way to set this http://review.cyanogenmod.org/Documentation/cmd-review.html

My scenario

1. Created Project in Gerrit
2. Cloned project locally
3. committed and did a push
4. In Gerrit web UI I logged in and manually marked my change as Code-Review +1 by pressing the "Reply..." button inside a change
5. On my windows machine I now open git bash and type the below

sekberg@localdev /d/svn/gerrit/TestProject (master)

$ ssh -p 29418 sekberg@gerrit gerrit review 873300f8fb015def27c0884ae2f50b763fbfdb26 --message '"cmd scott"' --verified +1

Enter passphrase for key '/o/.ssh/id_rsa':

When I type this ssh "gerrit review" command no errors are getting returned, and when I refresh the gerrit website verified did not get set. Since it returned no output, and verified did not get set I am unsure how to proceed. Any ideas?

[David Pursehouse]

On 11/05/2015 09:19 AM, Scott Ekberg wrote:
> I have searched all over the internet, I have looked through the
> documentation, and I cannot figure out what I am doing incorrectly in
> order to set verified to +1. Can someone please point out what I am missing?
>
> My Gerrit version is 2.11.3
>
> Things I have done:
>

> * In Gerrit I added myself to the Administrators group thinking maybe

> I was having a permission issue

> * I found this page on gerrit review, which appears to be the way to
> set this http://review.cyanogenmod.org/Documentation/cmd-review.html
>

Note that the Verified label is not set up by default. Did you select
to set it up during site init?

Also, you need to explicitly give permission for Verified+1 in the
access settings . Typically you'll set it on refs/heads/* in
All-Projects or on the specific project. It should look something like
this: http://imgur.com/2zcn5YG

> My scenario
>
> 1. Created Project in Gerrit
> 2. Cloned project locally
> 3. committed and did a push
> 4. In Gerrit web UI I logged in and manually marked my change as

> Code-Review +1 by pressing the "Reply..." button inside a change

Do you also see the options for Verified in the same dialog where you
set Code-Review? If not, it's most likely that you either don't have
the label installed or don't have permissions, as mentioned above.

> 5. On my windows machine I now open git bash and type the below

>
> sekberg@localdev /d/svn/gerrit/TestProject (master)
> $ ssh -p 29418 sekberg@gerrit gerrit review
> 873300f8fb015def27c0884ae2f50b763fbfdb26 --message '"cmd scott"'
> --verified +1

This command looks correct. It works for me on my test project in which
I have permission to set Verified.

> Enter passphrase for key '/o/.ssh/id_rsa':
>
> When I type this ssh "gerrit review" command no errors are getting
> returned, and when I refresh the gerrit website verified did not get
> set. Since it returned no output, and verified did not get set I am
> unsure how to proceed. Any ideas?
>

I can't remember if there was a reason why, but it doesn't give any
error message for invalid (or not allowed) labels.

[Scott Ekberg]

Thank you so much for your help. That screen shot for http://imgur.com/2zcn5YG was what I was missing. 

Thank you!!!