wip/private changes and notifications

[webcz...@poczta.onet.pl]

Hello,

How do private changes/wip changes affect notifications sent to users watching project?

As in, if users want to get only notifications about new changes and change is wip initially, they probably won't get it, even after it is ready for review later, so they will never get notified.

And, it is not said I will ever assign reviewers for the change.

As for private changes I am not certain at all.

[Logan Hanks]

The "comment" notification is sent out when a change transitions out of WIP. The user experience here is not ideal, but users do get notified when the change is ready for review.

Issue https://bugs.chromium.org/p/gerrit/issues/detail?id=6854 tracks the concept of implementing a new notification that combines aspects of "newchange" and "comment" for when a change starts review.

This isn't documented very well, but much of the notification behavior around WIP is asserted and maintained in an acceptance test: https://gerrit.googlesource.com/gerrit/+/master/javatests/com/google/gerrit/acceptance/server/mail/ChangeNotificationsIT.java

If the scenario you're concerned about is covered, you can see precisely which notifications are and aren't sent out.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Gert van Dijk]

On Tuesday, 11 September 2018 12:46:33 UTC+2, webcz...@poczta.onet.pl wrote:

How do private changes/wip changes affect notifications sent to users watching project?

I believe, as I experienced out of practice:

• WIP implies (almost) no notifications at all.
  
• Privates restricts the notifications to be sent only to those who can view the change - watching a project should notify you as long as the owner adds you as a reviewer (e.g. on push time "git push -o r=username").

As in, if users want to get only notifications about new changes and change is wip initially, they probably won't get it, even after it is ready for review later, so they will never get notified.

That is true on 2.15.x, but on master I think this has improved with change 170350, with a notification when it transitions to ready, which is what Logan is referring to.

 

Also useful perhaps, is this table mentioned in the documentation: https://gerrit-documentation.storage.googleapis.com/Documentation/2.15.3/rest-api-changes.html#set-review-notifications

HTH

[David Pursehouse]

On Wed, Sep 12, 2018 at 1:28 AM Gert van Dijk <gert...@gmail.com> wrote:

On Tuesday, 11 September 2018 12:46:33 UTC+2, webcz...@poczta.onet.pl wrote:

How do private changes/wip changes affect notifications sent to users watching project?

I believe, as I experienced out of practice:

• WIP implies (almost) no notifications at all.
  
• Privates restricts the notifications to be sent only to those who can view the change - watching a project should notify you as long as the owner adds you as a reviewer (e.g. on push time "git push -o r=username").

Note that it's not possible to push a new private change and add reviewers at the same time (see issue 6030).

 

As in, if users want to get only notifications about new changes and change is wip initially, they probably won't get it, even after it is ready for review later, so they will never get notified.

That is true on 2.15.x, but on master I think this has improved with change 170350, with a notification when it transitions to ready, which is what Logan is referring to.

 

Also useful perhaps, is this table mentioned in the documentation: https://gerrit-documentation.storage.googleapis.com/Documentation/2.15.3/rest-api-changes.html#set-review-notifications

HTH

--