Gerrit 2.5 - Restore abandon changes for branches (not master) is not allowed?

[Siddhartha Thotapalli]

I am using Gerrit 2.5 in my organization. When changes are abandoned (I have abondon-allow access for refs/* and refs/for/*), I can restore those changes (by clicking 'restore' button or from command line) if the change belongs to 'master'. But if the change belongs to a branch (not master), I am not seeing the option to resotre the change. When I try from command line , I get

$ ssh -p 29418 navapp-gerrit "gerrit review --restore 0e02284ccce11b17b6144c47aac64feb56284844"

error: (change 1879) not permitted to restore change

As I have allow access for 'Abandon' shouldn't I have restore access also (from the documentation)? Am I missing some thing here? Please help.

[Edwin Kempin]

2013/6/28 Siddhartha Thotapalli <siddhu.t...@gmail.com>

The documentation seems to be a bit outdated in this place. You are only allowed to restore changes on branches, for which you are allowed to upload changes.
See Gerrit 2.5 release notes [1]:

"- Check if user can upload in order to restore
Restoring a change is similar to uploading a new change. If a branch gets closed by removing the access rights to upload new changes it shouldn’t be possible to restore changes for this branch."

[1] http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-2.5.html#_access_rights
 

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
 
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[David Pursehouse]

On 06/28/2013 10:37 AM, Edwin Kempin wrote:
> 2013/6/28 Siddhartha Thotapalli <siddhu.t...@gmail.com
> <mailto:siddhu.t...@gmail.com>>

>
> I am using Gerrit 2.5 in my organization. When changes are abandoned
> (I have abondon-allow access for refs/* and refs/for/*), I can
> restore those changes (by clicking 'restore' button or from command
> line) if the change belongs to 'master'. But if the change belongs
> to a branch (not master), I am not seeing the option to resotre the
> change. When I try from command line , I get
>
> $ ssh -p 29418 navapp-gerrit "gerrit review --restore
> 0e02284ccce11b17b6144c47aac64feb56284844"
> error: (change 1879) not permitted to restore change
>
> As I have allow access for 'Abandon' shouldn't I have restore access
> also (from the documentation)? Am I missing some thing here? Please
> help.
>
> The documentation seems to be a bit outdated in this place. You are only
> allowed to restore changes on branches, for which you are allowed to
> upload changes.
> See Gerrit 2.5 release notes [1]:
>

The access-control documentation for "Abandon" [2] mentions this:

"This also grants the permission to restore a change if the change
can be uploaded."


[2]
https://gerrit-review.googlesource.com/Documentation/access-control.html#category_abandon