Issues with Chrome 76 on Gerrit 2.13

320 views
Skip to first unread message

Matthias Sohn

unread,
Aug 6, 2019, 9:04:52 AM8/6/19
to Repo and Gerrit Discussion
We still have a server running 2.13 :-() (planning to upgrade it to 2.16 when holiday season is over) and had to upgrade GWT to 2.8.2 since some internal plugins stopped working when using Chrome 76 on client side.

Debugging the client revealed the problem:

The missing url is what causes Gerrit to return differently from the
client API “PluginName.getUrl” method. It looks like Gerrit is relying
on the stack trace to contain an url, which changed with Chrome 76, and
fails to handle the missing url gracefully.

In Chrome 76 it returns here:
https://gerrit.googlesource.com/gerrit/+/refs/heads/stable-2.13/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PluginName.java#103

In Chrome 75 it returns here:
https://gerrit.googlesource.com/gerrit/+/refs/heads/stable-2.13/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PluginName.java#100

Upgrading GWT to 2.8.2 fixed this issue but now
  • filters on the project list page don't work 
  • filter on the branch list page don’t work
  • unified diff doesn't show anything
Anyone has seen something like that ?
Any hints ?

-Matthias

Boris Brodski

unread,
Aug 9, 2019, 11:55:25 AM8/9/19
to Repo and Gerrit Discussion
I can confirm this.

I use Gerrit 2.11.3 and have the same problem after upgrading to Chrome 76.0.3809.100.

RJ

unread,
Aug 10, 2019, 5:55:23 PM8/10/19
to Repo and Gerrit Discussion
Observed the same issue with Chrome 76 with 2.12 version. Once moved out delete-plugin which was the only non-core plugin at this version , resolved the issue for now

Luca Milanesio

unread,
Aug 10, 2019, 6:02:02 PM8/10/19
to RJ, Luca Milanesio, Repo and Gerrit Discussion

On 10 Aug 2019, at 22:55, 'RJ' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

Observed the same issue with Chrome 76 with 2.12 version. Once moved out delete-plugin which was the only non-core plugin at this version , resolved the issue for now

git show v2.12:
Tagger: David Pursehouse <david.pu...@sonymobile.com>
Date:   Fri Apr 17 10:05:37 2015 +0900

git show v2.11.3
Tagger: David Pursehouse <david.pu...@sonymobile.com>
Date:   Fri Aug 21 11:16:54 2015 +0900

They are both over 4 years old releases: we could not possibly predict the future of what the Chrome v76 version would do.
The current support policy (free from the OpenSource community) is published at:

Because v3.0 is introducing breaking changes (GWT and ReviewDb dropped), we have decided to support from v2.15 onwards:


On Friday, August 9, 2019 at 8:55:25 AM UTC-7, Boris Brodski wrote:
I can confirm this.

I use Gerrit 2.11.3 and have the same problem after upgrading to Chrome 76.0.3809.100.

I would suggest to upgrade to *at least* Gerrit v2.14, by going through the intermediate releases:

v2.11 => v2.12
v2.12 => v2.13
v2.13 => v2.14

The release notes of each release would guide you through the process.
If you need help with the migration or Enterprise Support for old unsupported releases, you can refer to the companies that provide such service for a fee, including CollabNet, WANDisco and GerritForge.

HTH

Luca.



-- 
-- 
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/0f7aec85-04c3-456a-bc36-27b7273b1d57%40googlegroups.com.

David Ostrovsky

unread,
Sep 6, 2019, 2:08:31 PM9/6/19
to Repo and Gerrit Discussion
I am not able to reproduce this locally, on stable-2.14 branch.
It works as expected on Chrome 77.0.3865.42 on Linux.
I added a comment with screenshot here: [1].

David Ostrovsky

unread,
Sep 6, 2019, 4:23:25 PM9/6/19
to Repo and Gerrit Discussion

Am Freitag, 6. September 2019 20:08:31 UTC+2 schrieb David Ostrovsky:

Am Dienstag, 6. August 2019 15:04:52 UTC+2 schrieb Matthias Sohn:
We still have a server running 2.13 :-() (planning to upgrade it to 2.16 when holiday season is over) and had to upgrade GWT to 2.8.2 since some internal plugins stopped working when using Chrome 76 on client side.

Debugging the client revealed the problem:

The missing url is what causes Gerrit to return differently from the
client API “PluginName.getUrl” method. It looks like Gerrit is relying
on the stack trace to contain an url, which changed with Chrome 76, and
fails to handle the missing url gracefully.

In Chrome 76 it returns here:
https://gerrit.googlesource.com/gerrit/+/refs/heads/stable-2.13/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PluginName.java#103

In Chrome 75 it returns here:
https://gerrit.googlesource.com/gerrit/+/refs/heads/stable-2.13/gerrit-gwtui/src/main/java/com/google/gerrit/client/api/PluginName.java#100

Upgrading GWT to 2.8.2 fixed this issue but now
  • filters on the project list page don't work 
  • filter on the branch list page don’t work
  • unified diff doesn't show anything
Anyone has seen something like that ?

I am not able to reproduce this locally, on stable-2.14 branch.

OK, I was able to reproduce the problem on stable-2.13 branch.
As Thomas Dräbing mentioned in another thread, the GWT upgrade
to 2.8.2 fixed the problem. I cherry-picked 4 changes from 2.14
branch on gerrit-review: [1] and on github [2] and conducted a
new release and published it here: [3].


Trevor Getty

unread,
Sep 9, 2019, 2:05:22 PM9/9/19
to Repo and Gerrit Discussion
David, I believe you may be missing a few "unboxing" issues that were caused by GWT 2.8.1, boolean/float boxing change.
So GWT 2.8.2 does fix the JS error handling, and thus the plugin loading behaviour but you will have NPE exceptions at every location that can now be null Boolean or null Float.

You may wish to cherry pick the following related fixes, already done by Thomas, which fix the main issues seen on filtering screens.

Though there could be loads of these such issues lurking in there, I had thought about removing the unboxing from 2.8.2 version with a branch, which would 
allow us to have a stable version with exception handling, and without this issue.  
Though unless we got that into the GWT open source branch it would be difficult to reference for everyone, so the above changes make more sense for now.

David Ostrovsky

unread,
Sep 9, 2019, 2:42:36 PM9/9/19
to Repo and Gerrit Discussion

Am Montag, 9. September 2019 20:05:22 UTC+2 schrieb Trevor Getty:
David, I believe you may be missing a few "unboxing" issues that were caused by GWT 2.8.1, boolean/float boxing change.
So GWT 2.8.2 does fix the JS error handling, and thus the plugin loading behaviour but you will have NPE exceptions at every location that can now be null Boolean or null Float.

I don't think so. I believe that the series of 4 changes that I've suggested
in my previous comment should be sufficient on stable-2.13 branch to fix
everything, including the boxing issue.


You may wish to cherry pick the following related fixes, already done by Thomas, which fix the main issues seen on filtering screens.

Nope. Thomas's change were done on stable-2.12, while my series is on stable-2.13. 
 

This change is fixing old version of Unified Change Screen that I've removed in 2.13 release
int his CL: [1], so that is totally unrelated to stable-2.13 branch as the code does not exist
there any more.


These changes is a way to complex fix for filtering issue, that I properly fixed in this CL: [2],
in stable-2.14 branch. See my comments on those changes from Thomas, where I suggested
to replace them with [2] cherry-picked from the stable-2.14 branch.


Reply all
Reply to author
Forward
0 new messages