Anonymous Coward not professional
Mike Henke
going to be used by professionals that should be changed.
Shawn Pearce
> "Anonymous Coward" probably was funny at one point but if Gerrit is
> going to be used by professionals that should be changed.
We welcome patches from interested contributors.
Martin Fick
It's a good thing none of our users or developers are
professionals then! ;)
At least, that's what someone might conclude by reading
the comments from some of the posters on this list. Oh,
OK, maybe just one or two particular users then... ;)
Really, is it time to perhaps drop the attitude? You
have actually received surprisingly good and timely support
so far despite your attitude. I think that says a lot about
the professionalism here,
-Martin
Saša Živkov
"Anonymous Coward" probably was funny at one point but if Gerrit is
going to be used by professionals that should be changed.
What is a professional?
Somebody who gets irritated by seeing something like "Anonymous Coward"?
Or somebody who makes great product?
The android team is developing using Gerrit and AFAIK has no issues with the "Anonymous Coward".
Have they been working less professionally because of that?
Nicholas Mucci
come across that way. I don't believe its any sort of accusation that
the Gerrit community is unprofessional or an attack on anyone else's
professionalism.
There's a lot of us who champion Gerrit as an alternative to often
expensive or more difficult to use alternatives. We have the burden
or proving that using Gerrit in a corporate environment is a sound
business decision. This means that not only does Gerrit have to be
developer friendly, but it needs to be sufficiently PHB friendly.
Showing unregistered users as "Anonymous Coward" is just something
that PHBs can trip over.
Not everyone who uses Gerrit is from Google, or an Android developer,
or a FOSS developer, and Shawn's survey from several months ago shows
that quite clearly. I think that rather than kindle a flamewar, we
should be cognizant of the diversity of the Gerrit userbase and
embrace Gerrit's evolution into something that all kinds of projects
can use in all kinds of environments; its come a long way since the
early days of Android.
-Nick
On Jun 22, 10:25 am, Saša Živkov <ziv...@gmail.com> wrote:
Nicholas Mucci
"Unregistered User" and people can comment on that in the change when
its uploaded.
-Nick
On Wed, Jun 22, 2011 at 1:58 PM, Shawn Pearce <s...@google.com> wrote:
> On Wed, Jun 22, 2011 at 11:50, Nicholas Mucci <nick....@gmail.com> wrote:
>> There's a lot of us who champion Gerrit as an alternative to often
>> expensive or more difficult to use alternatives. We have the burden
>> or proving that using Gerrit in a corporate environment is a sound
>> business decision. This means that not only does Gerrit have to be
>> developer friendly, but it needs to be sufficiently PHB friendly.
>> Showing unregistered users as "Anonymous Coward" is just something
>> that PHBs can trip over.
>
> There are 19 references in the source tree. I would welcome a patch to
> change this to another string... if someone can come up with a more
> reasonable name for someone who has not given us a name to refer to
> them with. :-)
>
>
> $ git grep 'Anonymous Coward'
> ReleaseNotes/ReleaseNotes-2.0.11.txt:New users coming from Google
> Accounts OpenID provider where given a full name of "null null" rather
> than "Ano
> ReleaseNotes/ReleaseNotes-2.1.2.4.txt:Bug references were sometimes
> added as an 'Anonymous Coward' change
> ReleaseNotes/ReleaseNotes-2.1.7.txt:* issue 780 E-mail about failed
> merge should not use Anonymous Coward
> ReleaseNotes/ReleaseNotes-2.1.7.txt:Some email was sent as Anonymous
> Coward, even when the user had a
> gerrit-common/src/main/java/com/google/gerrit/common/data/AccountInfo.java:
> * Create an 'Anonymous Coward' account info, when only the id is kno
> gerrit-gwtui/src/main/java/com/google/gerrit/client/FormatUtil.java:
> * <li><code>Anonymous Coward <aut...@example.com></code>:
> missing nam
> gerrit-gwtui/src/main/java/com/google/gerrit/client/FormatUtil.java:
> * <li><code>Anonymous Coward (12)</code>: missing name and email
> address</l
> gerrit-gwtui/src/main/java/com/google/gerrit/client/GerritConstants.properties:anonymousCoward
> = Anonymous Coward
> gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java:
> String result = (account.getFullName() == null) ? "Anonymou
> gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java:
> return "Anonymous Coward";
> gerrit-server/src/main/java/com/google/gerrit/server/IdentifiedUser.java:
> name = "Anonymous Coward";
> gerrit-server/src/main/java/com/google/gerrit/server/IdentifiedUser.java:
> name = "Anonymous Coward";
> gerrit-server/src/main/java/com/google/gerrit/server/git/ReviewNoteHeaderFormatter.java:
> sb.append("Anonymous Coward #").append(user.getId())
> gerrit-server/src/main/java/com/google/gerrit/server/mail/FromAddressGeneratorProvider.java:
> fullName = "Anonymous Coward";
> gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java:
> return "Anonymous Coward";
> gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java:
> name = "Anonymous Coward #" + accountId;
> gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java:
> return "Anonymous Coward #" + accountId;
> gerrit-server/src/test/java/com/google/gerrit/server/mail/FromAddressGeneratorProviderTest.java:
> assertEquals("Anonymous Coward (Code Review)",
> gerrit-server/src/test/java/com/google/gerrit/server/mail/FromAddressGeneratorProviderTest.java:
> assertEquals("A Anonymous Coward B", r.name);
>
Martin Fick
> I can handle a quick search/replace patch. :) I'll go
> with "Unregistered User" and people can comment on that
> in the change when its uploaded.
Perhaps put it in the site.config?
Rob Heittman
Jean-Baptiste Queru
this string only applies to registered users who have no provided a
name.
Beware that Gerrit also uses "Anonymous Users" to mean "Unregistered
Users", so there's a risk of confusion if you go too close to that.
I imagine that "Not Sure" will also be considered unprofessional.
JBQ
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
--
Jean-Baptiste M. "JBQ" Queru
Software Engineer, Android Open-Source Project, Google.
Questions sent directly to me that have no reason for being private
will likely get ignored or forwarded to a public forum with no further
warning.
Jean-Baptiste Queru
JBQ
On Wed, Jun 22, 2011 at 12:49 PM, Nicholas Mucci <nick....@gmail.com> wrote:
> Ah, good points. Is something like "Name Unavailable" more palatable?
> I can think of times when people have had their name change to
> Anonymous Coward when our LDAP server is broken, and "Name
> Unavailable" would be a more helpful string to provide.
>
> -Nick
Martin Fick
it should stay the default. If someone has a problem, they
should be able to change it in the site.config.
...stepping out now to avoid any more bike shedding on
this naming.
-Martin
On Wednesday 22 June 2011 02:05:52 pm Jean-Baptiste Queru
wrote:
> >>>>/data/AccountInfo.java: * Create an 'Anonymous
> >>>> Coward' account info, when only the id is kno
> >>>> gerrit-gwtui/src/main/java/com/google/gerrit/client/
> >>>>FormatUtil.java: * <li><code>Anonymous Coward
> >>>> <aut...@example.com></code>: missing nam
> >>>> gerrit-gwtui/src/main/java/com/google/gerrit/client/
> >>>>FormatUtil.java: * <li><code>Anonymous Coward
> >>>> (12)</code>: missing name and email address</l
> >>>> gerrit-gwtui/src/main/java/com/google/gerrit/client/
> >>>>GerritConstants.properties:anonymousCoward =
> >>>> Anonymous Coward
> >>>> gerrit-server/src/main/java/com/google/gerrit/common
> >>>>/ChangeHookRunner.java: String result =
> >>>> (account.getFullName() == null) ? "Anonymou
> >>>> gerrit-server/src/main/java/com/google/gerrit/common
> >>>>/ChangeHookRunner.java: return "Anonymous Coward";
> >>>> gerrit-server/src/main/java/com/google/gerrit/server
> >>>>/IdentifiedUser.java: name = "Anonymous Coward";
> >>>> gerrit-server/src/main/java/com/google/gerrit/server
> >>>>/IdentifiedUser.java: name = "Anonymous Coward";
> >>>> gerrit-server/src/main/java/com/google/gerrit/server
> >>>>/git/ReviewNoteHeaderFormatter.java:
> >>>> sb.append("Anonymous Coward #").append(user.getId())
> >>>> gerrit-server/src/main/java/com/google/gerrit/server
> >>>>/mail/FromAddressGeneratorProvider.java: fullName =
> >>>> "Anonymous Coward";
> >>>> gerrit-server/src/main/java/com/google/gerrit/server
> >>>>/mail/OutgoingEmail.java: return "Anonymous Coward";
> >>>> gerrit-server/src/main/java/com/google/gerrit/server
> >>>>/mail/OutgoingEmail.java: name = "Anonymous Coward #"
> >>>> + accountId;
> >>>> gerrit-server/src/main/java/com/google/gerrit/server
> >>>>/mail/OutgoingEmail.java: return "Anonymous Coward #"
Shawn Pearce
> expensive or more difficult to use alternatives. We have the burden
> or proving that using Gerrit in a corporate environment is a sound
> business decision. This means that not only does Gerrit have to be
> developer friendly, but it needs to be sufficiently PHB friendly.
> Showing unregistered users as "Anonymous Coward" is just something
> that PHBs can trip over.
There are 19 references in the source tree. I would welcome a patch to
change this to another string... if someone can come up with a more
reasonable name for someone who has not given us a name to refer to
them with. :-)
$ git grep 'Anonymous Coward'
ReleaseNotes/ReleaseNotes-2.0.11.txt:New users coming from Google
Accounts OpenID provider where given a full name of "null null" rather
than "Ano
ReleaseNotes/ReleaseNotes-2.1.2.4.txt:Bug references were sometimes
added as an 'Anonymous Coward' change
ReleaseNotes/ReleaseNotes-2.1.7.txt:* issue 780 E-mail about failed
merge should not use Anonymous Coward
ReleaseNotes/ReleaseNotes-2.1.7.txt:Some email was sent as Anonymous
Coward, even when the user had a
gerrit-common/src/main/java/com/google/gerrit/common/data/AccountInfo.java:
* Create an 'Anonymous Coward' account info, when only the id is kno
gerrit-gwtui/src/main/java/com/google/gerrit/client/FormatUtil.java:
* <li><code>Anonymous Coward <aut...@example.com></code>:
missing nam
gerrit-gwtui/src/main/java/com/google/gerrit/client/FormatUtil.java:
* <li><code>Anonymous Coward (12)</code>: missing name and email
address</l
gerrit-gwtui/src/main/java/com/google/gerrit/client/GerritConstants.properties:anonymousCoward
= Anonymous Coward
gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java:
String result = (account.getFullName() == null) ? "Anonymou
gerrit-server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java:
return "Anonymous Coward";
gerrit-server/src/main/java/com/google/gerrit/server/IdentifiedUser.java:
name = "Anonymous Coward";
gerrit-server/src/main/java/com/google/gerrit/server/IdentifiedUser.java:
name = "Anonymous Coward";
gerrit-server/src/main/java/com/google/gerrit/server/git/ReviewNoteHeaderFormatter.java:
sb.append("Anonymous Coward #").append(user.getId())
gerrit-server/src/main/java/com/google/gerrit/server/mail/FromAddressGeneratorProvider.java:
fullName = "Anonymous Coward";
gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java:
return "Anonymous Coward";
gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java:
Nicholas Mucci
I can think of times when people have had their name change to
Anonymous Coward when our LDAP server is broken, and "Name
Unavailable" would be a more helpful string to provide.
-Nick
Jay Soffian
> My $.02 says that AC is well understood in most circles and
> it should stay the default. If someone has a problem, they
> should be able to change it in the site.config.
+1.
> ...stepping out now to avoid any more bike shedding on
> this naming.
+2.
j.
Swindells, Thomas
Thomas
> > gerrit-gwtui/src/main/java/com/google/gerrit/client/GerritConstants.pr
> > operties:anonymousCoward
> > = Anonymous Coward
> > gerrit-
> server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java:
> > String result = (account.getFullName() == null) ? "Anonymou
> > gerrit-
> server/src/main/java/com/google/gerrit/common/ChangeHookRunner.java:
> > return "Anonymous Coward";
> > gerrit-server/src/main/java/com/google/gerrit/server/IdentifiedUser.java:
> > name = "Anonymous Coward";
> > gerrit-server/src/main/java/com/google/gerrit/server/IdentifiedUser.java:
> > name = "Anonymous Coward";
> > gerrit-
> server/src/main/java/com/google/gerrit/server/git/ReviewNoteHeaderFor
> matter.java:
> > sb.append("Anonymous Coward #").append(user.getId())
> > gerrit-
> server/src/main/java/com/google/gerrit/server/mail/FromAddressGenerato
> rProvider.java:
> > fullName = "Anonymous Coward";
> > gerrit-
> server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java:
> > return "Anonymous Coward";
> > gerrit-
> server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java:
> > name = "Anonymous Coward #" + accountId;
> > gerrit-
> server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java:
> > return "Anonymous Coward #" + accountId;
> > gerrit-
> server/src/test/java/com/google/gerrit/server/mail/FromAddressGenerator
> ProviderTest.java:
> > assertEquals("Anonymous Coward (Code Review)",
> > gerrit-
> server/src/test/java/com/google/gerrit/server/mail/FromAddressGenerator
> ProviderTest.java:
> > assertEquals("A Anonymous Coward B", r.name);
> >
>
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
**************************************************************************************
This message is confidential and intended only for the addressee. If you have received this message in error, please immediately notify the postm...@nds.com and delete it from your system as well as any copies. The content of e-mails as well as traffic data may be monitored by NDS for employment and security purposes. To protect the environment please do not print this e-mail unless necessary.
NDS Limited. Registered Office: One London Road, Staines, Middlesex, TW18 4EX, United Kingdom. A company registered in England and Wales. Registered no. 3080780. VAT no. GB 603 8808 40-00
**************************************************************************************
Mihai Rusu
> I'd +1 "Name Unavailable" over "Unregistered User" for as Jean and others have pointed out this string also applies to registered users who haven't provided a name - or whose name isn't available because LDAP is playing up.
But it has to use the same string for these different cases? Could the
19 "Anonymous Coward" references be grouped in disjunct sets and use
better fit strings for their context?
--
Mihai Rusu
