copy-to-clipboard icon doesn't work

[이정구]

Hi,

I was previously using Gerrit 3.1.10 and moved to 3.5.1.
After migrating to 3.5.1, the copy-to-clipboard icon does not work on the download screen or repository screen of the Review UI.

Clicking the copy-to-clipboard icon does not actually copy.
What should I check?

[David Ostrovsky]

I cannot reproduce it. I use this gerrit 3.5.1 instance: [1].

Open download dialog and copy-to clipboard works just fine.

I tried both Chrome 101.0.4951.34  and FF 99.0 on Linux and

it worked as expected.

[1] https://gerrit.libreoffice.org/c/core/+/134898

 

What should I check?

[James Muir]

On Tue, May 24, 2022 at 4:35 PM David Ostrovsky <david.o...@gmail.com> wrote:

hyde...@gmail.com schrieb am Dienstag, 24. Mai 2022 um 08:08:46 UTC+2:

Hi,

I was previously using Gerrit 3.1.10 and moved to 3.5.1.
After migrating to 3.5.1, the copy-to-clipboard icon does not work on the download screen or repository screen of the Review UI.

Clicking the copy-to-clipboard icon does not actually copy.

I cannot reproduce it. I use this gerrit 3.5.1 instance: [1].

Open download dialog and copy-to clipboard works just fine.

I can reproduce this with gerrit 3.5.1-1 (running in a docker container).

When I navigate to http://172.17.0.3:8080/admin/repos/All-Projects,general and click the copy-to-clipboard icon, nothing happens.

But when I navigate to https://gerrit.libreoffice.org/admin/repos/All-Projects,general in the same browser and click the icon, it does work.

-James M

[이정구]

I'm using with gerrit docker image.

I tried to reproduce this issue wit various imaages.

Even though the same image was used, 

it was reproduced in some cases and not reproduced in some cases.

For example, when running 'docker run -ti -p 8100:8080 -p 29418:29418 gerritcodereview/gerrit:3.5.1',

I did click the copy-to-clipboard icon, but it didn't work. 

Junggu

2022년 5월 25일 수요일 오후 12시 42분 49초 UTC+9에 jm...@crypto4a.com님이 작성:

[Dhruv Srivastava]

The clipboard copy API requires a secure origin hence `http` won't work but `https` works fine.

More details here: https://stackoverflow.com/questions/51805395/navigator-clipboard-is-undefined

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAM-GoEVs%2BjRHKFFwdX%3DFTRbwgYe_wG9%3DUUFjzQwoHHPX37wioQ%40mail.gmail.com.

[James Muir]

On Wed, May 25, 2022 at 3:07 AM Dhruv Srivastava <dhru...@google.com> wrote:

The clipboard copy API requires a secure origin hence `http` won't work but `https` works fine.

More details here: https://stackoverflow.com/questions/51805395/navigator-clipboard-is-undefined

Thanks for pointing this out.  I had wondered if http vs https could possibly explain the difference.

-James M

[이정구]

After modifying Chrome Setting ( 'chrome://flags' -> Insecure origins treated as secure ), I can use the copy-to-clipbaord icon.

Thanks,

Junggu

2022년 5월 26일 목요일 오전 12시 53분 0초 UTC+9에 jm...@crypto4a.com님이 작성: