User Suggested Edits - Applying all fixes in a single patchset

[atav...@yext.com]

Hi folks,

Is it currently possible for a user to apply multiple user-suggested edits into single patchset, before clicking Publish Edit? We've had users report that applying more than one in the same edit is not possible through the UI (at least, without manually implementing the suggested fixes past the 1st one, via the code editor).

Relatedly, is it possible to apply edits in sequential patchsets, if doing so does not result in any conflicts? After publishing the first one, the others' "APPLY FIX" buttons are disabled, with "You cannot apply this fix because it is from a previous patchset" appearing at the bottom of the user suggestion dialog.

The above was observed in Gerrit v3.9.7

Thanks in advance

[atav...@yext.com]

*bumping in case this was missed & someone knows the answer*

[Milutin Kristofic]

Hi, 
Thank you for using user suggested edits! I am improving applying fixes in Gerrit so for small edits users don't even need to go back to IDE. Please see my responses below.

On Monday, March 3, 2025 at 6:21:34 PM UTC+1 atav...@yext.com wrote:

*bumping in case this was missed & someone knows the answer*

On Friday, February 14, 2025 at 6:10:49 PM UTC-5 atav...@yext.com wrote:

Hi folks,

Is it currently possible for a user to apply multiple user-suggested edits into single patchset, before clicking Publish Edit? We've had users report that applying more than one in the same edit is not possible through the UI (at least, without manually implementing the suggested fixes past the 1st one, via the code editor).

Yes, you can apply multiple user suggested edits in one edit. Of course it fails if they are merge conflicts - like modifying same lines, it can failed. Please file bugs if you find cases that applying second user suggested edit fails.

 

Relatedly, is it possible to apply edits in sequential patchsets, if doing so does not result in any conflicts? After publishing the first one, the others' "APPLY FIX" buttons are disabled, with "You cannot apply this fix because it is from a previous patchset" appearing at the bottom of the user suggestion dialog.

 

We recently improved applying fixes that you can apply fix even from older patchsets. https://gerrit-review.git.corp.google.com/c/gerrit/+/439124 
It applies suggested edit on old patchset creates patch and apply this patch on latest patchset. I don't know in which Gerrit version this will be released.

[Nasser Grainawi]

It was released in Gerrit v3.11.0.

 

 

The above was observed in Gerrit v3.9.7

Thanks in advance

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/repo-discuss/336b7108-09de-404e-872b-87beb4be2a82n%40googlegroups.com.

[atav...@yext.com]

Thank you!

In v3.9.7 at least, I can reproducibly confirm that attempting to apply multiple suggested edits before clicking "Publish Edit" does not work, unless the edits after the first are typed in manually. More specifically, after the first edit is applied and an `edit` patchset exists, clicking "Show Edit" for any other patchset shows the "Apply Fix" button as disabled, with an info footer that says "You cannot apply this fix because it is from a previous patchset".

It sounds like the fix linked above should also take care of this, if patchsets that precede the ephemeral `edit` patchset are considered "previous patchsets"? We'll try out v3.11.0 and if there are still issues, I'll open/link a bug report.

Thanks again!