notedb.config vs gerrit.config

385 views
Skip to first unread message

Marcelo Ávila de Oliveira

unread,
May 14, 2018, 3:56:25 PM5/14/18
to Repo and Gerrit Discussion
I just updated Gerrit (in a non-production environment) from 2.14.3 to 2.15.1 running:

java -jar gerrit-2.15.1.war init --delete-caches --site-path GERRIT-SITE
java -jar gerrit-2.15.1.war migrate-to-note-db --site-path GERRIT-SITE

The following notedb.config was created:

[noteDb "changes"]
autoMigrate = false
trial = false
write = true
read = true
sequence = true
primaryStorage = note db
disableReviewDb = false

After that must I move these contents definitely to the gerrit.config file?

Considering I have executed an offline migration, I was expecting to get "disableReviewDb = true". Is "false" the correct value in this case?

Thanks & regards,

--
Marcelo Ávila de Oliveira

Marcelo Ávila de Oliveira

unread,
May 17, 2018, 2:53:18 PM5/17/18
to Repo and Gerrit Discussion
Kindly reminder...

--
Marcelo Ávila de Oliveira

luca.mi...@gmail.com

unread,
May 17, 2018, 4:54:15 PM5/17/18
to Marcelo Ávila de Oliveira, Repo and Gerrit Discussion
Disclaimer: not a NoteDb expert, however see my feedback below

Sent from my iPhone

On 17 May 2018, at 19:52, Marcelo Ávila de Oliveira <mav...@cpqd.com.br> wrote:

Kindly reminder...

--
Marcelo Ávila de Oliveira

Em seg, 14 de mai de 2018 às 16:55, Marcelo Ávila de Oliveira <mav...@cpqd.com.br> escreveu:
I just updated Gerrit (in a non-production environment) from 2.14.3 to 2.15.1 running:

java -jar gerrit-2.15.1.war init --delete-caches --site-path GERRIT-SITE
java -jar gerrit-2.15.1.war migrate-to-note-db --site-path GERRIT-SITE

The following notedb.config was created:

[noteDb "changes"]
autoMigrate = false
trial = false
write = true
read = true
sequence = true
primaryStorage = note db
disableReviewDb = false

Yes, it is created and updated multiple times with changes in the flag values during the different stages of te migration


After that must I move these contents definitely to the gerrit.config file?

Nope, leave it as is in its final stage


Considering I have executed an offline migration, I was expecting to get "disableReviewDb = true". Is "false" the correct value in this case?

Some of the changes failed to be migrated, they are still in ReviewDb and read from them. That’s why the final stage of flagging is not complete yet.

If you care about those changes, you need to investigate. Otherwise, just flip the flag, backup the current reviewdb and then you can get rid of the changes and related tables.

HTH


Thanks & regards,

--
Marcelo Ávila de Oliveira

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Marcelo Ávila de Oliveira

unread,
May 18, 2018, 7:21:17 AM5/18/18
to Luca Milanesio, Repo and Gerrit Discussion
Em qui, 17 de mai de 2018 às 17:54, <luca.mi...@gmail.com> escreveu:

Some of the changes failed to be migrated, they are still in ReviewDb and read from them. That’s why the final stage of flagging is not complete yet.

If you care about those changes, you need to investigate. Otherwise, just flip the flag, backup the current reviewdb and then you can get rid of the changes and related tables.
 
Great, The migration was done in a test environment with a limited number of repositories, because of that, a lot of changes was not migrated.

Thanks a lot Luca.

luca.mi...@gmail.com

unread,
May 18, 2018, 7:24:08 AM5/18/18
to Marcelo Ávila de Oliveira, Repo and Gerrit Discussion


Sent from my iPhone
Ok, that explains why ReviewDb is still flagged as enabled


Thanks a lot Luca.
Reply all
Reply to author
Forward
0 new messages