gerrit 2.12: 500 internal server error shown in submitted together field in change screen

410 views
Skip to first unread message

Makson Lee

unread,
Jan 12, 2016, 12:22:21 AM1/12/16
to Repo and Gerrit Discussion
when access a specific change, 500 internal server error shown in submitted together field, also, the submit button didn't show up, we found the following error in log file, then we need to set index.defaultMaxClauseCount to 8192 to avoid the error, is this expected behavior?

[2016-01-12 12:10:23,449] [main] INFO  org.eclipse.jetty.server.Server : Started @12024ms
[2016-01-12 12:10:23,451] [main] INFO  com.google.gerrit.pgm.Daemon : Gerrit Code Review 2.12 ready
[2016-01-12 12:10:40,890] [HTTP-69] ERROR com.google.gerrit.server.change.SubmittedTogether : Error on getting a ChangeSet
com.google.gwtorm.server.OrmException: com.google.gerrit.server.query.QueryParseException: cannot create query for index: (exactcommit:4cb9975cf6d9ce16d75a3646910ec65d5b5b8aeb OR exactcommit:538d3ee2d2bfbb21ce2a23cb5be4609b7f65f18a OR exactcommit:304091c3880a2e8e9d47c22ea0a9dff1b22dee78 OR exactcommit:739f7ac3bdb98f8a08a60d309bd0b3bad666d687 OR exactcommit:7a80148a7df249ffb93b6e6b9598b0446c6ed752 OR exactcommit:4e76c860cc669b194a9c3888c3c57323b5d7f3ab OR exactcommit:568a34f8789ab80cbc698864ba498458db0acc7e OR exactcommit:8a99ad1f98f82c81ac82c685bc97e8bffd9cdc92 OR exactcommit:a435a8cb3fc491200ef05e2d8933965e5e670178 OR exactcommit:f2f51ccb8bfa1b2f76d3a288f922f3dcac8e46ff OR exactcommit:7a05eb3108d75eaf1e64e0d66a4f0511bb049aba OR exactcommit:00052be30578ee8ebae71cfe452c0d455a5cd1b4 OR exactcommit:f6d41d2709fa3a5d16b3d65784adfcd622c6cef6 OR exactcommit:37bd361ce212ac631c9b9c3691d9de4e2676afb5 OR exactcommit:972b2e30161a6feba906d5e8a2f6fe1706f8ab14 OR exactcommit:edd91ed96024cbce68d5c18024f1a99b47bfa04a OR exactcommit:ae3da19a4b5d6042ed6f785e322c38265f65afde OR exactcommit:02afa0c9d6a49f6f8927e86f57600883ca4e021e OR exactcommit:f5c82e61078cfd5c9e6f64a17f00435362e0ad95 OR exactcommit:4b6f95f6abc4cd89c1ce6ca4fbf0b42f2cd477ab OR ...
...
        at com.google.gerrit.lucene.QueryBuilder.or(QueryBuilder.java:91)
        at com.google.gerrit.lucene.QueryBuilder.toQuery(QueryBuilder.java:72)
        at com.google.gerrit.lucene.QueryBuilder.and(QueryBuilder.java:110)
        at com.google.gerrit.lucene.QueryBuilder.toQuery(QueryBuilder.java:70)
        at com.google.gerrit.lucene.LuceneChangeIndex.getSource(LuceneChangeIndex.java:366)
        at com.google.gerrit.server.index.IndexedChangeQuery.<init>(IndexedChangeQuery.java:67)
        at com.google.gerrit.server.index.IndexRewriter.rewrite(IndexRewriter.java:138)
        at com.google.gerrit.server.query.change.QueryProcessor.queryChanges(QueryProcessor.java:144)
        at com.google.gerrit.server.query.change.QueryProcessor.queryChanges(QueryProcessor.java:103)
        at com.google.gerrit.server.query.change.QueryProcessor.queryChanges(QueryProcessor.java:87)
        at com.google.gerrit.server.query.change.InternalChangeQuery.query(InternalChangeQuery.java:245)
        ... 49 more
Caused by: org.apache.lucene.search.BooleanQuery$TooManyClauses: maxClauseCount is set to 1024
        at org.apache.lucene.search.BooleanQuery$Builder.add(BooleanQuery.java:127)
        at com.google.gerrit.lucene.QueryBuilder.or(QueryBuilder.java:87)
        ... 59 more

Luca Milanesio

unread,
Jan 12, 2016, 2:51:09 AM1/12/16
to Makson Lee, Repo and Gerrit Discussion
Hi Markson,
unfortunately yes, it is expected.

Luca.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Makson Lee

unread,
Jan 12, 2016, 3:11:12 AM1/12/16
to Repo and Gerrit Discussion, cdle...@gmail.com
Hi Luca,

thanks for confirming, but then why we set index.defaultMaxClauseCount, if clause count exceed the limit, submit button would not show up, that means we don't allow user to submit the change?

Makson

luca.mi...@gmail.com

unread,
Jan 12, 2016, 3:16:37 AM1/12/16
to Makson Lee, Repo and Gerrit Discussion
It should be actually considered a bug IMHO as the UX is basically broken :-(

I do understand that in those conditions we cannot show all the potential conflicts or relations with other changes, but a minimal degraded UX should still be available.

Luca

Sent from my iPhone
--

Makson Lee

unread,
Jan 12, 2016, 3:24:23 AM1/12/16
to Repo and Gerrit Discussion, cdle...@gmail.com
Got it.

Makson

Bassem Rabil

unread,
Jan 12, 2016, 8:09:10 AM1/12/16
to Repo and Gerrit Discussion, cdle...@gmail.com
What do you get if you increase index.defaultMaxClauseCount to for example 2048 to workaround this current limitation ?

Regards
Bassem

Makson Lee

unread,
Jan 12, 2016, 8:42:00 AM1/12/16
to Repo and Gerrit Discussion, cdle...@gmail.com
Actually we are okay with that limitation if user can still submit change, in our case, we need to set index.defaultMaxClauseCount to about 8000 so that the submit button can be shown up.



Makson

Bassem Rabil

unread,
Jan 12, 2016, 10:52:06 AM1/12/16
to Repo and Gerrit Discussion, cdle...@gmail.com
I submitted an issue [1] for this broken UI, increasing the index.defaultMaxClauseCount would result in query poor performance [2] as documented with index,maxTerms.

Reply all
Reply to author
Forward
0 new messages