[ANNOUNCE] Gerrit 2.7

Dave Borowitz

unread,

Sep 18, 2013, 6:40:39 PM9/18/13

to repo-discuss

I am pleased to announce Gerrit Code Review 2.7

Release notes:

http://gerrit-documentation.googlecode.com/svn/ReleaseNotes/ReleaseNotes-2.7.html

This is a new stable release. It is something of a transitional release between 2.6 and the major new features coming in 2.8. It includes some additional project configuration options (copyMaxScore for labels, per-project commentlinks and themes), more avatars, better binary support, some new REST APIs, and a bundle of bugfixes.

Download:

http://gerrit-releases.storage.googleapis.com/gerrit-2.7.war

Edwin Kempin

unread,

Sep 19, 2013, 1:12:10 AM9/19/13

to Dave Borowitz, repo-discuss

Hey, that's great news that 2.7 is now released :-)

Dave, thanks for driving this release!

2013/9/19 Dave Borowitz <dbor...@google.com>

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Luca Milanesio

unread,

Sep 19, 2013, 2:10:11 AM9/19/13

to Dave Borowitz, repo-discuss, Patrick Renaud

Wow, that's fantastic news ! Congratulations :-)

The per-project comment links will enable as well a more flexible hooks-its (Jira, BugZilla, Rational) integration.

It means each project can define their restriction and issue links pattern.

Very very good :-)

Luca
---------

Sent from my iPhone

Luca Milanesio

Skype: lucamilanesio

--

Deniz Türkoglu

unread,

Sep 19, 2013, 2:31:15 AM9/19/13

to Dave Borowitz, repo-discuss

Great work. Is this2.7rc5 tagged final?

I blame it on the phone for not checking myself :)

-deniz

--

Edwin Kempin

unread,

Sep 19, 2013, 2:36:43 AM9/19/13

to Deniz Türkoglu, Dave Borowitz, repo-discuss

2013/9/19 Deniz Türkoglu <de...@spotify.com>

Great work. Is this2.7rc5 tagged final?

No, there are couple of fixes on top:

$ git log --oneline v2.7-rc5...v2.7
01cea13 Set version to 2.7
a32c3ce Merge branch 'stable-2.6' into stable-2.7
6b12b35 Fix installation of plugins
3347628 Merge "Merge branch 'stable-2.6' into stable-2.7" into stable-2.7
88976d4 Merge branch 'stable-2.6' into stable-2.7
72fa3c2 Fix change stuck in SUBMITTED state but actually merged
ce4d28c Merge "Mark ALREADY_MERGED changes as merged in the DB and run hooks" into stable-2.7
640b95c Merge "NPE when deleting draft patch set when previous draft already deleted" into stable-2.6
5ff6ebe Remove documentation links from admin page
357b5be NPE when deleting draft patch set when previous draft already deleted
f9f46bd Fix example for 'test-submit rule' in Prolog cookbook
cdff6cf Mark ALREADY_MERGED changes as merged in the DB and run hooks

Dave Borowitz

unread,

Sep 19, 2013, 10:20:49 AM9/19/13

to Edwin Kempin, repo-discuss, Deniz Türkoglu

Yes, I was able to be convinced that the last few fixes were low risk and high reward enough to make it in without waiting yet another week for a new rc.

Dariusz Luksza

unread,

Sep 19, 2013, 10:24:26 AM9/19/13

to Dave Borowitz, repo-discuss

Yeah! That's great news! 2.7 finally out! :D

btw. What are the plans about cutting out 2.8-rc0?

> --
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to repo-discuss...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

--

Best regards

GSM: +49 017 445 41235
Blog: http://luksza.org
LinkedIn: http://www.linkedin.com/in/dariuszluksza

David Pursehouse

unread,

Sep 19, 2013, 8:48:04 PM9/19/13

to repo-d...@googlegroups.com

On 09/19/2013 11:24 PM, Dariusz Luksza wrote:
> Yeah! That's great news! 2.7 finally out! :D
>
> btw. What are the plans about cutting out 2.8-rc0?
>

There are some features still under development that I think ought to be
in a more completed state before we make stable-2.8:

- New change screen
- UI actions
- Secondary index and additional query operators

There's also the inline editing feature, but that seems to still be in
early stages and might be better deferred to 2.9?

Does the end of next month sound reasonable for 2.8-rc0?

Shawn Pearce

unread,

Sep 20, 2013, 12:16:11 AM9/20/13

to David Pursehouse, repo-discuss

On Thu, Sep 19, 2013 at 5:48 PM, David Pursehouse
<david.pu...@sonymobile.com> wrote:
> On 09/19/2013 11:24 PM, Dariusz Luksza wrote:
>>
>> Yeah! That's great news! 2.7 finally out! :D
>>
>> btw. What are the plans about cutting out 2.8-rc0?
>>
>
> There are some features still under development that I think ought to be in
> a more completed state before we make stable-2.8:
>
> - New change screen
> - UI actions
> - Secondary index and additional query operators

Ack, this makes sense to me.

> There's also the inline editing feature, but that seems to still be in early
> stages and might be better deferred to 2.9?

Given how little time I have been able to (recently) devote to the 3
topics you suggested above, I fear this wouldn't be ready in time for
2.8 and maybe has to defer until 2.9.

> Does the end of next month sound reasonable for 2.8-rc0?

Maybe? I am having trouble devoting sufficient time to the 3 topics
above for 2.8, and I will be out of the office 3 out of 4 weeks in
October (1 week vacation, 1 week in office, 1 week vacation, 1 week at
EclipseCon).

Fortunately there are others that can help. :-)

Annulen

unread,

Sep 20, 2013, 5:56:37 AM9/20/13

to repo-d...@googlegroups.com

There are some features still under development that I think ought to be
in a more completed state before we make stable-2.8:

- New change screen

Will it be possible to configure Gerrit to use old change screen via preferences?

David Pursehouse

unread,

Sep 20, 2013, 5:59:40 AM9/20/13

to repo-d...@googlegroups.com

As far as I know the plan is to make the new one default (a change has
already been uploaded [1] to do that) and remove the old one completely.

[1] https://gerrit-review.googlesource.com/#/c/49601/

Edwin Kempin

unread,

Sep 20, 2013, 8:54:16 AM9/20/13

to Shawn Pearce, David Pursehouse, repo-discuss

2013/9/20 Shawn Pearce <s...@google.com>

I vote for releasing Gerrit 2.8 without waiting for any features to be ready (even
if Shawn would be fully available). Sure the new change screen, UI actions and
additional query operators are cool and I want to have them rather sooner than
later, but for 2.6 we already have almost 1000 commits [1] that for sure make a
great release.

What happened to the idea to release more often?

If at the end of October the listed features are ready we can simply release them
as Gerrit 2.9 then.

[1]
$ git rev-list --no-merges --count v2.7...HEAD
980

Edwin Kempin

unread,

Sep 20, 2013, 9:00:09 AM9/20/13

to David Pursehouse, Repo and Gerrit Discussion

2013/9/20 David Pursehouse <david.pu...@sonymobile.com>

On 09/20/2013 06:56 PM, Annulen wrote:

There are some features still under development that I think ought
to be
in a more completed state before we make stable-2.8:

- New change screen

Will it be possible to configure Gerrit to use old change screen via
preferences?

As far as I know the plan is to make the new one default (a change has already been uploaded [1] to do that) and remove the old one completely.

I would prefer to have at least one release where the new change screen
is the default, but users can still choose to use the old screen (e.g. by a
user preference). This would make the roll out much easier. I'm a fan of the
new change screen but I'm afraid that we have many users that are just so
much used to the old change screen that they will complain about the redesign.

Having a release with both screens gives our users some time to get used

to the new screen and they are in control about the moment when they want

to switch. Once this release is out, as a first thing we can delete the old screen.

[1] https://gerrit-review.googlesource.com/#/c/49601/

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

--- You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

Dariusz Luksza

unread,

Sep 20, 2013, 10:31:38 AM9/20/13

to Edwin Kempin, Shawn Pearce, David Pursehouse, repo-discuss

On Fri, Sep 20, 2013 at 2:54 PM, Edwin Kempin <edwin....@gmail.com> wrote:
>> Fortunately there are others that can help. :-)
>
> I vote for releasing Gerrit 2.8 without waiting for any features to be ready
> (even
> if Shawn would be fully available). Sure the new change screen, UI actions
> and
> additional query operators are cool and I want to have them rather sooner
> than
> later, but for 2.6 we already have almost 1000 commits [1] that for sure
> make a
> great release.
> What happened to the idea to release more often?
> If at the end of October the listed features are ready we can simply release
> them
> as Gerrit 2.9 then.
>
> [1]
> $ git rev-list --no-merges --count v2.7...HEAD
> 980

+1 for releasing 2.8 as early as possible. For me it will make porting
my changes (including auth backend and secure store) in our gerrit
"fork" much easier...

Luca Milanesio

unread,

Sep 20, 2013, 10:41:32 AM9/20/13

to repo-discuss, Edwin Kempin, Dariusz Luksza, Shawn Pearce, David Pursehouse

I would need some review on the auto-reload for the replication plugin though:
https://gerrit-review.googlesource.com/#/c/49820/

It is a plugin anyway, and can be even plugged later on ;-) ... it would be nice to have anyway this change merged in the standard distribution of Gerrit 2.8.

Luca.

Patrick Renaud

unread,

Sep 20, 2013, 10:46:02 AM9/20/13

to Dariusz Luksza, Edwin Kempin, Shawn Pearce, David Pursehouse, repo-discuss

True, but it would be even better if Dariusz's auth backend changes were integrated in 2.8 in the first place instead of having to maintain a fork ;-)

-Patrick

Dariusz Luksza

unread,

Sep 20, 2013, 10:48:08 AM9/20/13

to Patrick Renaud, Edwin Kempin, Shawn Pearce, David Pursehouse, repo-discuss

True, it would be best if this could be merged into 2.8. Thanks
Patrick for pointing that out!

Deniz Türkoglu

unread,

Sep 20, 2013, 11:13:22 AM9/20/13

to Edwin Kempin, David Pursehouse, Repo and Gerrit Discussion

I agree with Edwin on both; lets first make it possible to use current change screen but have all the great features on c2 and work only on c2, this should encourage migration.

As for 2.8, I would say lets have regular cuts, and cuts are not based on feature but time. This will avoid the gaps we have been having with the recents releases, such as 2.6 :)

All in all, great mail Edwin, huge +1 :)

To unsubscribe, email repo-discuss...@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

Shawn Pearce

unread,

Sep 20, 2013, 11:17:46 AM9/20/13

to Deniz Türkoglu, Edwin Kempin, repo-discuss, David Pursehouse

OK, should we add a preference for which ChangeScreen the user wants, and then cut 2.8-rc0 at the end of this month?

Edwin Kempin

unread,

Sep 20, 2013, 11:20:26 AM9/20/13

to Shawn Pearce, Deniz Türkoglu, repo-discuss, David Pursehouse

2013/9/20 Shawn Pearce <s...@google.com>

OK, should we add a preference for which ChangeScreen the user wants, and then cut 2.8-rc0 at the end of this month?

+1 :-)

Jeff

unread,

Sep 20, 2013, 11:38:18 AM9/20/13

to repo-d...@googlegroups.com, Shawn Pearce, Deniz Türkoglu, David Pursehouse

Likewise. I think the ability to gently nudge users into the new ChangeScreen will be extremely beneficial.

Deniz Türkoglu

unread,

Sep 20, 2013, 12:50:23 PM9/20/13

to Edwin Kempin, Shawn Pearce, repo-discuss, David Pursehouse

/me likes :)

+1

Mark Derricutt

unread,

Sep 20, 2013, 7:35:59 PM9/20/13

to Edwin Kempin, David Pursehouse, Repo and Gerrit Discussion

Edwin,

Is there a screenshot ( or better, can someone do a quick screencast ) showing the new change screen in action?

Maybe get some public viewing of the changes before it lands on a release will at least lower any shock one may have?

Mark

--

Mark Derricutt — twitter — podcast — blog — google+

signature.asc

Dave Borowitz

unread,

Sep 20, 2013, 7:39:52 PM9/20/13

to Mark Derricutt, Edwin Kempin, David Pursehouse, Repo and Gerrit Discussion

It's been live on googlesource.com for a while now, but it's hidden. Go to any change page and change /c/ to /c2/, e.g.:

https://gerrit-review.googlesource.com/#/c2/50001/

https://android-review.googlesource.com/#/c2/66020/

You'll have the new change screen until you reload the page.

As discussed one of the things we want to do soon is make this a user preference so you can turn it on from your settings page.

Jonathan Nieder

unread,

Sep 20, 2013, 7:42:05 PM9/20/13

to Mark Derricutt, Edwin Kempin, David Pursehouse, Repo and Gerrit Discussion

Mark Derricutt wrote:

> Is there a screenshot ( or better, can someone do a quick screencast
> ) showing the new change screen in action?

You can try it out by viewing any change on gerrit-review[1] or
android-review[2] and then changing the /c/ in the URL to /c2/.

Feel free to play with it and report any problems you run into. It is
generally usable, but it is still missing some features (e.g., adding
reviewers to a change). Issue 2065[3] lists blockers before it can
become the default change screen.

[1] https://gerrit-review.googlesource.com/
[2] https://android-review.googlesource.com/
[3] https://code.google.com/p/gerrit/issues/detail?id=2065

Mark Derricutt

unread,

Sep 20, 2013, 8:20:19 PM9/20/13

to Jonathan Nieder, Edwin Kempin, David Pursehouse, Repo and Gerrit Discussion

On 21/09/2013, at 11:42 AM, Jonathan Nieder <j...@google.com> wrote:

You can try it out by viewing any change on gerrit-review[1] or
android-review[2] and then changing the /c/ in the URL to /c2/.

Awesome, that should have been an alternative question - if it was live anywhere one could see. Cheers..

My immediate thoughts, whilst 99% positive are "where the heck did unified diff go".

I remember seeing on the list awhile a discussion on maybe removing it, but I'm terribly sad to see it go, even tho it was sometimes a bit flaky and generated strange diffs regarding indents/whitespace.

On the whole I think it looks good - much more usable, love the JS regex search! Altho, pressing ? brings up that regex search when viewing a change, which overrides the general ? hotkey help that I was expecting to find...

Look forward to running this in our prod...

signature.asc

Ian Kumlien

unread,

Sep 21, 2013, 9:36:56 AM9/21/13

to Mark Derricutt, Jonathan Nieder, Edwin Kempin, David Pursehouse, Repo and Gerrit Discussion

Hi,

Upgraded the production system to gerrit 2.7 and i have found some oddities in "gerrit gc".

First of all, when running gerrit gc, i had two projects fail - one of the failures was due to a "idx" file not existing?

(It was there all the time, this is a local filesystem, must have been a locking issue)

Stacktrace:

org.eclipse.jgit.api.errors.JGitInternalException: Could not get repository statistics

at org.eclipse.jgit.api.GarbageCollectCommand.getStatistics(GarbageCollectCommand.java:145)

at com.google.gerrit.server.git.GarbageCollection.run(GarbageCollection.java:83)

at com.google.gerrit.sshd.commands.GarbageCollectionCommand.runGC(GarbageCollectionCommand.java:97)

at com.google.gerrit.sshd.commands.GarbageCollectionCommand.access$500(GarbageCollectionCommand.java:41)

at com.google.gerrit.sshd.commands.GarbageCollectionCommand$1.run(GarbageCollectionCommand.java:67)

at com.google.gerrit.sshd.BaseCommand$TaskThunk.run(BaseCommand.java:429)

at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)

at java.util.concurrent.FutureTask.run(FutureTask.java:262)

at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)

at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)

at com.google.gerrit.server.git.WorkQueue$Task.run(WorkQueue.java:337)

at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)

at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)

at java.lang.Thread.run(Thread.java:724)

Caused by: java.io.FileNotFoundException: /path/to/git.git/objects/pack/pack-<sha1 id>.idx (No such file or directory)

at java.io.FileInputStream.open(Native Method)

at java.io.FileInputStream.<init>(FileInputStream.java:146)

at org.eclipse.jgit.internal.storage.file.PackIndex.open(PackIndex.java:94)

at org.eclipse.jgit.internal.storage.file.PackFile.idx(PackFile.java:167)

at org.eclipse.jgit.internal.storage.file.PackFile.getIndex(PackFile.java:193)

at org.eclipse.jgit.internal.storage.file.GC.getStatistics(GC.java:867)

at org.eclipse.jgit.api.GarbageCollectCommand.getStatistics(GarbageCollectCommand.java:143)

... 13 more

[2013-09-21 13:09:15,595] ERROR com.google.gerrit.server.git.GarbageCollection : [gerrit/project]