Gerrit 3.6.1 identify text file with other language as binary file

367 views
Skip to first unread message

程洋

unread,
Jun 21, 2022, 11:56:58 PM6/21/22
to Repo and Gerrit Discussion
After upgrading gerrit to 3.6.1. I found files in change with Chinese will be recognised as binary.
Is it a bug or i need add any configuration?

But i tested latest android-review gerrit. it doesn't have this problem

pon...@gmail.com

unread,
Jun 22, 2022, 5:45:47 AM6/22/22
to Repo and Gerrit Discussion
Hi,
it is working fine for me. I tried on a vanilla 3.6.1 and it looks ok to me [1].

I tried on gerrithub.io which is in 3.6.1-1-g94891ef662 and it looks ok there as well [2].

I can't think of any setting affecting it TBH.

Thanks,
Ponch

Nasser Grainawi

unread,
Jun 22, 2022, 4:46:49 PM6/22/22
to pon...@gmail.com, Repo and Gerrit Discussion
On Wed, Jun 22, 2022 at 3:45 AM pon...@gmail.com <pon...@gmail.com> wrote:
Hi,
it is working fine for me. I tried on a vanilla 3.6.1 and it looks ok to me [1].

I tried on gerrithub.io which is in 3.6.1-1-g94891ef662 and it looks ok there as well [2].

I can't think of any setting affecting it TBH.

gitattributes can affect if files are considered binary or not: https://git-scm.com/docs/gitattributes#_marking_files_as_binary
 

Thanks,
Ponch

[2]: https://pasteboard.co/lw15x9dcRELU.png

On Wednesday, 22 June 2022 at 05:56:58 UTC+2 d171...@gmail.com wrote:
After upgrading gerrit to 3.6.1. I found files in change with Chinese will be recognised as binary.
Is it a bug or i need add any configuration?

But i tested latest android-review gerrit. it doesn't have this problem

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/9ea76db8-5200-4227-a792-b8bd6afd6de0n%40googlegroups.com.

Matthias Sohn

unread,
Jun 22, 2022, 5:06:07 PM6/22/22
to Nasser Grainawi, pon...@gmail.com, Repo and Gerrit Discussion
On Wed, Jun 22, 2022 at 10:46 PM Nasser Grainawi <nasser....@linaro.org> wrote:


On Wed, Jun 22, 2022 at 3:45 AM pon...@gmail.com <pon...@gmail.com> wrote:
Hi,
it is working fine for me. I tried on a vanilla 3.6.1 and it looks ok to me [1].

I tried on gerrithub.io which is in 3.6.1-1-g94891ef662 and it looks ok there as well [2].

I can't think of any setting affecting it TBH.

gitattributes can affect if files are considered binary or not: https://git-scm.com/docs/gitattributes#_marking_files_as_binary

git also considers files binary if they contain NUL or lone CR bytes or many non-printable characters:
jgit uses the first two of these heuristics

 

Thanks,
Ponch

[2]: https://pasteboard.co/lw15x9dcRELU.png

On Wednesday, 22 June 2022 at 05:56:58 UTC+2 d171...@gmail.com wrote:
After upgrading gerrit to 3.6.1. I found files in change with Chinese will be recognised as binary.
Is it a bug or i need add any configuration?

But i tested latest android-review gerrit. it doesn't have this problem

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/9ea76db8-5200-4227-a792-b8bd6afd6de0n%40googlegroups.com.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages