|=> //plugins/replication:replication__plugin__compile... 0.3s (running javac[0.3s])
Log:
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:238: error: cannot find symbol
&& GitRepositoryManager.REF_CONFIG.equals(head.getLeaf().getName())) {
^
symbol: variable REF_CONFIG
location: interface com.google.gerrit.server.git.GitRepositoryManager
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:436: error: cannot find symbol
if (!replicatePermissions && GitRepositoryManager.REF_CONFIG.equals(ref)) {
^
symbol: variable REF_CONFIG
location: interface com.google.gerrit.server.git.GitRepositoryManager
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java:477: error: cannot find symbol
return !(noPerms && GitRepositoryManager.REF_CONFIG.equals(ref)) &&
^
symbol: variable REF_CONFIG
location: interface com.google.gerrit.server.git.GitRepositoryManager
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/PushOne.java:478: error: cannot find symbol
!ref.startsWith(GitRepositoryManager.REFS_CACHE_AUTOMERGE);
^
symbol: variable REFS_CACHE_AUTOMERGE
location: interface com.google.gerrit.server.git.GitRepositoryManager
Errors: 4. Warnings: 0.
So I decided to take a look at the other GitRepositoryManagers under the gerrit-server ...longpath...server/git/GitRepositoryManager.java
I've checked both the 2.8 and 2.7 versions
and found that the difference between 2.7 and 2.8 is
/** Note tree listing commits we refuse {@code refs/meta/reject-commits} */
public static final String REF_REJECT_COMMITS = "refs/meta/reject-commits";
/** Configuration settings for a project {@code refs/meta/config} */
public static final String REF_CONFIG = "refs/meta/config";
/** Configurations of project-specific dashboards (canned search queries). */
public static String REFS_DASHBOARDS = "refs/meta/dashboards/";
/**
* Prefix applied to merge commit base nodes.
* <p>
* References in this directory should take the form
* {@code refs/cache-automerge/xx/yyyy...} where xx is
* the first two digits of the merge commit's object
* name, and yyyyy... is the remaining 38. The reference
* should point to a treeish that is the automatic merge
* result of the merge commit's parents.
*/
public static final String REFS_CACHE_AUTOMERGE = "refs/cache-automerge/";
So... I decided to add it to my stable-2.8 branch and the plugin built properly but at the time of installing it I'm getting:
com.google.gerrit.server.plugins.PluginInstallException: Guice provision errors:
1) Error injecting constructor, java.lang.IllegalArgumentException: Invalid wildcards +refs/heads/*
at com.googlesource.gerrit.plugins.replication.ReplicationQueue.<init>(ReplicationQueue.java:99)
at com.googlesource.gerrit.plugins.replication.ReplicationModule.configure(ReplicationModule.java:34)
while locating com.googlesource.gerrit.plugins.replication.ReplicationQueue
for parameter 2 at com.googlesource.gerrit.plugins.replication.OnStartStop.<init>(OnStartStop.java:36)
at com.googlesource.gerrit.plugins.replication.ReplicationModule.configure(ReplicationModule.java:45)
while locating com.googlesource.gerrit.plugins.replication.OnStartStop
while locating com.google.gerrit.extensions.events.LifecycleListener annotated with @com.google.inject.internal.UniqueAnnotations$Internal(value=111)
1 error
at com.google.gerrit.server.plugins.PluginLoader.runPlugin(PluginLoader.java:412)
at com.google.gerrit.server.plugins.PluginLoader.installPluginFromStream(PluginLoader.java:167)
at com.google.gerrit.sshd.commands.PluginInstallCommand.run(PluginInstallCommand.java:92)
at com.google.gerrit.sshd.SshCommand$1.run(SshCommand.java:35)
at com.google.gerrit.sshd.BaseCommand$TaskThunk.run(BaseCommand.java:442)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292)
at com.google.gerrit.server.git.WorkQueue$Task.run(WorkQueue.java:360)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
Caused by: com.google.inject.ProvisionException: Guice provision errors:
1) Error injecting constructor, java.lang.IllegalArgumentException: Invalid wildcards +refs/heads/*
at com.googlesource.gerrit.plugins.replication.ReplicationQueue.<init>(ReplicationQueue.java:99)
at com.googlesource.gerrit.plugins.replication.ReplicationModule.configure(ReplicationModule.java:34)
while locating com.googlesource.gerrit.plugins.replication.ReplicationQueue
for parameter 2 at com.googlesource.gerrit.plugins.replication.OnStartStop.<init>(OnStartStop.java:36)
at com.googlesource.gerrit.plugins.replication.ReplicationModule.configure(ReplicationModule.java:45)
while locating com.googlesource.gerrit.plugins.replication.OnStartStop
while locating com.google.gerrit.extensions.events.LifecycleListener annotated with @com.google.inject.internal.UniqueAnnotations$Internal(value=111)
1 error
at com.google.inject.internal.InjectorImpl$3.get(InjectorImpl.java:1014)
at com.google.gerrit.lifecycle.LifecycleManager.start(LifecycleManager.java:72)
at com.google.gerrit.server.plugins.JarPlugin.startPlugin(JarPlugin.java:181)
at com.google.gerrit.server.plugins.JarPlugin.start(JarPlugin.java:123)
at com.google.gerrit.server.plugins.PluginLoader.runPlugin(PluginLoader.java:395)
... 12 more
Caused by: java.lang.IllegalArgumentException: Invalid wildcards +refs/heads/*
at org.eclipse.jgit.transport.RefSpec.<init>(RefSpec.java:152)
at org.eclipse.jgit.transport.RemoteConfig.<init>(RemoteConfig.java:191)
at com.googlesource.gerrit.plugins.replication.ReplicationQueue.allRemotes(ReplicationQueue.java:239)
at com.googlesource.gerrit.plugins.replication.ReplicationQueue.allDestinations(ReplicationQueue.java:196)
at com.googlesource.gerrit.plugins.replication.ReplicationQueue.<init>(ReplicationQueue.java:107)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
at com.google.inject.internal.DefaultConstructionProxyFactory$2.newInstance(DefaultConstructionProxyFactory.java:86)
at com.google.inject.internal.ConstructorInjector.provision(ConstructorInjector.java:108)
at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:88)
at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:269)
at com.google.inject.internal.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:46)
at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1058)
at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40)
at com.google.inject.Scopes$1$1.get(Scopes.java:65)
at com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:41)
at com.google.inject.internal.SingleParameterInjector.inject(SingleParameterInjector.java:38)
at com.google.inject.internal.SingleParameterInjector.getAll(SingleParameterInjector.java:62)
at com.google.inject.internal.ConstructorInjector.provision(ConstructorInjector.java:107)
at com.google.inject.internal.ConstructorInjector.construct(ConstructorInjector.java:88)
at com.google.inject.internal.ConstructorBindingImpl$Factory.get(ConstructorBindingImpl.java:269)
at com.google.inject.internal.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:46)
at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1058)
at com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40)
at com.google.inject.Scopes$1$1.get(Scopes.java:65)
at com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:41)
at com.google.inject.internal.FactoryProxy.get(FactoryProxy.java:56)
at com.google.inject.internal.InjectorImpl$3$1.call(InjectorImpl.java:1005)
at com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1051)
at com.google.inject.internal.InjectorImpl$3.get(InjectorImpl.java:1001)
... 16 more
fatal: plugin failed to install
If I had to guess you’re probably trying to build replication plugin v2.8.1, stable-2.8.1 on top of gerrit master.
The ref constants where moved from GitRepositoryManager.java to
gerrit-reviewdb/src/main/java/com/google/gerrit/reviewdb/client/RefNames.java in
https://gerrit-review.googlesource.com/#/c/52909
/Sven
--
[-] PARSING BUILD FILES...FINISHED 1.9s
[+] BUILDING...32.6s
|=> //plugins/replication:replication__plugin__compile... 0.5s (running javac[0.5s])
Log:
warning: [options] bootstrap class path not set in conjunction with -source 1.6
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:17: error: package com.google.common.base does not exist
import com.google.common.base.Objects;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:18: error: package com.google.common.base does not exist
import com.google.common.base.Throwables;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:19: error: package com.google.common.collect does not exist
import com.google.common.collect.ImmutableSet;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:20: error: package com.google.common.collect does not exist
import com.google.common.collect.Lists;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:21: error: package com.google.gerrit.common.data does not exist
import com.google.gerrit.common.data.AccessSection;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:22: error: package com.google.gerrit.common.data does not exist
import com.google.gerrit.common.data.GroupReference;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:23: error: package com.google.gerrit.reviewdb.client does not exist
import com.google.gerrit.reviewdb.client.AccountGroup;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:24: error: package com.google.gerrit.reviewdb.client does not exist
import com.google.gerrit.reviewdb.client.Project;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:25: error: package com.google.gerrit.reviewdb.server does not exist
import com.google.gerrit.reviewdb.server.ReviewDb;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:40: error: package com.google.gwtorm.server does not exist
import com.google.gwtorm.server.SchemaFactory;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:41: error: package com.google.inject does not exist
import com.google.inject.Injector;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:42: error: package com.google.inject does not exist
import com.google.inject.Provider;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:43: error: package com.google.inject does not exist
import com.google.inject.Provides;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:44: error: package com.google.inject.assistedinject does not exist
import com.google.inject.assistedinject.FactoryModuleBuilder;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:45: error: package com.google.inject.servlet does not exist
import com.google.inject.servlet.RequestScoped;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:48: error: package org.eclipse.jgit.lib does not exist
import org.eclipse.jgit.lib.Config;
^
git checkout v2.8.1
git submodule init
git submodule update
buck build plugins/replication
buck build plugins/replication
[-] PARSING BUILD FILES...FINISHED 2.0s
[+] BUILDING...36.6s
|=> //plugins/replication:replication__plugin__compile... 0.2s (running javac[0.2s])
Log:
warning: [options] bootstrap class path not set in conjunction with -source 1.6
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:17: error: package com.google.common.base does not exist
import com.google.common.base.Objects;
^
/root/gerrit/plugins/replication/src/main/java/com/googlesource/gerrit/plugins/replication/Destination.java:18: error: package com.google.common.base does not exist
import com.google.common.base.Throwables;
^
You received this message because you are subscribed to a topic in the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/repo-discuss/NEgxb7CTbf0/unsubscribe.
To unsubscribe from this group and all its topics, send an email to repo-discuss...@googlegroups.com.