Lightweight tags are not visible in shortlog

[Dmitry P]

Is it possible to make them visible here? Also, how gitweb or Gerrit add them next to commit names? Since it was never explained in gitweb, nor in Gerrit

[Dmitry P]

Just clarified with the user, all those tags are lightweight. The question is why some are visible and some are not.

[Martin Fick]

I'll be honest, your question confuses me, perhaps you are not familiar with what a tag is? A tag points to a commit, so if the commit is being displayed in gitweb, and a tag points to it, then the tag will be displayed on that commit. Are you expecting something different? What tags are not visible that you think should be visible, and why do you think they should be visible?

-Martin

[Dmitry P]

I do, but the logic behind displaying various metadata in shortlog was never clear for me. So when you say if the commit is being displayed in gitweb, and a tag points to it, then the tag will be displayed on that commit, does it mean the commit wasn't tagged? Since it's not me who pushes in the repo and thus I don't know users' workflow. 

[Martin Fick]

On Thu, Jul 11, 2024 at 2:05 PM Dmitry P <dmitry...@gmail.com> wrote:

So when you say if the commit is being displayed in gitweb, and a tag points to it, then the tag will be displayed on that commit, does it mean the commit wasn't tagged?

I don't understand the confusion, is there a typo, or some words missing in this question?

 

-Martin

[Dmitry P]

No. I didn't know how to ask the question properly as I didn't find anything similar, even in gitweb documentation. I wanted to clarify if those boxes next to commits are something configurable in Gerrit, or if it's metadata that is being read from commits. 

[Martin Fick]

On Thu, Jul 11, 2024 at 2:20 PM Dmitry P <dmitry...@gmail.com> wrote:

No. I didn't know how to ask the question properly as I didn't find anything similar, even in gitweb documentation. I wanted to clarify if those boxes next to commits are something configurable in Gerrit, or if it's metadata that is being read from commits. 

Gotcha. Tags are a git feature, nothing specific to Gerrit or gitweb. https://git-scm.com/book/en/v2/Git-Basics-Tagging

Gitweb understands git tags and displays them when they are associated with a commit so as to be helpful to people browsing the source or logs in gitweb. I am not sure if there is a configuration to disable that in gitweb or Gerrit, but it happens by default. It is indeed metadata, but it is not from the commits, it is the other way around, it is from the tags (the tags are the metadata). Gitweb has to read all the tags to see if any of them happen to point to the commits being displayed. Commits are immutable, and tags are applied after commits are created, so commits "know" nothing of the tags pointing to them,

 -Martin

[Dmitry P]

Much appreciated, now I have to explain it for less technical users :)

[Dmitry P]

If the same happens in gitiles, does it mean user not properly tagging them, i.e. not with git but an app which uses git? The problem is they use the same process, yet in some repos it's ok and not in some, I don't know why except they don't use git for tagging

[Martin Fick]

Likely if you have an issue, it has to do with how you are getting the tags "to" the Gerrit repo. How are they pushing the tags to Gerrit? Also, do they have the appropriate ACLs to push tags to the repos which may not be working? https://gerrit-review.googlesource.com/Documentation/access-control.html#category_create

-Martin

[Dmitry P]

ACL seems to be fine, they have Create reference for refs/tags. This is how tags get shipped to the problematic repo:

21:37:33 [INFO] COMMAND: [ 21:37:33 k8s-utils git-tag -t 1.67.0-1 21:37:33 ]. [Pipeline] sh 21:37:34 + k8s-utils git-tag -t 1.67.0-1 [Pipeline] echo 21:37:52 [INFO] Result: INFO: BEGIN:ENTRYPOINT:git-tag 21:37:52 INFO: GERRIT REFSPEC: None 21:37:52 INFO: GERRIT EVENT: None 21:37:52 INFO: GERRIT MERGE EVENT: comment-added 21:37:52 INFO: Synchronize repo cloned to make submit manual change 21:37:52 INFO: INIT STEP GIT API: TAGGING 21:37:52 INFO: tag was updated successfully 21:37:52 INFO: FINISH STEP GIT API: TAGGING 21:37:52 INFO: END:ENTRYPOINT:git-tag

Am I good to say that's k8s-utils is the cause here since it's not git (even if it uses one)? 

[Martin Fick]

On Thu, Jul 18, 2024 at 4:30 AM Dmitry P <dmitry...@gmail.com> wrote:

ACL seems to be fine, they have Create reference for refs/tags. This is how tags get shipped to the problematic repo:

21:37:33 [INFO] COMMAND: [ 21:37:33 k8s-utils git-tag -t 1.67.0-1 21:37:33 ]. [Pipeline] sh 21:37:34 + k8s-utils git-tag -t 1.67.0-1 [Pipeline] echo 21:37:52 [INFO] Result: INFO: BEGIN:ENTRYPOINT:git-tag 21:37:52 INFO: GERRIT REFSPEC: None 21:37:52 INFO: GERRIT EVENT: None 21:37:52 INFO: GERRIT MERGE EVENT: comment-added 21:37:52 INFO: Synchronize repo cloned to make submit manual change 21:37:52 INFO: INIT STEP GIT API: TAGGING 21:37:52 INFO: tag was updated successfully 21:37:52 INFO: FINISH STEP GIT API: TAGGING 21:37:52 INFO: END:ENTRYPOINT:git-tag

This is really hard to read, I don't see any commands pushing the tag to Gerrit?

 

Am I good to say that's k8s-utils is the cause here since it's not git (even if it uses one)? 

I don't see any evidence of that yet, but I don't know what k8s-utils is? I suspect it just runs whatever git commands you tell it to run inside k8s, and git-tag will only create tags in the local repo, it won't push them to the server,

-Martin