ai-code-review issue

[卞姗姗]

hi all,

"I was able to use ai-code-review normally at the beginning of October. However, after downloading and compiling the latest version of the master branch and installing the plugin, I encountered the following error. Could this be caused by the recent changes, or is it an issue with my usage?"

Looking forward to your reply.

[Michael Nazzareno Trimarchi]

Hi

I found out that it was forked. We are working on a new release of our repo. Make sense to work only on one source code?

Michael

 

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/repo-discuss/3a531416-50c7-4045-abd3-89375e964833n%40googlegroups.com.

--

Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
mic...@amarulasolutions.com
__________________________________

Amarula Solutions BV

Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
in...@amarulasolutions.com
www.amarulasolutions.com

[卞姗姗]

My download link is git clone https://gerrit.googlesource.com/plugins/ai-code-review -b master. Is this the same version you are maintaining?

[Michael Nazzareno Trimarchi]

Hi

https://gerrithub.io/q/project:amarula/chatgpt-code-review-gerrit-plugin

Michael

To view this discussion visit https://groups.google.com/d/msgid/repo-discuss/fb3df8ab-7935-4e86-a451-276a0dabcae0n%40googlegroups.com.

[卞姗姗]

my gerrit version is 3.10

"Could you please clarify the relationship between these two addresses? I noticed that address 1  https://gerrit.googlesource.com/plugins/ai-code-review  master branch  has been continuously updated based on address  2 https://gerrithub.io/q/project:amarula/chatgpt-code-review-gerrit-plugin  . If there is an issue with address 1, shouldn't it be discussed and fixed together with address 1?"

[Michael Nazzareno Trimarchi]

Hi

On Tue, Nov 5, 2024 at 10:35 AM 卞姗姗 <bianshan...@gmail.com> wrote:

my gerrit version is 3.10

"Could you please clarify the relationship between these two addresses? I noticed that address 1  https://gerrit.googlesource.com/plugins/ai-code-review  master branch  has been continuously updated based on address  2 https://gerrithub.io/q/project:amarula/chatgpt-code-review-gerrit-plugin  . If there is an issue with address 1, shouldn't it be discussed and fixed together with address 1?"

The best option should be to work on one of them. We are testing it on 3.10 right now

Michael

 

To view this discussion visit https://groups.google.com/d/msgid/repo-discuss/be13e7e2-ed1c-4f5b-a5cf-d6b66b948fe0n%40googlegroups.com.

[Sven Selberg]

On Tuesday, November 5, 2024 at 10:38:05 AM UTC+1 Michael Nazzareno Trimarchi wrote:

Hi

On Tue, Nov 5, 2024 at 10:35 AM 卞姗姗 <bianshan...@gmail.com> wrote:

my gerrit version is 3.10

"Could you please clarify the relationship between these two addresses? I noticed that address 1  https://gerrit.googlesource.com/plugins/ai-code-review  master branch  has been continuously updated based on address  2 https://gerrithub.io/q/project:amarula/chatgpt-code-review-gerrit-plugin  . If there is an issue with address 1, shouldn't it be discussed and fixed together with address 1?"

The ai-code-review fork is based on chatgpt-code-review-plugin.

ai-code-review is meant to be a more general AI code-review plugin where chatgpt is one of the cases (also support a plethora of "internal" LLMs)

To the best of my knowledge:
Work was started on the hackathon this October
FWICT work to adapt the chatGPT plugin to a more general plugin is mostly done by Trevor Getty.
I also think the idea/hope is that all work will be done in ai-code-review plugin in the future.

The best option should be to work on one of them. We are testing it on 3.10 right now

Michael

 

在2024年11月5日星期二 UTC+8 17:11:36<Michael Nazzareno Trimarchi> 写道：

Hi

https://gerrithub.io/q/project:amarula/chatgpt-code-review-gerrit-plugin

Michael

On Tue, Nov 5, 2024 at 9:55 AM 卞姗姗 <bianshan...@gmail.com> wrote:

My download link is git clone https://gerrit.googlesource.com/plugins/ai-code-review -b master. Is this the same version you are maintaining?

在2024年11月5日星期二 UTC+8 16:35:12<Michael Nazzareno Trimarchi> 写道：

Hi

On Tue, Nov 5, 2024 at 8:20 AM 卞姗姗 <bianshan...@gmail.com> wrote:

hi all,

"I was able to use ai-code-review normally at the beginning of October. However, after downloading and compiling the latest version of the master branch and installing the plugin, I encountered the following error. Could this be caused by the recent changes, or is it an issue with my usage?"

At the beginning of 
 

[卞姗姗]

https://gerrithub.io/q/project:amarula/chatgpt-code-review-gerrit-plugin maybe works ok on 3.10, as i used same commit before.

[卞姗姗]

"Thank you for your response. The ai-code-review does not work on Gerrit 3.10, and the error is described at the top of my post. Could you please let the relevant person assist with fixing this?"

[Sven Selberg]

On Tuesday, November 5, 2024 at 12:04:41 PM UTC+1 卞姗姗 wrote:

"Thank you for your response. The ai-code-review does not work on Gerrit 3.10, and the error is described at the top of my post. Could you please let the relevant person assist with fixing this?"

Master is a floating reference, what is the exact version of ai-code-review you were using?

[Michael Nazzareno Trimarchi]

Hi Sven

On Tue, Nov 5, 2024 at 11:53 AM Sven Selberg <sven.s...@axis.com> wrote:
>
>
>
> On Tuesday, November 5, 2024 at 10:38:05 AM UTC+1 Michael Nazzareno Trimarchi wrote:
>
> Hi
>
> On Tue, Nov 5, 2024 at 10:35 AM 卞姗姗 <bianshan...@gmail.com> wrote:
>
> my gerrit version is 3.10
>
> "Could you please clarify the relationship between these two addresses? I noticed that address 1 https://gerrit.googlesource.com/plugins/ai-code-review master branch has been continuously updated based on address 2 https://gerrithub.io/q/project:amarula/chatgpt-code-review-gerrit-plugin . If there is an issue with address 1, shouldn't it be discussed and fixed together with address 1?"
>
>
>
> The ai-code-review fork is based on chatgpt-code-review-plugin.
> ai-code-review is meant to be a more general AI code-review plugin where chatgpt is one of the cases (also support a plethora of "internal" LLMs)
>
> To the best of my knowledge:
> Work was started on the hackathon this October
> FWICT work to adapt the chatGPT plugin to a more general plugin is mostly done by Trevor Getty.
> I also think the idea/hope is that all work will be done in ai-code-review plugin in the future.
>
> The best option should be to work on one of them. We are testing it on 3.10 right now
>

The best should be to have a workshop/call to discuss together

Michael

> Michael
>
>
> 在2024年11月5日星期二 UTC+8 17:11:36<Michael Nazzareno Trimarchi> 写道：
>
> Hi
>
> https://gerrithub.io/q/project:amarula/chatgpt-code-review-gerrit-plugin
>
> Michael
>
> On Tue, Nov 5, 2024 at 9:55 AM 卞姗姗 <bianshan...@gmail.com> wrote:
>
> My download link is git clone https://gerrit.googlesource.com/plugins/ai-code-review -b master. Is this the same version you are maintaining?
>
>
>
> 在2024年11月5日星期二 UTC+8 16:35:12<Michael Nazzareno Trimarchi> 写道：
>
> Hi
>
> On Tue, Nov 5, 2024 at 8:20 AM 卞姗姗 <bianshan...@gmail.com> wrote:
>
> hi all,
>
> "I was able to use ai-code-review normally at the beginning of October. However, after downloading and compiling the latest version of the master branch and installing the plugin, I encountered the following error. Could this be caused by the recent changes, or is it an issue with my usage?"
>
>

> To view this discussion visit https://groups.google.com/d/msgid/repo-discuss/4088b5bf-952c-43cf-b079-69ad6113ee45n%40googlegroups.com.

[卞姗姗]

i am working on commit a7cb6766385de0fbe8a6cf38d6e9c69db9594a7c

[Trevor Getty]

Hi, 

can I please check a few things to help assist here.

What version of the code did you download ( can you give the commit id, and for what JDK did you build it on? ).

What version of gerrit are you currently using, and again which JDK?

I can then send you the correct version links to be downloaded for your gerrit install.

It might also be worth while mentioning if you have any other non core plugins in play which may interact with the bindings. 

thanks. 

[Trevor Getty]

As seen above, it would appear that you have taken "master" which is a moving target and will be JDK21 only moving forward.

As kindly pointed out by sven, the ai-code-review plugin is a more general solution targeted at other private LLM solutions and not just chatGPT, namely OLLAMA initially. 

If you are wishing to have or more stable version, the JDK17 variant in stable-3.9 branch works on 3.7, 3.9 and 3.10 gerrit versions - this review is for stable-3.9 on JDK17, which will work on 3.10:  

https://gerrit-review.googlesource.com/c/plugins/ai-code-review/+/441442

Master will be tested against stable-3.11 ( it uses the stable-3.11 gerrit plugin API asset ) and will then become the new stable-3.11 branch before moving forward, so I wouldn't check out master as a stable version in your fork unless you wish to take new features and test them. 

Thanks, 

trevor

[Michael Nazzareno Trimarchi]

Hi Trevor

On Wed, Nov 6, 2024 at 4:54 PM 'Trevor Getty' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

As seen above, it would appear that you have taken "master" which is a moving target and will be JDK21 only moving forward.

As kindly pointed out by sven, the ai-code-review plugin is a more general solution targeted at other private LLM solutions and not just chatGPT, namely OLLAMA initially. 

If you are wishing to have or more stable version, the JDK17 variant in stable-3.9 branch works on 3.7, 3.9 and 3.10 gerrit versions - this review is for stable-3.9 on JDK17, which will work on 3.10:  

https://gerrit-review.googlesource.com/c/plugins/ai-code-review/+/441442

Can you give me feedback about my proposal to have some kind of roadmap or unique project tree?

Michael

 

Master will be tested against stable-3.11 ( it uses the stable-3.11 gerrit plugin API asset ) and will then become the new stable-3.11 branch before moving forward, so I wouldn't check out master as a stable version in your fork unless you wish to take new features and test them. 

Thanks, 

trevor

On Wednesday, November 6, 2024 at 3:45:53 PM UTC Trevor Getty wrote:

Hi, 

can I please check a few things to help assist here.

What version of the code did you download ( can you give the commit id, and for what JDK did you build it on? ).

What version of gerrit are you currently using, and again which JDK?

I can then send you the correct version links to be downloaded for your gerrit install.

It might also be worth while mentioning if you have any other non core plugins in play which may interact with the bindings. 

thanks. 

On Tuesday, November 5, 2024 at 7:20:05 AM UTC 卞姗姗 wrote:

hi all,

"I was able to use ai-code-review normally at the beginning of October. However, after downloading and compiling the latest version of the master branch and installing the plugin, I encountered the following error. Could this be caused by the recent changes, or is it an issue with my usage?"

Looking forward to your reply.

THIS MESSAGE AND ANY ATTACHMENTS ARE CONFIDENTIAL, PROPRIETARY AND MAY BE PRIVILEGED

If this message was misdirected, Cirata Ltd. and its subsidiaries, ("Cirata") does not waive any confidentiality or privilege. If you are not the intended recipient, please notify us immediately and destroy the message without disclosing its contents to anyone. Any distribution, use or copying of this email or the information it contains by other than an intended recipient is unauthorized. The views and opinions expressed in this email message are the author's own and may not reflect the views and opinions of Cirata, unless the author is authorized by Cirata to express such views or opinions on its behalf. All email sent to or from this address is subject to electronic storage and review by Cirata. Although Cirata operates anti-virus programs, it does not accept responsibility for any damage whatsoever caused by viruses being passed.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

To view this discussion visit https://groups.google.com/d/msgid/repo-discuss/95dc8dd5-4dec-4f11-81a9-e0a73013dbe6n%40googlegroups.com.

[Trevor Getty]

Hi michael, 

So here is a brief history why the projects diverged.

1) We wanted to make a generic AI service code review plugin, as such the chatGPT plugin from the address 
 https://gerrithub.io/q/project:amarula/chatgpt-code-review-gerrit-plugin was only used as a starting point and to make that clear we brought it over with history and placed it in an archive branch.

To be honest even this project was a fork / copy of the original plugin here: 

https://github.com/xielong/chatgpt-code-review-gerrit-plugin

From that point where it has been forked to https://gerrit.googlesource.com/plugins/ai-code-review the project has diverged to allow the project to be non chatGPT specific, and support more than just one ai service.

2) The project was at that time forked, in 2 locations, and both where chatGPT specific.

As such we decided to make it generic (to support more ai services) , while also making it a gerrit community project. This made sure it wasn't in any specific organisations GitHub repository.  

The plugin has now been brought on board as a community project so that anyone can contribute, and it is not with a specific companies organisation, which limits the Gerrit community contributions.   The contribution licence, and copyright headers have been updated for open source contribution. 

It would be more beneficial if the progress moved over to the new community project, that way we can make all changes in a single location moving forward.  But I can understand that if Amarula still want to have their own fork for their own specific reasons, especially if they are only interested in chatGPT. 

Issue Tracking / Project Planning

We have created a new issue tracker for issues, which can cover new work item Story, Epic, Tasks, Feature requests and Bugs. 

Feel free to contribute to this new issue tracker: 

https://issues.gerritcodereview.com/issues?q=componentid:1684172&pli=1

The discord channel exists to discuss ai code review in general across both plugins, so please jump on there if you wish to have a call, or pitch in on the general discussions in this area.

https://discord.com/channels/775374026587373568/1232615029761769473

Please let me know if this answers your questions, thanks. 

Many thanks

trevor. 

[Michael Nazzareno Trimarchi]

Hi

Let me reply inline

On Thu, Nov 14, 2024 at 7:51 PM 'Trevor Getty' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

Hi michael, 

So here is a brief history why the projects diverged.

1) We wanted to make a generic AI service code review plugin, as such the chatGPT plugin from the address 
 https://gerrithub.io/q/project:amarula/chatgpt-code-review-gerrit-plugin was only used as a starting point and to make that clear we brought it over with history and placed it in an archive branch.

That was in our plan too. So rename it, it's ok even with us. Our idea was to explore one AI deeply before create layer to be compatible with other one. I think that an email to disccuss with us was really nice. Am I miss it? In the meantime we have development more features and

could be we are discussing internally how move on on this.

 

To be honest even this project was a fork / copy of the original plugin here: 

https://github.com/xielong/chatgpt-code-review-gerrit-plugin

We almost rewrite everything so could you miss some patches.  It's not about the fork, we have sent an email to invite to collaborate on it.

Is this the opensource behavior?

From that point where it has been forked to https://gerrit.googlesource.com/plugins/ai-code-review the project has diverged to allow the project to be non chatGPT specific, and support more than just one ai service.

2) The project was at that time forked, in 2 locations, and both where chatGPT specific.

As such we decided to make it generic (to support more ai services) , while also making it a gerrit community project. This made sure it wasn't in any specific organisations GitHub repository.  

The plugin has now been brought on board as a community project so that anyone can contribute, and it is not with a specific companies organisation, which limits the Gerrit community contributions.   The contribution licence, and copyright headers have been updated for open source contribution. 

It would be more beneficial if the progress moved over to the new community project, that way we can make all changes in a single location moving forward.  But I can understand that if Amarula still want to have their own fork for their own specific reasons, especially if they are only interested in chatGPT. 

Issue Tracking / Project Planning

Let's forget a bit about history.  I think spending time in two opensource version make no sense. We should combine it in one. Any

problem with that? 

Michael

THIS MESSAGE AND ANY ATTACHMENTS ARE CONFIDENTIAL, PROPRIETARY AND MAY BE PRIVILEGED

If this message was misdirected, Cirata Ltd. and its subsidiaries, ("Cirata") does not waive any confidentiality or privilege. If you are not the intended recipient, please notify us immediately and destroy the message without disclosing its contents to anyone. Any distribution, use or copying of this email or the information it contains by other than an intended recipient is unauthorized. The views and opinions expressed in this email message are the author's own and may not reflect the views and opinions of Cirata, unless the author is authorized by Cirata to express such views or opinions on its behalf. All email sent to or from this address is subject to electronic storage and review by Cirata. Although Cirata operates anti-virus programs, it does not accept responsibility for any damage whatsoever caused by viruses being passed.

--

--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

To view this discussion visit https://groups.google.com/d/msgid/repo-discuss/d54193a7-ff9b-4445-94ae-32fc9b3f52adn%40googlegroups.com.

[Daniele Sassoli]

Hi Trevor, Michael,

I appreciate you wanting to discuss the project's future, but the original intention of this thread has nothing to do with what is now being discussed.

Let's, please move the conversation to Discord. I'll start a thread and tag you both.

Thanks,
Dani

[Michael Nazzareno Trimarchi]

Hi all

We start back the development of our gerrit version, we think that we can go much faster. In the last few months I don't see

anything new and we have already discussed in Amarula Solutions our roadmap. Thank you Daniele for the email you sent

but we were too busy on a new AI product and now we would like to deliver the next release. The development model will

be opensource but if someone needs some specific integration or feature can contact us for business support

Michael

To view this discussion visit https://groups.google.com/d/msgid/repo-discuss/8e33e3bb-9e3a-4f1d-966f-5218e0f45805n%40googlegroups.com.