Change screen scrolling jankiness with Chrome and Gerrit 2.13.5
629 views
Skip to first unread message
Darragh Bailey
May 9, 2017, 8:54:39 AM5/9/17
to Repo and Gerrit Discussion
Hi,
One of our developers spotted a problem when using Chrome/Chromium and scrolling a patch that has a number of comments where the page would jump around and not scroll consistently. For this particular change it does make reviewing and responding to comments much more difficult than it should be.
I believe it all comes back to changes implemented by the browsers to support asynchronous-panning to try and provide smoother displaying of webpages, but appears in certain cases to have issues with certain behaviour being attached to scroll events.
https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Scroll-linked_effects
Using Firefox with the developer console I can see the following message pop up:
"This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features!"
And when looking at some reviews on the gerrit website I can find some that appear to trigger the same jankiness, but only very slightly, suspect not enough review comments appearing on the same file to show it:
https://gerrit-review.googlesource.com/?polygerrit=0#/c/105472/3..4/gerrit-server/src/main/java/com/google/gerrit/server/api/changes/ChangeApiImpl.java
I haven't tracked down what exactly causes it, and hoping there might be a simple workaround until we're ready to switch to the Polygerrit UI as it doesn't appear to be occurring there, though I could do with finding a change with more comments on a single file to be sure.
Have tried disabling smooth scrolling in the browser to see if that helped, and it had no effect.
Any thoughts? Suggestions? Anything that can be modified in the css/js that might help alleviate or even just narrow down the culprit.
--
Darragh
One of our developers spotted a problem when using Chrome/Chromium and scrolling a patch that has a number of comments where the page would jump around and not scroll consistently. For this particular change it does make reviewing and responding to comments much more difficult than it should be.
I believe it all comes back to changes implemented by the browsers to support asynchronous-panning to try and provide smoother displaying of webpages, but appears in certain cases to have issues with certain behaviour being attached to scroll events.
https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Scroll-linked_effects
Using Firefox with the developer console I can see the following message pop up:
"This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features!"
And when looking at some reviews on the gerrit website I can find some that appear to trigger the same jankiness, but only very slightly, suspect not enough review comments appearing on the same file to show it:
https://gerrit-review.googlesource.com/?polygerrit=0#/c/105472/3..4/gerrit-server/src/main/java/com/google/gerrit/server/api/changes/ChangeApiImpl.java
I haven't tracked down what exactly causes it, and hoping there might be a simple workaround until we're ready to switch to the Polygerrit UI as it doesn't appear to be occurring there, though I could do with finding a change with more comments on a single file to be sure.
Have tried disabling smooth scrolling in the browser to see if that helped, and it had no effect.
Any thoughts? Suggestions? Anything that can be modified in the css/js that might help alleviate or even just narrow down the culprit.
--
Darragh
Darragh Bailey
May 15, 2017, 7:12:19 AM5/15/17
to Repo and Gerrit Discussion
On Tuesday, May 9, 2017 at 1:54:39 PM UTC+1, Darragh Bailey wrote:
Hi,
One of our developers spotted a problem when using Chrome/Chromium and scrolling a patch that has a number of comments where the page would jump around and not scroll consistently. For this particular change it does make reviewing and responding to comments much more difficult than it should be.
Has anyone else seen this and can confirm it's happening for them using the older GWT based interface?
--
Darragh
Matthias Sohn
May 15, 2017, 7:30:51 AM5/15/17
to Darragh Bailey, Repo and Gerrit Discussion
I have seen this a few times using the gwt UI
-Matthias
Luca Milanesio
May 15, 2017, 7:31:18 AM5/15/17
to Darragh Bailey, Repo and Gerrit Discussion
Yeah, it happens when the code changes are huge.
Luca.
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Darragh Bailey
May 15, 2017, 5:37:50 PM5/15/17
to Luca Milanesio, Repo and Gerrit Discussion
Thanks, for the confirmation.
The changes weren't particular big, it appears to be the number of comments ( from about 12 upwards it's very common) and side-by-side view appears to trigger it.
Switching to unified reduces the occurrence, but it's starting to seem like I'll have to wait a bit to upgrade to polygerrit for it to be solved.
Darragh Bailey
"Nothing is foolproof to a sufficiently talented fool" - unknown
"Nothing is foolproof to a sufficiently talented fool" - unknown
On 15 May 2017 12:31, "Luca Milanesio" <luca.mi...@gmail.com> wrote:
Yeah, it happens when the code changes are huge.Luca.
On 15 May 2017, at 12:12, Darragh Bailey <daragh...@gmail.com> wrote:
On Tuesday, May 9, 2017 at 1:54:39 PM UTC+1, Darragh Bailey wrote:Hi,
One of our developers spotted a problem when using Chrome/Chromium and scrolling a patch that has a number of comments where the page would jump around and not scroll consistently. For this particular change it does make reviewing and responding to comments much more difficult than it should be.
Has anyone else seen this and can confirm it's happening for them using the older GWT based interface?
--
Darragh--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
Sven Selberg
May 16, 2017, 4:51:44 AM5/16/17
to Repo and Gerrit Discussion, luca.mi...@gmail.com
I believe setting Render = slow in diff preferences fixes this issue.
/Sven
On Monday, May 15, 2017 at 11:37:50 PM UTC+2, Darragh Bailey wrote:
Thanks, for the confirmation.The changes weren't particular big, it appears to be the number of comments ( from about 12 upwards it's very common) and side-by-side view appears to trigger it.Switching to unified reduces the occurrence, but it's starting to seem like I'll have to wait a bit to upgrade to polygerrit for it to be solved.Darragh Bailey
"Nothing is foolproof to a sufficiently talented fool" - unknown
On 15 May 2017 12:31, "Luca Milanesio" <luca.mi...@gmail.com> wrote:
Yeah, it happens when the code changes are huge.Luca.
On 15 May 2017, at 12:12, Darragh Bailey <daragh...@gmail.com> wrote:
On Tuesday, May 9, 2017 at 1:54:39 PM UTC+1, Darragh Bailey wrote:Hi,
One of our developers spotted a problem when using Chrome/Chromium and scrolling a patch that has a number of comments where the page would jump around and not scroll consistently. For this particular change it does make reviewing and responding to comments much more difficult than it should be.
Has anyone else seen this and can confirm it's happening for them using the older GWT based interface?
--
Darragh--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
Darragh Bailey
May 16, 2017, 5:56:34 AM5/16/17
to Sven Selberg, Repo and Gerrit Discussion, Luca Milanesio
On 16 May 2017 at 09:51, Sven Selberg <sven.s...@axis.com> wrote:
I believe setting Render = slow in diff preferences fixes this issue./Sven
That worked perfectly! Many thanks, it'll give us a little breathing room until ready to upgrade to 2.14.
--
Daniel Vasas
Jul 31, 2018, 5:48:44 AM7/31/18
to Repo and Gerrit Discussion
Indeed it works! Thanks a lot!
Reply all
Reply to author
Forward
0 new messages