Gerrit 2.9 - change in default email notification for `gerrit review`?

Chung Wu

unread,

Jul 24, 2014, 2:55:10 PM7/24/14

to Repo and Gerrit Discussion

Hi all,

We noticed after upgrading to Gerrit 2.9 that our Jenkins integration is no longer sending emails to reviewers. Specifically, we can see that Jenkins is commenting on Gerrit reviews on build start / success / failure, but those comments are no longer triggering emails to be sent.

From the Gerrit 2.9 release notes, it looks like a new --notify flag has been added to `gerrit review`, which controls what emails are sent when a comment is added. When --notify is not specified, no emails are sent.

Is this a change in the default email notification behavior for `gerrit review`? And if so, is it an intentional one? :-)

Thanks!

Chung

Edwin Kempin

unread,

Jul 24, 2014, 2:58:14 PM7/24/14

to Chung Wu, Repo and Gerrit Discussion

Yes.

And if so, is it an intentional one? :-)

Don't know if this was intentional. It was a surprise to me too.

Thanks!
Chung

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Matthias Sohn

unread,

Jul 24, 2014, 5:05:19 PM7/24/14

to Chung Wu, Repo and Gerrit Discussion

I found that this is only a problem for existing Jenkins installations with the Gerrit Trigger plugin already installed and configured. When installing the Gerrit trigger plugin into a newly installed Jenkins server the global Gerrit configuration in Jenkins defauls to use --notify=ALL for all review commands.