Gerrit CI bot should support picking up a comment with the word recheck to retest the change

72 views
Skip to first unread message

thomasmu...@yahoo.com

unread,
Mar 30, 2017, 11:25:26 AM3/30/17
to Repo and Gerrit Discussion
Hi, the gerrit bot should support a recheck command that will retest the change. With this it will allow us to recheck changes without needing a new change.

thomasmu...@yahoo.com

unread,
Mar 30, 2017, 11:25:49 AM3/30/17
to Repo and Gerrit Discussion, luca.mi...@gmail.com

Logan Hanks

unread,
Mar 30, 2017, 12:08:26 PM3/30/17
to thomasmu...@yahoo.com, Repo and Gerrit Discussion, luca.mi...@gmail.com
Consider also triggering off deletion of its Verified vote.

On Thu, Mar 30, 2017, 08:25 thomasmulhall410 via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:


On Thursday, March 30, 2017 at 4:25:26 PM UTC+1, thomasmu...@yahoo.com wrote:
Hi, the gerrit bot should support a recheck command that will retest the change. With this it will allow us to recheck changes without needing a new change.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Luca Milanesio

unread,
Mar 30, 2017, 5:44:55 PM3/30/17
to Logan Hanks, thomasmu...@yahoo.com, Repo and Gerrit Discussion
Yes, this is a good idea when scheduling an ad-hoc build.

It should:
a) Reset existing vote
b) Re-run the build
c) Assign the new vote

Luca.

thomasmu...@yahoo.com

unread,
Mar 30, 2017, 5:54:04 PM3/30/17
to Repo and Gerrit Discussion, lo...@google.com, thomasmu...@yahoo.com
+1

Luca Milanesio

unread,
Mar 30, 2017, 6:12:18 PM3/30/17
to thomasmu...@yahoo.com, Logan Hanks, Repo and Gerrit Discussion
Here is the link to the "Change builder job":

You would need to login using your GitHub credentials and then request permissions on the mailing list.
In the past the build button was enabled for everyone ... but there was a bit of abuse (bots?) and the CI was the overloaded.

I am open to suggestions on how to make it more accessible :-)
Ideally we would like to have  a button on the change screen that says "Build on CI" ... but I am aware that gerrit-review.googlesource.com doesn't support plugins.

Luca.

Shawn Pearce

unread,
Mar 30, 2017, 6:22:27 PM3/30/17
to Luca Milanesio, Paladox, Logan Hanks, Repo and Gerrit Discussion
On Thu, Mar 30, 2017 at 3:12 PM, Luca Milanesio <luca.mi...@gmail.com> wrote:
Here is the link to the "Change builder job":

You would need to login using your GitHub credentials and then request permissions on the mailing list.
In the past the build button was enabled for everyone ... but there was a bit of abuse (bots?) and the CI was the overloaded.

I am open to suggestions on how to make it more accessible :-)
Ideally we would like to have  a button on the change screen that says "Build on CI" ... but I am aware that gerrit-review.googlesource.com doesn't support plugins.

Well... not entirely true. We run a number of open source plugins in our build. We might be willing to run a plugin that does this, but yes its more work to get installed than on most Gerrit servers.

Luca Milanesio

unread,
Mar 30, 2017, 6:30:52 PM3/30/17
to Shawn Pearce, Paladox, Logan Hanks, Repo and Gerrit Discussion
Oh, that's great news then :-)
Let me work on that in the next few days then.

In theory, should be a UX-only plugin that triggers a remote REST API.
Jenkins allows to generate a OAuth token to be used for this purpose. Having a "service user" with that token would be good enough to protect the REST API from abuse.

Luca.
Reply all
Reply to author
Forward
0 new messages