Problem with oauth plugin after upgrade to 3.5.0.1

150 views
Skip to first unread message

johann...@gmail.com

unread,
Dec 8, 2021, 10:20:45 AM12/8/21
to Repo and Gerrit Discussion
Hi,

After upgrading gerrit to 3.5.0.1 and the oauth plugin to latest from gerrit-ci (plugin-oauth-bazel-master-stable-3.5) I get the below stack trace when trying to login.

Have anyone else got the oauth plugin to work properly with the latest gerrit release?

Regards
/Johannes

[2021-12-08T15:38:55.578+01:00] [main] INFO  com.google.gerrit.server.plugins.PluginLoader : Loaded plugin gerrit-oauth-provider, version 4aa7322db5
...
[2021-12-08T15:38:56.585+01:00] [main] INFO  com.google.gerrit.pgm.Daemon : Gerrit Code Review 3.5.0.1 ready
[2021-12-08T15:39:10.335+01:00] [HTTP-125] WARN  org.eclipse.jetty.server.HttpChannel : /oauth
java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/Versioned
        at java.base/java.lang.ClassLoader.defineClass1(Native Method)
        at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
        at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
        at java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:550)
        at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:458)
        at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:452)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:451)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:589)
        at java.base/java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:899)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
        at com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.<clinit>(OAuth2AccessTokenJsonExtractor.java:20)
        at com.github.scribejava.core.builder.api.DefaultApi20.getAccessTokenExtractor(DefaultApi20.java:41)
        at com.github.scribejava.core.oauth.OAuth20Service.sendAccessTokenRequestSync(OAuth20Service.java:53)
        at com.github.scribejava.core.oauth.OAuth20Service.getAccessToken(OAuth20Service.java:97)
        at com.github.scribejava.core.oauth.OAuth20Service.getAccessToken(OAuth20Service.java:92)
        at com.googlesource.gerrit.plugins.oauth.AzureActiveDirectoryService.getAccessToken(AzureActiveDirectoryService.java:203)
        at com.google.gerrit.httpd.auth.oauth.OAuthSession.login(OAuthSession.java:110)
        at com.google.gerrit.httpd.auth.oauth.OAuthWebFilter.doFilter(OAuthWebFilter.java:105)
        at com.google.gerrit.httpd.RequireSslFilter.doFilter(RequireSslFilter.java:72)
        at com.google.gerrit.httpd.RunAsFilter.doFilter(RunAsFilter.java:120)
        at com.google.gerrit.httpd.SetThreadNameFilter.doFilter(SetThreadNameFilter.java:62)
        at com.google.gerrit.httpd.AllRequestFilter$FilterProxy$1.doFilter(AllRequestFilter.java:139)
        at com.google.gerrit.httpd.AllowRenderInFrameFilter.doFilter(AllowRenderInFrameFilter.java:56)
        at com.google.gerrit.httpd.AllRequestFilter$FilterProxy$1.doFilter(AllRequestFilter.java:135)
        at com.google.gerrit.httpd.AllRequestFilter$FilterProxy.doFilter(AllRequestFilter.java:141)
        at com.google.gerrit.httpd.RequestCleanupFilter.doFilter(RequestCleanupFilter.java:60)
        at com.google.gerrit.httpd.RequestMetricsFilter.doFilter(RequestMetricsFilter.java:92)
        at com.google.gerrit.httpd.RequestContextFilter.doFilter(RequestContextFilter.java:64)
        at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:121)
        at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:133)
        at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
        at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
        at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:548)
        at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
        at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
        at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
        at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1435)
        at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
        at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:501)
        at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
        at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
        at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1350)
        at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
        at org.eclipse.jetty.server.handler.RequestLogHandler.handle(RequestLogHandler.java:54)
        at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
        at org.eclipse.jetty.server.Server.handle(Server.java:516)
        at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:388)
        at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:633)
        at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:380)
        at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273)
        at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
        at org.eclipse.jetty.io.ssl.SslConnection$DecryptedEndPoint.onFillable(SslConnection.java:540)
        at org.eclipse.jetty.io.ssl.SslConnection.onFillable(SslConnection.java:395)
        at org.eclipse.jetty.io.ssl.SslConnection$2.succeeded(SslConnection.java:161)
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
        at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129)
        at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:773)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:905)
        at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.ClassNotFoundException: com.fasterxml.jackson.core.Versioned
        at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:471)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:589)
        at java.base/java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:899)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
        ... 66 more
[2021-12-08T15:39:10.339+01:00] [HTTP-125] ERROR com.google.gerrit.pgm.http.jetty.HiddenErrorHandler : Error in GET /oauth?code=0.AQsA7zheFRgb...
java.lang.NoClassDefFoundError: com/fasterxml/jackson/core/Versioned
        at java.base/java.lang.ClassLoader.defineClass1(Native Method)
        at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017)
        at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)
        at java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:550)
        at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:458)
        at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:452)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:451)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:589)
        at java.base/java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:899)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
        at com.github.scribejava.core.extractors.OAuth2AccessTokenJsonExtractor.<clinit>(OAuth2AccessTokenJsonExtractor.java:20)
        at com.github.scribejava.core.builder.api.DefaultApi20.getAccessTokenExtractor(DefaultApi20.java:41)
        at com.github.scribejava.core.oauth.OAuth20Service.sendAccessTokenRequestSync(OAuth20Service.java:53)
        at com.github.scribejava.core.oauth.OAuth20Service.getAccessToken(OAuth20Service.java:97)
        at com.github.scribejava.core.oauth.OAuth20Service.getAccessToken(OAuth20Service.java:92)
        at com.googlesource.gerrit.plugins.oauth.AzureActiveDirectoryService.getAccessToken(AzureActiveDirectoryService.java:203)
        at com.google.gerrit.httpd.auth.oauth.OAuthSession.login(OAuthSession.java:110)
        at com.google.gerrit.httpd.auth.oauth.OAuthWebFilter.doFilter(OAuthWebFilter.java:105)
        at com.google.gerrit.httpd.RequireSslFilter.doFilter(RequireSslFilter.java:72)
        at com.google.gerrit.httpd.RunAsFilter.doFilter(RunAsFilter.java:120)
        at com.google.gerrit.httpd.SetThreadNameFilter.doFilter(SetThreadNameFilter.java:62)
        at com.google.gerrit.httpd.AllRequestFilter$FilterProxy$1.doFilter(AllRequestFilter.java:139)
        at com.google.gerrit.httpd.AllowRenderInFrameFilter.doFilter(AllowRenderInFrameFilter.java:56)
        at com.google.gerrit.httpd.AllRequestFilter$FilterProxy$1.doFilter(AllRequestFilter.java:135)
        at com.google.gerrit.httpd.AllRequestFilter$FilterProxy.doFilter(AllRequestFilter.java:141)
        at com.google.gerrit.httpd.RequestCleanupFilter.doFilter(RequestCleanupFilter.java:60)
        at com.google.gerrit.httpd.RequestMetricsFilter.doFilter(RequestMetricsFilter.java:92)
        at com.google.gerrit.httpd.RequestContextFilter.doFilter(RequestContextFilter.java:64)
        at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:121)
        at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:133)
        at org.eclipse.jetty.servlet.FilterHolder.doFilter(FilterHolder.java:193)
        at org.eclipse.jetty.servlet.ServletHandler$Chain.doFilter(ServletHandler.java:1601)
        at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:548)
        at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
        at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624)
        at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233)
        at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1435)
        at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188)
        at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:501)
        at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594)
        at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186)
        at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1350)
        at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
        at org.eclipse.jetty.server.handler.RequestLogHandler.handle(RequestLogHandler.java:54)
        at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127)
        at org.eclipse.jetty.server.Server.handle(Server.java:516)
        at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:388)
        at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:633)
        at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:380)
        at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:273)
        at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311)
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
        at org.eclipse.jetty.io.ssl.SslConnection$DecryptedEndPoint.onFillable(SslConnection.java:540)
        at org.eclipse.jetty.io.ssl.SslConnection.onFillable(SslConnection.java:395)
        at org.eclipse.jetty.io.ssl.SslConnection$2.succeeded(SslConnection.java:161)
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105)
        at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.runTask(EatWhatYouKill.java:336)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:313)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.tryProduce(EatWhatYouKill.java:171)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:129)
        at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:375)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:773)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:905)
        at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.ClassNotFoundException: com.fasterxml.jackson.core.Versioned
        at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:471)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:589)
        at java.base/java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:899)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
        ... 66 more



Nasser Grainawi

unread,
Dec 8, 2021, 1:20:19 PM12/8/21
to johann...@gmail.com, Repo and Gerrit Discussion

On Dec 8, 2021, at 8:20 AM, johann...@gmail.com <johann...@gmail.com> wrote:

Hi,

After upgrading gerrit to 3.5.0.1 and the oauth plugin to latest from gerrit-ci (plugin-oauth-bazel-master-stable-3.5) I get the below stack trace when trying to login.

Yeah, looks like a problem with the jackson-core library. It used to make it into the server runtime through ElasticSearch support, but when ES was removed that changed. Adding it into https://gerrit.googlesource.com/plugins/oauth/+/refs/heads/master/external_plugin_deps.bzl will fix it. Not sure I’ll have time to do that today, but if someone pushes a change I can review it.

Nasser

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/4cc24417-cbfb-4391-848b-8e3eb6db332en%40googlegroups.com.

Luca Milanesio

unread,
Dec 8, 2021, 1:22:12 PM12/8/21
to Repo and Gerrit Discussion, Luca Milanesio, johann...@gmail.com, Nasser Grainawi

On 8 Dec 2021, at 18:20, Nasser Grainawi <nas...@codeaurora.org> wrote:



On Dec 8, 2021, at 8:20 AM, johann...@gmail.com <johann...@gmail.com> wrote:

Hi,

After upgrading gerrit to 3.5.0.1 and the oauth plugin to latest from gerrit-ci (plugin-oauth-bazel-master-stable-3.5) I get the below stack trace when trying to login.

Yeah, looks like a problem with the jackson-core library. It used to make it into the server runtime through ElasticSearch support, but when ES was removed that changed. Adding it into https://gerrit.googlesource.com/plugins/oauth/+/refs/heads/master/external_plugin_deps.bzl will fix it. Not sure I’ll have time to do that today, but if someone pushes a change I can review it.

Yeah, though I’m puzzled that none of the plugin’s tests are failing, which is worrying isn’t it?
I’ll have a look at the issue as well.

Luca.

Nasser Grainawi

unread,
Dec 8, 2021, 1:23:52 PM12/8/21
to Luca Milanesio, Repo and Gerrit Discussion, johann...@gmail.com
On Dec 8, 2021, at 11:22 AM, Luca Milanesio <luca.mi...@gmail.com> wrote:



On 8 Dec 2021, at 18:20, Nasser Grainawi <nas...@codeaurora.org> wrote:



On Dec 8, 2021, at 8:20 AM, johann...@gmail.com <johann...@gmail.com> wrote:

Hi,

After upgrading gerrit to 3.5.0.1 and the oauth plugin to latest from gerrit-ci (plugin-oauth-bazel-master-stable-3.5) I get the below stack trace when trying to login.

Yeah, looks like a problem with the jackson-core library. It used to make it into the server runtime through ElasticSearch support, but when ES was removed that changed. Adding it into https://gerrit.googlesource.com/plugins/oauth/+/refs/heads/master/external_plugin_deps.bzl will fix it. Not sure I’ll have time to do that today, but if someone pushes a change I can review it.

Yeah, though I’m puzzled that none of the plugin’s tests are failing, which is worrying isn’t it?

It’s available at compile-time still through the plugins/BUILD file. We should probably change that (and re-evaluate how that’s being handled in general) so that plugins don’t expect it to be provided.

Luca Milanesio

unread,
Dec 8, 2021, 2:01:32 PM12/8/21
to Repo and Gerrit Discussion, Luca Milanesio, johann...@gmail.com, Nasser Grainawi

On 8 Dec 2021, at 18:23, Nasser Grainawi <nas...@codeaurora.org> wrote:
On Dec 8, 2021, at 11:22 AM, Luca Milanesio <luca.mi...@gmail.com> wrote:
On 8 Dec 2021, at 18:20, Nasser Grainawi <nas...@codeaurora.org> wrote:
On Dec 8, 2021, at 8:20 AM, johann...@gmail.com <johann...@gmail.com> wrote:

Hi,

After upgrading gerrit to 3.5.0.1 and the oauth plugin to latest from gerrit-ci (plugin-oauth-bazel-master-stable-3.5) I get the below stack trace when trying to login.

Yeah, looks like a problem with the jackson-core library. It used to make it into the server runtime through ElasticSearch support, but when ES was removed that changed. Adding it into https://gerrit.googlesource.com/plugins/oauth/+/refs/heads/master/external_plugin_deps.bzl will fix it. Not sure I’ll have time to do that today, but if someone pushes a change I can review it.

Yeah, though I’m puzzled that none of the plugin’s tests are failing, which is worrying isn’t it?

It’s available at compile-time still through the plugins/BUILD file. We should probably change that (and re-evaluate how that’s being handled in general) so that plugins don’t expect it to be provided.

I’ll have a look at the issue as well.


Adrià Vilanova Martínez

unread,
Dec 8, 2021, 3:37:55 PM12/8/21
to Repo and Gerrit Discussion
I can verify this fixes the issue at least for me. Thanks for fixing it so quickly! :)

johann...@gmail.com

unread,
Dec 9, 2021, 3:04:17 AM12/9/21
to Repo and Gerrit Discussion
I can also verify that this solves the problem. Thanks for your support!
Regards
/Johannes

Andrew Allen

unread,
Dec 12, 2021, 8:53:42 PM12/12/21
to Luca Milanesio, Repo and Gerrit Discussion, johann...@gmail.com, Nasser Grainawi
Luca


On Wed, Dec 8, 2021 at 8:01 PM Luca Milanesio <luca.mi...@gmail.com> wrote:



On 8 Dec 2021, at 18:23, Nasser Grainawi <nas...@codeaurora.org> wrote:
On Dec 8, 2021, at 11:22 AM, Luca Milanesio <luca.mi...@gmail.com> wrote:
On 8 Dec 2021, at 18:20, Nasser Grainawi <nas...@codeaurora.org> wrote:
On Dec 8, 2021, at 8:20 AM, johann...@gmail.com <johann...@gmail.com> wrote:

Hi,

After upgrading gerrit to 3.5.0.1 and the oauth plugin to latest from gerrit-ci (plugin-oauth-bazel-master-stable-3.5) I get the below stack trace when trying to login.

Yeah, looks like a problem with the jackson-core library. It used to make it into the server runtime through ElasticSearch support, but when ES was removed that changed. Adding it into https://gerrit.googlesource.com/plugins/oauth/+/refs/heads/master/external_plugin_deps.bzl will fix it. Not sure I’ll have time to do that today, but if someone pushes a change I can review it.

Yeah, though I’m puzzled that none of the plugin’s tests are failing, which is worrying isn’t it?

It’s available at compile-time still through the plugins/BUILD file. We should probably change that (and re-evaluate how that’s being handled in general) so that plugins don’t expect it to be provided.

I’ll have a look at the issue as well.


Fixed with [1] and the Gerrit’s part of the fix is [2].


Is there any chance you could cut a v3.5.0.2 that contains this release? This was a stumbling block for me when going to v3.5 and it feels a shame to have a rough onboarding when the fix is checked in.

Thank you!

Andrew Allen

unread,
Dec 12, 2021, 9:57:42 PM12/12/21
to Luca Milanesio, Repo and Gerrit Discussion, johann...@gmail.com, Nasser Grainawi
On Mon, Dec 13, 2021 at 2:53 AM Andrew Allen <m...@andrewzallen.com> wrote:
Luca


On Wed, Dec 8, 2021 at 8:01 PM Luca Milanesio <luca.mi...@gmail.com> wrote:



On 8 Dec 2021, at 18:23, Nasser Grainawi <nas...@codeaurora.org> wrote:
On Dec 8, 2021, at 11:22 AM, Luca Milanesio <luca.mi...@gmail.com> wrote:
On 8 Dec 2021, at 18:20, Nasser Grainawi <nas...@codeaurora.org> wrote:
On Dec 8, 2021, at 8:20 AM, johann...@gmail.com <johann...@gmail.com> wrote:

Hi,

After upgrading gerrit to 3.5.0.1 and the oauth plugin to latest from gerrit-ci (plugin-oauth-bazel-master-stable-3.5) I get the below stack trace when trying to login.

Yeah, looks like a problem with the jackson-core library. It used to make it into the server runtime through ElasticSearch support, but when ES was removed that changed. Adding it into https://gerrit.googlesource.com/plugins/oauth/+/refs/heads/master/external_plugin_deps.bzl will fix it. Not sure I’ll have time to do that today, but if someone pushes a change I can review it.

Yeah, though I’m puzzled that none of the plugin’s tests are failing, which is worrying isn’t it?

It’s available at compile-time still through the plugins/BUILD file. We should probably change that (and re-evaluate how that’s being handled in general) so that plugins don’t expect it to be provided.

I’ll have a look at the issue as well.


Fixed with [1] and the Gerrit’s part of the fix is [2].


Is there any chance you could cut a v3.5.0.2 that contains this release? This was a stumbling block for me when going to v3.5 and it feels a shame to have a rough onboarding when the fix is checked in.

I was thinking about this a bit more and decided to actually do a diff to run it down. Turns out I'm wrong and there isn't any action required here. I needed to update a plugin on that server and missed it in my checklist. Sorry to bother you!
Reply all
Reply to author
Forward
0 new messages