Gerrit Change Request: Show diff between Patchsets
FireFart
someone uploads Patchset2, you can see what was changed.
When there is a commit with many files, and you reviewed them in
Patchset1 and wanted the dev to just add some little things, you can
now verify that nothing else has changed.
David Brown
Gerrit has been able to do this for a while, how. When viewing a
patch, just click on the "Patch history" disclosure triangle, and it
will let you view changes between arbitrary patchsets.
I've been asked about this several times at work, and I wonder if
there is some way this could be made more discoverable.
- It isn't visible until you actually look at the diff of a given
file. Actually, Gerrit only showing diffs individually per file
is why I frequently end up pulling changes down, and viewing them
with git show. Especially for kernel changes, seeing the whole
patchset is fairly important to properly reviewing it.
- Even in the file diff view, it's just a word with a little
triangle. Not sure how to make this clearer, though.
David
Antony Stubbs
Basically there needs to be a "diff stat" type display for what the
new patch-set changes, not just a simply list if files. I find myself
having to open the first file in Gerrit and hunt down the one file
that has changed in this version of the patch. It would be great if I
could jump straight to it from the main page.
Thoughts?
Regards,
Antony Stubbs
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en