gerrithub.io and GitHub Actions

Paul Jolly

unread,

May 12, 2021, 2:28:56 PM5/12/21

to Repo and Gerrit Discussion

Hi all,

Last year I started experimenting with importing a number of my GitHub repos into gerrithub.io for review. The process was, generally speaking, incredibly smooth - congratulations to the folks who maintain gerrithub.io.

One thing however that did not work was replication of a submitted CL that involved a change to any GitHub Actions workflow files, i.e. any .github/workflows/*.yml file.

At the time, Luca Milanesio kindly helped to explain that this was likely because the permissions requested during the repository import wizard did not include the actions/workflow scope.

I just tried this again, and ran into the same issue.

Does anyone else use gerrithub.io in combination with GitHub Actions? If so, please can you share how you solved this problem?

Many thanks,

Paul

Luca Milanesio

unread,

May 12, 2021, 2:31:50 PM5/12/21

to Paul Jolly, Luca Milanesio, Repo and Gerrit Discussion

On 12 May 2021, at 19:28, Paul Jolly <pa...@myitcv.org.uk> wrote:

Hi all,

Last year I started experimenting with importing a number of my GitHub repos into gerrithub.io for review. The process was, generally speaking, incredibly smooth - congratulations to the folks who maintain gerrithub.io.

Thanks a lot for the compliment, on behalf of GerritForge, “the folks who maintain GerritHub.io”.

One thing however that did not work was replication of a submitted CL that involved a change to any GitHub Actions workflow files, i.e. any .github/workflows/*.yml file.

At the time, Luca Milanesio kindly helped to explain that this was likely because the permissions requested during the repository import wizard did not include the actions/workflow scope.

I just tried this again, and ran into the same issue.

My bad, let me raise an issue and put in our board.

Luca.

Does anyone else use gerrithub.io in combination with GitHub Actions? If so, please can you share how you solved this problem?

Many thanks,

Paul

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/8aa5ee17-80e2-4624-ba36-a1aced64ab4bn%40googlegroups.com.

Luca Milanesio

unread,

May 12, 2021, 2:34:52 PM5/12/21

to Repo and Gerrit Discussion, Luca Milanesio

On 12 May 2021, at 19:31, Luca Milanesio <luca.mi...@gmail.com> wrote:

On 12 May 2021, at 19:28, Paul Jolly <pa...@myitcv.org.uk> wrote:

Hi all,

Last year I started experimenting with importing a number of my GitHub repos into gerrithub.io for review. The process was, generally speaking, incredibly smooth - congratulations to the folks who maintain gerrithub.io.

Thanks a lot for the compliment, on behalf of GerritForge, “the folks who maintain GerritHub.io”.

One thing however that did not work was replication of a submitted CL that involved a change to any GitHub Actions workflow files, i.e. any .github/workflows/*.yml file.

At the time, Luca Milanesio kindly helped to explain that this was likely because the permissions requested during the repository import wizard did not include the actions/workflow scope.

I just tried this again, and ran into the same issue.

My bad, let me raise an issue and put in our board.

Done:

https://bugs.chromium.org/p/gerrit/issues/detail?id=14533

This needs first to be implemented on the GitHub plugin and then GerritHub.io will have to configure it in production.

Paul Jolly

unread,

May 12, 2021, 3:52:18 PM5/12/21

to Luca Milanesio, Repo and Gerrit Discussion

> Thanks a lot for the compliment, on behalf of GerritForge, “the folks who maintain GerritHub.io”.

I mean it wholeheartedly! And indeed look forward to creating a blog
post on how GerritHub and GitHub Actions work incredibly well
together!

> My bad, let me raise an issue and put in our board.
>
>

> Done:
> https://bugs.chromium.org/p/gerrit/issues/detail?id=14533
>
> This needs first to be implemented on the GitHub plugin and then GerritHub.io will have to configure it in production.

Thank you very much for confirming, and indeed responding so quickly.

Paul

Christian Gagneraud

unread,

May 12, 2021, 5:22:21 PM5/12/21

to Paul Jolly, Luca Milanesio, Repo and Gerrit Discussion

On Thu, 13 May 2021 at 07:52, Paul Jolly <pa...@myitcv.io> wrote:
>
> > Thanks a lot for the compliment, on behalf of GerritForge, “the folks who maintain GerritHub.io”.
>
> I mean it wholeheartedly! And indeed look forward to creating a blog
> post on how GerritHub and GitHub Actions work incredibly well
> together!

Hi All,

Sorry to hijack the thread.
Is it possible to use gitlab instead of github?
And for the CI part, is it possible to use Jenkins?
Looking at GerritForge, it looks like it's only for github.
GerritLab.io? ;)

Chris

Luca Milanesio

unread,

May 12, 2021, 5:25:23 PM5/12/21

to Repo and Gerrit Discussion, Luca Milanesio

Thanks for the question :-) and I actually tried hard, without success.

The problem is twofold:
1. GitLab does not support Gerrit’s refs (refs/changes/*) so I won’t know where to push them
2. GitLab suffers a lot with repositories with lots of refs

I raised both 1. and 2. to the GitLab’s Team and they never got them solved.

That was around 12 months ago, I could try again and see if they made any progress there.

Luca.

Paul Jolly

unread,

May 14, 2021, 4:48:27 AM5/14/21

to Repo and Gerrit Discussion

Luca - it just occurred to me that this group might not be the best place for me to ask questions about/raise suggestions for gerrithub.

Please can you let me know if this is/isn't the best place? If it is, is there a subject prefix/format you prefer?

Many thanks

Luca Milanesio

unread,

May 14, 2021, 4:53:34 AM5/14/21

to Repo and Gerrit Discussion, Luca Milanesio

On 14 May 2021, at 09:48, Paul Jolly <pa...@myitcv.org.uk> wrote:

Luca - it just occurred to me that this group might not be the best place for me to ask questions about/raise suggestions for gerrithub.

Why not? GerritHub is just Gerrit Code Review + GitHub plugin.

In this group we talk about Gerrit Code Review and associated plugins.

There isn’t a piece of software in GerritHub.io that isn’t OpenSource and therefore that cannot be discussed here.

Please can you let me know if this is/isn't the best place? If it is, is there a subject prefix/format you prefer?

Many thanks

I believe you have included GerritHub in the subject, so it should be enough IMHO.

Luca.

On Wednesday, 12 May 2021 at 22:25:23 UTC+1 lucamilanesio wrote:

> On 12 May 2021, at 22:22, Christian Gagneraud <chg...@gmail.com> wrote:
>
> On Thu, 13 May 2021 at 07:52, Paul Jolly <pa...@myitcv.io> wrote:
>>
>>> Thanks a lot for the compliment, on behalf of GerritForge, “the folks who maintain GerritHub.io”.
>>
>> I mean it wholeheartedly! And indeed look forward to creating a blog
>> post on how GerritHub and GitHub Actions work incredibly well
>> together!
>
> Hi All,
>
> Sorry to hijack the thread.
> Is it possible to use gitlab instead of github?
> And for the CI part, is it possible to use Jenkins?
> Looking at GerritForge, it looks like it's only for github.
> GerritLab.io? ;)

Thanks for the question :-) and I actually tried hard, without success.

The problem is twofold:
1. GitLab does not support Gerrit’s refs (refs/changes/*) so I won’t know where to push them
2. GitLab suffers a lot with repositories with lots of refs

I raised both 1. and 2. to the GitLab’s Team and they never got them solved.

That was around 12 months ago, I could try again and see if they made any progress there.

Luca.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/1b474689-d5e2-48ff-bc32-4c985ffa066fn%40googlegroups.com.

Paul Jolly

unread,

May 14, 2021, 4:59:39 AM5/14/21

to Luca Milanesio, Repo and Gerrit Discussion

> Why not? GerritHub is just Gerrit Code Review + GitHub plugin.
> In this group we talk about Gerrit Code Review and associated plugins.
>
> There isn’t a piece of software in GerritHub.io that isn’t OpenSource and therefore that cannot be discussed here.

...

> I believe you have included GerritHub in the subject, so it should be enough IMHO.

Wonderful, thanks for confirming!

Paul

Paladox

unread,

Sep 17, 2024, 8:56:11 AM9/17/24

to Repo and Gerrit Discussion

@Paul sorry to hijack this thread but i wanted to ask do you know how you managed to get github actions to work with gerrithub?

Paul Jolly

unread,

Sep 17, 2024, 1:13:25 PM9/17/24

to Repo and Gerrit Discussion

@Paul sorry to hijack this thread but i wanted to ask do you know how you managed to get github actions to work with gerrithub?

The setup we established is used across all repositories that are part of the CUE (https://cuelang.org) project.

Some resources:

* https://www.youtube.com/watch?v=2B2PZTZlPJg is a presentation I gave on the subject

* https://github.com/cue-lang/cue is the main CUE repo. The source of truth is https://review.gerrithub.io/plugins/gitiles/cue-lang/cue

* https://github.com/cue-lang/cue/tree/master/.github/workflows contains the GitHub actions workflows for that project (although to be precise we use CUE as a source of truth and generate the Yaml)

* https://pkg.go.dev/github.com/cue-lang/contrib-tools/cmd/cueckoo is the CLI tool we use to trigger the CI workflows (we call them trybots)

The one thing to note is that ideally we would move away from using the cueckoo CLI to trigger the trybots and instead use labels on changes in GerritHub with a webhook listener to trigger the workflows.

Reply all

Reply to author

Forward