autosubmitter plugin v3.3.0 fails in Gerrit v3.3.1

78 views
Skip to first unread message

cookv...@gmail.com

unread,
Jan 14, 2021, 1:34:46 AM1/14/21
to Repo and Gerrit Discussion
Hi,

We are testing Gerrit v3.3.1 in Docker (image taken from [1]).
Autosubmitter plugin updated to the latest available version (v3.3.0).
The plugin fails when setting "Verified +1" and "Code-Review +2" labels on any change.
The change goes to "Ready to submit" state instead of "Merged" state.
At the same time, the following error appears on the Docker container console:
gerrit_1 | [2021-01-12T06:35:42.354Z] [HTTP POST /changes/testrepo~22752/revisions/2/review (testuser from 172.18.0.3)] WARN com.google.gerrit.server.plugincontext.PluginContext : Failure in class com.criteo.gerrit.plugins.automerge.AutomaticMerger of plugin autosubmitter [CONTEXT PLUGIN="gerrit" project="testrepo" ]
gerrit_1 | java.lang.NoSuchMethodError: 'com.google.gerrit.server.notedb.ChangeNotes com.google.gerrit.server.notedb.ChangeNotes$Factory.createChecked(com.google.gerrit.entities.Change$Id)'

Created issue on the bug tracker [2].


Luca Milanesio

unread,
Jan 14, 2021, 3:09:42 AM1/14/21
to cookv...@gmail.com, Luca Milanesio, Repo and Gerrit Discussion
Thanks for reporting it, let me have a look.

Luca.

Luca Milanesio

unread,
Jan 14, 2021, 3:29:21 AM1/14/21
to cookv...@gmail.com, Luca Milanesio, Repo and Gerrit Discussion
It looks like the Gerrit v.3.3.1 introduced some non-compatible changes on basic types, like Change.Id.

Also the build is now failing:
00:07:34.068 plugins/autosubmitter/src/main/java/com/criteo/gerrit/plugins/automerge/AtomicityHelper.java:166: error: incompatible types: Id cannot be converted to Change
00:07:34.068     ChangeNotes notes = changeNotesFactory.createChecked(changeId);
00:07:34.068                                                          ^
00:07:34.220 Target //plugins/autosubmitter:autosubmitter failed to build


Let me find the offending commit in Gerrit that broke this and possibly many other plugins :-(

Luca.

Luca Milanesio

unread,
Jan 14, 2021, 3:40:59 AM1/14/21
to cookv...@gmail.com, Luca Milanesio, Repo and Gerrit Discussion
There you go:

I need to trigger the rebuild of all plugins and see how many others are impacted.

Luca.

Luca Milanesio

unread,
Jan 14, 2021, 1:19:13 PM1/14/21
to cookv...@gmail.com, Luca Milanesio, Repo and Gerrit Discussion

On 14 Jan 2021, at 08:40, Luca Milanesio <luca.mi...@gmail.com> wrote:



On 14 Jan 2021, at 08:29, Luca Milanesio <luca.mi...@gmail.com> wrote:



On 14 Jan 2021, at 08:09, Luca Milanesio <luca.mi...@gmail.com> wrote:



On 14 Jan 2021, at 06:34, cookv...@gmail.com <cookv...@gmail.com> wrote:

Hi,

We are testing Gerrit v3.3.1 in Docker (image taken from [1]).
Autosubmitter plugin updated to the latest available version (v3.3.0).
The plugin fails when setting "Verified +1" and "Code-Review +2" labels on any change.
The change goes to "Ready to submit" state instead of "Merged" state.
At the same time, the following error appears on the Docker container console:
gerrit_1 | [2021-01-12T06:35:42.354Z] [HTTP POST /changes/testrepo~22752/revisions/2/review (testuser from 172.18.0.3)] WARN com.google.gerrit.server.plugincontext.PluginContext : Failure in class com.criteo.gerrit.plugins.automerge.AutomaticMerger of plugin autosubmitter [CONTEXT PLUGIN="gerrit" project="testrepo" ]
gerrit_1 | java.lang.NoSuchMethodError: 'com.google.gerrit.server.notedb.ChangeNotes com.google.gerrit.server.notedb.ChangeNotes$Factory.createChecked(com.google.gerrit.entities.Change$Id)'

Created issue on the bug tracker [2].

[1] https://hub.docker.com/layers/gerritcodereview/gerrit/3.3.1/images/sha256-72b0c95042c8dd2bed0f021661ce967c3e4c004275500510de3e39fb4e18aa27?context=explore
[2] https://bugs.chromium.org/p/gerrit/issues/detail?id=13939


@Davido fixed the issue and a new version of the plugin is building now:

Luca.

cookv...@gmail.com

unread,
Jan 19, 2021, 1:36:34 AM1/19/21
to Repo and Gerrit Discussion
The plugin now works fine.
Thank you!

четверг, 14 января 2021 г. в 21:19:13 UTC+3, lucamilanesio:
Reply all
Reply to author
Forward
0 new messages