[ANNOUNCE] Gerrit 2.8.5

[David Pursehouse]

Gerrit version 2.8.5 is now available.

Highlights:

- Fix deadlocks in secondary index shutdown

- Upgrade SSHD to fix various issues

- Fix a regression related to "commit already exists (in the project)"
error introduced in version 2.8.4

- Various minor fixes in the change screen

- ...and more as documented in the release notes.


Download:
https://gerrit-releases.storage.googleapis.com/gerrit-2.8.5.war

Log of changes since 2.8.4:
https://gerrit.googlesource.com/gerrit/+log/v2.8.4..v2.8.5

Release notes:
http://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.8.5.html



Documentation:
http://gerrit-documentation.storage.googleapis.com/Documentation/2.8.5/index.html

[David Ostrovsky]

Am Freitag, 9. Mai 2014 07:15:10 UTC+2 schrieb David Pursehouse:

Gerrit version 2.8.5 is now available.

As indicated in this issue [1] release notes missing the instruction to run the site upgrade.

It's mentioned correctly that there were no schema changes and that bouncycastle 

was upgraded, but to fetch new version of the library Gerrit site must be upgraded.

[1] https://code.google.com/p/gerrit/issues/detail?id=2651

[David Pursehouse]

On Tue, May 13, 2014 at 8:45 PM, David Ostrovsky <david.o...@gmail.com> wrote:

Am Freitag, 9. Mai 2014 07:15:10 UTC+2 schrieb David Pursehouse:

Gerrit version 2.8.5 is now available.

As indicated in this issue [1] release notes missing the instruction to run the site upgrade.

It's mentioned correctly that there were no schema changes and that bouncycastle 

was upgraded, but to fetch new version of the library Gerrit site must be upgraded.

I've updated the release notes with more information.

https://gerrit-review.googlesource.com/#/c/57127/

[David Ostrovsky]

Thanks for the quick fix. Can the updated version be deployed on [1]?

[1] https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.8.5.html

[David Pursehouse]

On 05/14/2014 02:54 PM, David Ostrovsky wrote:
> I've updated the release notes with more information.
>
> https://gerrit-review.googlesource.com/#/c/57127/
> <https://gerrit-review.googlesource.com/#/c/57127/>
>
>
> Thanks for the quick fix. Can the updated version be deployed on [1]?
>
> [1]
> https://gerrit-documentation.storage.googleapis.com/ReleaseNotes/ReleaseNotes-2.8.5.html
>

Sorry, I intended to do that when I arrived in the office this morning,
but forgot.

Done now.

[David Ostrovsky]

Am Freitag, 9. Mai 2014 07:15:10 UTC+2 schrieb David Pursehouse:

Gerrit version 2.8.5 is now available.

Can we consider to create 2.8.6 with this race condition fix in merge queue code [1]?

[1] https://gerrit-review.googlesource.com/57770

[David Pursehouse]

On Thu, Jun 12, 2014 at 8:00 PM, David Ostrovsky <david.o...@gmail.com> wrote:

Am Freitag, 9. Mai 2014 07:15:10 UTC+2 schrieb David Pursehouse:

Gerrit version 2.8.5 is now available.

Can we consider to create 2.8.6 with this race condition fix in merge queue code [1]?

It doesn't cherry-pick cleanly onto stable-2.8 and the review on stable-2.9 has got -1 from Edwin, so right now the answer is no.

How critical is this?  If it's critical and you can backport it to stable-2.8, a 2.8.6 release could be considered.

I won't have time until end of next week though.

[David Ostrovsky]

Am Donnerstag, 12. Juni 2014 14:37:58 UTC+2 schrieb David Pursehouse:

On Thu, Jun 12, 2014 at 8:00 PM, David Ostrovsky <david.o...@gmail.com> wrote:

Am Freitag, 9. Mai 2014 07:15:10 UTC+2 schrieb David Pursehouse:

Gerrit version 2.8.5 is now available.

Can we consider to create 2.8.6 with this race condition fix in merge queue code [1]?

It doesn't cherry-pick cleanly onto stable-2.8 and the review on stable-2.9 has got -1 from Edwin, so right now the answer is no.

Yes, the problem would be unit test. The code itself is more or less unchanged from 2.6 code base.

 

How critical is this?  If it's critical and you can backport it to stable-2.8, a 2.8.6 release could be considered.

Yes, it's critical. From these issues [1] and [2] you can see, that Gerrit sites with this combination:

* cherry-pick submit type

* PostgreSQL database

have severe impact and produce periodically failed merges and database corruptions:

multiple rows in patch_sets table with the same SHA-1.

Not to mention, that corrupted changes cannot be loaded on new change screen: 404.

I would also like to suggest to block 2.9 final until this critical bug is fixed. 

[1] https://code.google.com/p/gerrit/issues/detail?id=2034

[2] https://code.google.com/p/gerrit/issues/detail?id=2702

[David Ostrovsky]

Am Donnerstag, 12. Juni 2014 15:31:27 UTC+2 schrieb David Ostrovsky:

Am Donnerstag, 12. Juni 2014 14:37:58 UTC+2 schrieb David Pursehouse:

On Thu, Jun 12, 2014 at 8:00 PM, David Ostrovsky <david.o...@gmail.com> wrote:

Am Freitag, 9. Mai 2014 07:15:10 UTC+2 schrieb David Pursehouse:

Gerrit version 2.8.5 is now available.

Can we consider to create 2.8.6 with this race condition fix in merge queue code [1]?

It doesn't cherry-pick cleanly onto stable-2.8 and the review on stable-2.9 has got -1 from Edwin, so right now the answer is no.

Yes, the problem would be unit test. The code itself is more or less unchanged from 2.6 code base.

 

How critical is this?  If it's critical and you can backport it to stable-2.8, a 2.8.6 release could be considered.

Yes, it's critical. From these issues [1] and [2] you can see, that Gerrit sites with this combination:

Forgot to mention that all released Gerrit versions are affected.  In fact the unit

test from [1] that is able to reproduce OrmConcurrencyException reported in the

issue is red on current master as well.

[1] https://gerrit-review.googlesource.com/57770

[David Pursehouse]

OK.  Please replace the current change on stable-2.9 with a change on stable-2.8 and get it reviewed there.

I'll look into it tomorrow or early next week.  Even if we don't release 2.8.6 it'll get merged up to stable-2.9 and be in the next RC (or final) of 2.9.

[David Ostrovsky]

That would be very much appreciated. 

[David Ostrovsky]

Done in [1]. I gave up to migrate unit test to the old world, though.

I could reproduce/prevent database corruption on PostgreSQL meantime

and we have the full stack trace too, recorded in [2]. As assumed we

have collision between manual and background scheduled jobs.

[1] https://gerrit-review.googlesource.com/57825

[2] https://code.google.com/p/gerrit/issues/detail?id=2034

[David Ostrovsky]

It turns out hot fix of gwtorm is needed as well as explained on Outstanding Topics page [1].

I've uploaded that change on master branch [1], as the only stable branch there is outdated

and we don't have one to one relation between Gerrit and gwtorm releases. So the question

is what is the right way to patch gwtorm for 2.8.6 release?

[1] https://code.google.com/p/gerrit/wiki/OutstandingTopics#Intermittent_data_loss_and_corruption

[2] https://gerrit-review.googlesource.com/57851

[David Pursehouse]

On 06/18/2014 04:36 PM, David Ostrovsky wrote:
>
>
> It turns out hot fix of gwtorm is needed as well as explained on
> Outstanding Topics page [1].
> I've uploaded that change on master branch [1], as the only stable
> branch there is outdated
> and we don't have one to one relation between Gerrit and gwtorm
> releases. So the question
> is what is the right way to patch gwtorm for 2.8.6 release?
>

There are a number of other commits on gwtorm since 1.7 [1] and I don't
think it's appropriate to include them all in 2.8.6

Shall we create a branch from the v1.7 tag and backport your fix there?


[1]
$ git log v1.7..HEAD --oneline --no-merges
895048d Add transaction support for Jdbc dialects
507b5e8 Generate javadocs in Maven build
46ff97f Add SCM information to pom.xml
74cd210 Start 1.12 development
271faea gwtorm 1.11
b1ffb44 Fix a bug where "LIMIT ?" in queries was omitted in the
generated query
1822933 Start 1.11 development
7e1590a gwtorm 1.10
05b90f0 Add dialect for SAP MaxDB
947a92d Start 1.10 development
4098e45 gwtorm 1.9
9ed9aa6 Update the versions of protobuf, asm and guava libraries
87d0408 Start 1.9 development
f51e273 gwtorm 1.8
2a8533f Eclipse: Bump java source and target level to 7
a1be014 Bump java default source and target level to 7
389a55e Add missing @Override annotations
7d8ebdf Add assertion to prevent NPE
9128b95 Expose listIndexes method for supported SQL dialects
64ac648 Fix typo
88abc04 Reject database identifiers greater than 30 characters
9460c77 Remove unused import
cca2e16 Start 1.8 development

[David Ostrovsky]

Am Freitag, 27. Juni 2014 09:36:44 UTC+2 schrieb David Pursehouse:

On 06/18/2014 04:36 PM, David Ostrovsky wrote:
>
>
> It turns out hot fix of gwtorm is needed as well as explained on
> Outstanding Topics page [1].
> I've uploaded that change on master branch [1], as the only stable
> branch there is outdated
> and we don't have one to one relation between Gerrit and gwtorm
> releases. So the question
> is what is the right way to patch gwtorm for 2.8.6 release?
>

There are a number of other commits on gwtorm since 1.7 [1] and I don't
think it's appropriate to include them all in 2.8.6

Shall we create a branch from the v1.7 tag and backport your fix there?

Yes. So b1ffb44 would be also very interessting to include on 2.8.6.

[David Pursehouse]

Also cherry-picked as [1].

[1] https://gerrit-review.googlesource.com/58107

[Dariusz Luksza]

Any plans for releasing 2.8.6?

I've noticed that stable-2.8 already have 2.8.6 version, but there is
no tag in official repo nor release available for download. There are
also new commits on top of 2.8.6 version in stable-8.2 branch.

Are there any blocker for official 2.8.6?

> --
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> --- You received this message because you are subscribed to the Google
> Groups "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to repo-discuss...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



--
Best regards

GSM: +49 017 445 41235
Blog: http://luksza.org http://javablog.pl
LinkedIn: http://linkedin.com/in/dariuszluksza

[David Ostrovsky]

Am Montag, 30. Juni 2014 12:45:00 UTC+2 schrieb Dariusz Łuksza:

Any plans for releasing 2.8.6? 

Yes. Some blocker changes are still under review. Most notable gtworm transaction

support with branched gwtorm 1.7.1 version, as explained on outstanding topics page [1].

Moreover Matthias suggested to fix broken Apache SSHD as well, as discussed in this thread [2].

[1] https://code.google.com/p/gerrit/wiki/OutstandingTopics#Intermittent_data_loss_and_corruption

[2] https://groups.google.com/d/topic/repo-discuss/JE7OM6o7DMs