Adding an All-Projects / global "no unresolved comments" submit requirement

29 views
Skip to first unread message

Wade Carpenter

unread,
Sep 4, 2024, 6:16:17 PM9/4/24
to Repo and Gerrit Discussion
Hi folks,

I was trying to figure out how https://groups.google.com/g/repo-discuss/c/zzVtWXg0qSs/m/c1RXBnVUAgAJ was implemented.

Is it just set in the All-Projects refs/meta/config? I was looking at Public-Projects, but it's not there. As a public user I can't read the All-Projects refs/meta/config.

I believe it makes sense that it was configured in All-Projects and inherited by the rest, but I was hoping to confirm and also see the hashtag bypass mechanism. I can certainly sort it out myself, but if there's an existing reference I can compare against, that's even better.

Is anyone willing / able to excerpt that rule from All-Projects for reference?

Thanks!
Wade

Matthias Sohn

unread,
Sep 4, 2024, 8:33:08 PM9/4/24
to Wade Carpenter, Repo and Gerrit Discussion
On Wed, Sep 4, 2024 at 8:16 PM 'Wade Carpenter' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:
Hi folks,

I was trying to figure out how https://groups.google.com/g/repo-discuss/c/zzVtWXg0qSs/m/c1RXBnVUAgAJ was implemented.

Try this in project.config on refs/meta/config, if you define this in All-Projects it should be used for all projects:

[submit-requirement "No-Unresolved-Comments"]
description = Changes that have unresolved comments are not submittable. Unless overriden by adding the hashtag allow-unresolved-comments.
submittableIf = -has:unresolved OR hashtag:allow-unresolved-comments
canOverrideInChildProjects = false
 
Is it just set in the All-Projects refs/meta/config? I was looking at Public-Projects, but it's not there. As a public user I can't read the All-Projects refs/meta/config.

I believe it makes sense that it was configured in All-Projects and inherited by the rest, but I was hoping to confirm and also see the hashtag bypass mechanism. I can certainly sort it out myself, but if there's an existing reference I can compare against, that's even better.

Is anyone willing / able to excerpt that rule from All-Projects for reference? 

Thanks!
Wade

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/cb7496f2-91c2-4052-9052-efba88fcde9bn%40googlegroups.com.

Wade Carpenter

unread,
Sep 4, 2024, 10:19:52 PM9/4/24
to Repo and Gerrit Discussion
Thanks for confirming, it's exactly what I was trying out.
Reply all
Reply to author
Forward
0 new messages