Add Reviewed-By to commit-message when change is merged

[Liwei SUN]

Hi, 

Is it possiable to automactically add reviewer's information who actually does the vote to commit-message when chagne is merged?

Thanks,

Liwei

[Nasser Grainawi]

On Nov 11, 2021, at 5:13 AM, Liwei SUN <sun...@gmail.com> wrote:

Hi, 

Is it possiable to automactically add reviewer's information who actually does the vote to commit-message when chagne is merged?

The “Cherry Pick” submit type [1] does this.

For other submit types, you can use the review notes plugin [2], which writes reviewer information and other change information into a notes branch that you can fetch and view with git log and other commands.

[1] https://gerrit-review.googlesource.com/Documentation/config-project-config.html#submit-type

[2] https://gerrit-review.googlesource.com/Documentation/config-plugins.html#reviewnotes

Thanks,

Liwei

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/0b141e88-d403-4ba7-95b8-9a88473c4003n%40googlegroups.com.

[Han-Wen Nienhuys]

On Thu, Nov 11, 2021 at 5:08 PM Nasser Grainawi <nas...@codeaurora.org> wrote:
> Is it possiable to automactically add reviewer's information who actually does the vote to commit-message when chagne is merged?
>
>
> The “Cherry Pick” submit type [1] does this.
>
> For other submit types, you can use the review notes plugin [2], which writes reviewer information and other change information into a notes branch that you can fetch and view with git log and other commands.
>
> [1] https://gerrit-review.googlesource.com/Documentation/config-project-config.html#submit-type
> [2] https://gerrit-review.googlesource.com/Documentation/config-plugins.html#reviewnotes

IIRC, the reviewnotes plugin doesn't respect branch visibility so it
shouldn't be used if you have per-branch visibility settings.


--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

[Liwei SUN]

Thank you! The "review notes plugin" is exactly what I want!. :)