Gerrit 3.7.0 Auto Merge Code

[zhang xi]

HI Teams,

There is such a bug in my project， The code I submitted was automatically merged into the master without manual review。He is not a necessary issue, as it seems to appear after the abandoned Relationship chain, and he occasionally merges it automatically.我的项目中有这样一个bug

I hope to receive your reply and thank you again for your help！

[Daniele Sassoli]

On Thursday, 1 June 2023 at 11:02:43 UTC+1 zhang xi wrote:

HI Teams,

There is such a bug in my project， The code I submitted was automatically merged into the master without manual review。He is not a necessary issue, as it seems to appear after the abandoned Relationship chain, and he occasionally merges it automatically.

 

Potentially  the patchset was previously approved and, potentially, there is a sticky configuration that re-applies it to the next patchset automatically and then your job merges it.
Alternatively you could have disabled a requirement for the patchset to be approved at all, as explained here[1].

Not sure how this can be happening on an abandoned relationship chain though. Some additional information might be useful.

[1] https://gerrit-review.googlesource.com/Documentation/config-labels.html

[zhang xi]

Hi Teams，HI

Nice to receive your reply.

The attachment contains my `project.config` and two images of my project that I have pasted, 

As you can see from the picture, gerrit-2069 was merged without anyone's review.And there is no merge information in the `change log`.

I hope to receive your reply again. Have a good day!

[Martin Fick]

Are there any change comments indicating why/how it got merged?

-Martin

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/9623ae4d-e988-4853-946d-636735a351ben%40googlegroups.com.

[Kenyon Ralph]

On Friday, June 2, 2023 at 5:57:04 AM UTC-7 zhang xi wrote:

Hi Teams，HI

Nice to receive your reply.

The attachment contains my `project.config` and two images of my project that I have pasted, 

As you can see from the picture, gerrit-2069 was merged without anyone's review.And there is no merge information in the `change log`.

I hope to receive your reply again. Have a good day!

I have found that this can happen if you submit a code review that has parent commits that exist in other branches of the repo on Gerrit. Those parent commits will go into the target branch without even a code review.

[zhang xi]

Hi All，

This is a complete screenshot.

[Martin Fick]

I believe the answer lies with the comment that says "Change has been successfully pushed.". I believe this means that someone pushed the change directly to the branch and thus by-passing review on it. If you want to prevent this, you likely need to add an ACL to deny direct push es to refs/heads/master (or remove the ACL which add "ALLOW" to do that),

-Martin

--

--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/a8e4361d-03f6-4c38-a3a9-ca4ff77ce8c4n%40googlegroups.com.