Making PolyGerrit the default UI for gerrit-review.googlesource.com

[Logan Hanks]

I'd like to propose changing the default UI setting on https://gerrit-review.googlesource.com to PolyGerrit. This setting makes it so that PolyGerrit is the UI served by default, unless the user has a cookie indicating their UI preference. This cookie is set whenever you switch between the old and new UIs, so once you switch, your choice sticks until you switch it again.

There are other sites hosted by Google that have taken the plunge, so we know that PolyGerrit is ready for day-to-day review work. There are, however, some missing features that will affect our contributors, most notably online editing and anything having to do with administration. It's easy to switch to the old UI for these features, and it seems unlikely that new collaborators would miss them.

Users of PolyGerrit will experience the following enhancements:

    - inline diffs

    - improved diff viewing performance

    - "resolved" checkbox on comments

    - CC support

    - mobile support

    - multiple updates per week

Does anyone object to this change? If not, I'll make it effective on Monday, March 6.

[Edwin Kempin]

On Thu, Mar 2, 2017 at 1:25 AM, 'Logan Hanks' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

I'd like to propose changing the default UI setting on https://gerrit-review.googlesource.com to PolyGerrit.

+1

 

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[luca.mi...@gmail.com]

Sent from my iPhone

On 2 Mar 2017, at 06:13, 'Edwin Kempin' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

On Thu, Mar 2, 2017 at 1:25 AM, 'Logan Hanks' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

I'd like to propose changing the default UI setting on https://gerrit-review.googlesource.com to PolyGerrit.

+1

+1

But we need to at least populate the remaining entries of the top-menu, even if they point to the old GWT should the screen not yet available in PolyGerrit.

 

This setting makes it so that PolyGerrit is the UI served by default, unless the user has a cookie indicating their UI preference. This cookie is set whenever you switch between the old and new UIs, so once you switch, your choice sticks until you switch it again.

There are other sites hosted by Google that have taken the plunge, so we know that PolyGerrit is ready for day-to-day review work. There are, however, some missing features that will affect our contributors, most notably online editing and anything having to do with administration. It's easy to switch to the old UI for these features, and it seems unlikely that new collaborators would miss them.

Users of PolyGerrit will experience the following enhancements:

    - inline diffs

    - improved diff viewing performance

    - "resolved" checkbox on comments

    - CC support

    - mobile support

    - multiple updates per week

Does anyone object to this change? If not, I'll make it effective on Monday, March 6.

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
--

To unsubscribe, email repo-discuss...@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

[Jonathan Nieder]

Luca Milanesio wrote:

But we need to at least populate the remaining entries of the top-menu, even if they point to the old GWT should the screen not yet available in PolyGerrit.

Are there some particular top-menu entries you are thinking of?

Part of the reason I ask is that knowing what missing functionality people keep running into  might be helpful in prioritizing future PolyGerrit work. Another reason I ask is that I kind of like the more spartan menus. Yet another reason is that the functionality might already be present somewhere else, which would be another useful kind of UI bug report.

Thanks,

Jonathan

[Matthias Sohn]

is documentation already exposed in PolyGerrit ?

+1 for switching the default to the new UI

-Matthias 

[Luca Milanesio]

On 2 Mar 2017, at 07:16, Jonathan Nieder <j...@google.com> wrote:

Luca Milanesio wrote:

But we need to at least populate the remaining entries of the top-menu, even if they point to the old GWT should the screen not yet available in PolyGerrit.

Are there some particular top-menu entries you are thinking of?

In priority order (IMHO):

1. https://gerrit-review.googlesource.com/admin/projects/?polygerrit=1

2. https://gerrit-review.googlesource.com/admin/projects/gerrit,branches?polygerrit=1

3. https://gerrit-review.googlesource.com/admin/projects/gerrit,tags?polygerrit=1

4. https://gerrit-review.googlesource.com/admin/groups/?polygerrit=1

As I said, even just linking to the existing GWT would be good enough to start :-)

I tend to use PolyGerrit as my main UX and the "navigation path" to those pages is quite complex as I need to switch manually to the old UX back and forth all the times.

[Luca Milanesio]

Let me rephrase it, see below :-)

On 2 Mar 2017, at 07:38, Luca Milanesio <Luca.Mi...@gmail.com> wrote:

On 2 Mar 2017, at 07:16, Jonathan Nieder <j...@google.com> wrote:

Luca Milanesio wrote:

But we need to at least populate the remaining entries of the top-menu, even if they point to the old GWT should the screen not yet available in PolyGerrit.

Entries are there, but lead to a blank page with a link to the old UX. My suggestion was just skip the blank page and go directly to the old UX.

Are there some particular top-menu entries you are thinking of?

In priority order (IMHO):

1. https://gerrit-review.googlesource.com/admin/projects/?polygerrit=1

2. https://gerrit-review.googlesource.com/admin/projects/gerrit,branches?polygerrit=1

3. https://gerrit-review.googlesource.com/admin/projects/gerrit,tags?polygerrit=1

4. https://gerrit-review.googlesource.com/admin/groups/?polygerrit=1

They actually exist BUT I believe they are all under "Admin" which isn't necessarily correct.

I may have no will and no permission to admin them, but the list of projects is useful to discover other projects / plugins, using the filter box.

Having all of them under Admin is misleading IMHO: a separate Projects top menu item would be more similar to what we have and more discoverable.

[lucamilanesio]

+ Documentation Link which is missing I believe.

Luca.

[Logan Hanks]

So, to summarize so far:

- We need to link to Documentation (if available)

- It would be nice if admin menu just skipped the interstertial page in PolyGerrit

- The Admin menu could use more entries

The Documentation link seems important for users who haven't chosen a UI. I see this as the only issue brought up so far that potentially ought to be a blocker. https://bugs.chromium.org/p/gerrit/issues/detail?id=5692

Removing the interstitial page seems potentially confusing, but I don't think this needs to block changing the default UI. What if we added an option to it to remember to skip this page in the future? https://bugs.chromium.org/p/gerrit/issues/detail?id=5693

The menu entries Luca mentioned are either already present, or require the selection of a project as context. I don't think that needs to block changing the default UI, either. Or am I misunderstanding your concern there?

[luca.mi...@gmail.com]

Agreed, just the menu link is blocking.

Thanks

Luca

Sent from my iPhone

[Logan Hanks]

To be clear, you're agreeing that the Documentation menu link is the only blocking concern?

Thanks,
Logan

[Luca Milanesio]

Yep, the others are navigation improvements, not blockers IMHO.

Luca.

[thomasmu...@yahoo.com]

I think I may have found a blocker, polygerrit isent working on iPhones, see https://groups.google.com/forum/m/#!topic/repo-discuss/RfwRy-SvV3M please

[thomasmu...@yahoo.com]

Im running ios 10.3 beta.

[thomasmu...@yahoo.com]

I filled a bug report at https://bugs.chromium.org/p/gerrit/issues/detail?id=5715

[thomasmu...@yahoo.com]

Hi, also polygerrit is broken on internet explorer too.

[Edwin Kempin]

> I think I may have found a blocker, polygerrit isent working on iPhones,

> see https://groups.google.com/forum/m/#!topic/repo-discuss/RfwRy-SvV3M please

I don't think that this is a blocker for making PolyGerrit the default UI for  https://gerrit-review.googlesource.com 

This is the instance that is used for Gerrit development. This means it's only used by people that are familiar with Gerrit and that can easily switch back to the old UI if they want to use an iPhone. 

Hi, also polygerrit is broken on internet explorer too.

Can you please file an issue for this and describe in more details what is not working?

[thomasmu...@yahoo.com]

I have already filled one for internet explorer at https://bugs.chromium.org/p/gerrit/issues/detail?id=4308&can=4&q=&colspec=ID%20Type%20Stars%20Milestone%20Status%20Priority%20Owner%20Summary&desc=2

Also polygerrit is saying "mobile support" if iphone users carn't use the mobile site then polygerrit dosen't work well on mobiles.

[Edwin Kempin]

On Mon, Mar 6, 2017 at 4:38 PM, thomasmulhall410 via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

I have already filled one for internet explorer at https://bugs.chromium.org/p/gerrit/issues/detail?id=4308&can=4&q=&colspec=ID%20Type%20Stars%20Milestone%20Status%20Priority%20Owner%20Summary&desc=2

Also polygerrit is saying "mobile support" if iphone users carn't use the mobile site then polygerrit dosen't work well on mobiles.

Sure, but mobile support is not required for switching the default UI for the one Gerrit instance where we develop Gerrit, is it?

 

On Monday, March 6, 2017 at 1:40:37 PM UTC, Edwin Kempin wrote:

> I think I may have found a blocker, polygerrit isent working on iPhones,

> see https://groups.google.com/forum/m/#!topic/repo-discuss/RfwRy-SvV3M please

I don't think that this is a blocker for making PolyGerrit the default UI for  https://gerrit-review.googlesource.com 

This is the instance that is used for Gerrit development. This means it's only used by people that are familiar with Gerrit and that can easily switch back to the old UI if they want to use an iPhone. 

Hi, also polygerrit is broken on internet explorer too.

Can you please file an issue for this and describe in more details what is not working?

[thomasmu...@yahoo.com]

Not really, but having to type in ?polygerrit=0 alot of time can get annoying.

On Monday, March 6, 2017 at 3:41:15 PM UTC, Edwin Kempin wrote:

On Mon, Mar 6, 2017 at 4:38 PM, thomasmulhall410 via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

I have already filled one for internet explorer at https://bugs.chromium.org/p/gerrit/issues/detail?id=4308&can=4&q=&colspec=ID%20Type%20Stars%20Milestone%20Status%20Priority%20Owner%20Summary&desc=2

Also polygerrit is saying "mobile support" if iphone users carn't use the mobile site then polygerrit dosen't work well on mobiles.

Sure, but mobile support is not required for switching the default UI for the one Gerrit instance where we develop Gerrit, is it?

 

On Monday, March 6, 2017 at 1:40:37 PM UTC, Edwin Kempin wrote:

> I think I may have found a blocker, polygerrit isent working on iPhones,

> see https://groups.google.com/forum/m/#!topic/repo-discuss/RfwRy-SvV3M please

I don't think that this is a blocker for making PolyGerrit the default UI for  https://gerrit-review.googlesource.com 

This is the instance that is used for Gerrit development. This means it's only used by people that are familiar with Gerrit and that can easily switch back to the old UI if they want to use an iPhone. 

Hi, also polygerrit is broken on internet explorer too.

Can you please file an issue for this and describe in more details what is not working?

--
--
To unsubscribe, email repo-discuss...@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

[thomasmu...@yahoo.com]

It would be easy to do it how we did it with the old ui and the new ui. We had an option in the preference to choose which ui to use instead of a cookie. Could we do that we polygerrit please?

[Dave Borowitz]

Documentation links now work and nobody else voiced any concerns (not to mention PG has gotten shinier in the past 2 months), so we went ahead and switched the default UI on gerrit-review to PG.

Please continue to report issues, but considering how easy it is to switch the UI back on a per-browser basis, it'll be hard to convince me to change the default back to the old UI :)

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

[luca.mi...@gmail.com]

+1 long life to PolyGerrit !

Sent from my iPhone

To unsubscribe, email repo-discuss...@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.