Missing plugins with stable-3.3 Gerrit CI builds (lfs, login-redirect)

37 views
Skip to first unread message

Peter van Zetten

unread,
Jan 15, 2021, 5:45:00 AM1/15/21
to Repo and Gerrit Discussion
Hi,

I'm starting to look at upgrading our Gerrit instance from 3.2.x to 3.3.x.

Two plugins we're using have not yet been configured with a build for this branch. I've not yet tested them in a deployment, but have made a cursory check:
  • lfs: builds fine against stable-3.3, but one test fails; appears to be because of the LfsDateTime formatter string ("yyyy-MM-dd'T'HH:mm:ss.SSSZZZZZ") which drops some precision (presumably not Gerrit 3.3-related... maybe a local build env issue?):
    • 1) testTokenSerializationDeserialization(com.googlesource.gerrit.plugins.lfs.auth.LfsAuthTokenTest) expected: 2021-01-15T10:25:17.930Z but was : 2021-01-15T10:25:17.930178Z at com.googlesource.gerrit.plugins.lfs.auth.LfsAuthTokenTest.testTokenSerializationDeserialization(LfsAuthTokenTest.java:38)
  • login-redirect: builds fine against stable-3.3
Is there any obstacle to setting the branches/builds up? I will hopefully be taking a look at verifying the plugins in a test instance shortly.

Thanks,
Peter

David Ostrovsky

unread,
Jan 15, 2021, 6:06:45 AM1/15/21
to Repo and Gerrit Discussion
peter.v...@gmail.com schrieb am Freitag, 15. Januar 2021 um 11:45:00 UTC+1:
Hi,

I'm starting to look at upgrading our Gerrit instance from 3.2.x to 3.3.x.

Two plugins we're using have not yet been configured with a build for this branch. I've not yet tested them in a deployment, but have made a cursory check:
  • lfs: builds fine against stable-3.3, but one test fails; appears to be because of the LfsDateTime formatter string ("yyyy-MM-dd'T'HH:mm:ss.SSSZZZZZ") which drops some precision (presumably not Gerrit 3.3-related... maybe a local build env issue?):
    • 1) testTokenSerializationDeserialization(com.googlesource.gerrit.plugins.lfs.auth.LfsAuthTokenTest) expected: 2021-01-15T10:25:17.930Z but was : 2021-01-15T10:25:17.930178Z at com.googlesource.gerrit.plugins.lfs.auth.LfsAuthTokenTest.testTokenSerializationDeserialization(LfsAuthTokenTest.java:38)
This is a known issue, see: [1]. Francois Ferrand already uploaded this change: [2].
  • login-redirect: builds fine against stable-3.3
Done: [3].

Peter van Zetten

unread,
Jan 15, 2021, 8:26:06 AM1/15/21
to Repo and Gerrit Discussion
Looking good, thanks! Sorry, I completely forgot to check whether the issue was already raised.
Reply all
Reply to author
Forward
0 new messages