Re: Multiple repo's
57 views
Skip to first unread message
Magnus Bäck
Aug 14, 2012, 8:59:41 PM8/14/12
to repo-d...@googlegroups.com
On Tuesday, August 14, 2012 at 20:04 EDT,
David Medina <b2am...@gmail.com> wrote:
> I have a case were I have multiple git repositories with dependencies
> between them, e.g.
>
> application
> overlay
> libraries
>
> Is there a way to link commits such that they can be reviewed as a
> whole before being accepted or verified
Not out of the box, no. A patch series was uploaded the other day
(below) to allow sets of changes to be reviewed as one unit (or
something of the sort, I haven't looked at exactly what it does).
https://gerrit-review.googlesource.com/#/q/status:open+project:gerrit+branch:master+topic:TopicReviews,n,z
> How does the "repo" script currently handle this e.g. dependencies
> between framework and contacts, etc. ?
This isn't addressed. The Repo tool can't solve this on its own.
> I have been searching around and even though this topic is discussed
> several times I am not sure if it has been resolved or what is
> recommended
Yes, it has been discussed many times and (apart from the series
described above) I think at least two solutions to the problem of
cross-repository dependencies have been uploaded (but neither have
been churned to completion).
Depending on why you want to do this, there might be ways to work around
this shortcoming. For example, if getting automatic verification of
uploaded sets of changes is the main driving factor for your desire of
this feature, you might get away with establishing a notation in the
commit messages that the CI system can pick up and use to tie changes
together. Of course, this won't stop users from submitting just one of
multiple interdependent changes.
Figuring out a sane user interface for this is harder than one might
think. There are several corner cases to address. How do you specify
the dependencies in the first place? How do you modify the set of
interdependent changes once the set has been established? How do you do
this without affecting the common case of not having these dependencies?
--
Magnus Bäck
ba...@google.com
David Medina <b2am...@gmail.com> wrote:
> I have a case were I have multiple git repositories with dependencies
> between them, e.g.
>
> application
> overlay
> libraries
>
> Is there a way to link commits such that they can be reviewed as a
> whole before being accepted or verified
Not out of the box, no. A patch series was uploaded the other day
(below) to allow sets of changes to be reviewed as one unit (or
something of the sort, I haven't looked at exactly what it does).
https://gerrit-review.googlesource.com/#/q/status:open+project:gerrit+branch:master+topic:TopicReviews,n,z
> How does the "repo" script currently handle this e.g. dependencies
> between framework and contacts, etc. ?
This isn't addressed. The Repo tool can't solve this on its own.
> I have been searching around and even though this topic is discussed
> several times I am not sure if it has been resolved or what is
> recommended
Yes, it has been discussed many times and (apart from the series
described above) I think at least two solutions to the problem of
cross-repository dependencies have been uploaded (but neither have
been churned to completion).
Depending on why you want to do this, there might be ways to work around
this shortcoming. For example, if getting automatic verification of
uploaded sets of changes is the main driving factor for your desire of
this feature, you might get away with establishing a notation in the
commit messages that the CI system can pick up and use to tie changes
together. Of course, this won't stop users from submitting just one of
multiple interdependent changes.
Figuring out a sane user interface for this is harder than one might
think. There are several corner cases to address. How do you specify
the dependencies in the first place? How do you modify the set of
interdependent changes once the set has been established? How do you do
this without affecting the common case of not having these dependencies?
--
Magnus Bäck
ba...@google.com
Reply all
Reply to author
Forward
0 new messages