Fwd: The tag feature

46 views
Skip to first unread message

Marcelo Ávila de Oliveira

unread,
Jun 20, 2022, 6:56:16 PM6/20/22
to Repo and Gerrit Discussion
Hello everyone,

Is the following statement from "gerrit review" documentation still valid?

S2022_06_20-11_27_23.png
If yes, how do I filter the comments in the web UI? BTW, is tag still a useful feature?

Thanks in advance.

--

Marcelo Ávila de Oliveira

CPQD - Tecnologia da Informação e Comunicação

mav...@cpqd.com.br


"Esta mensagem pode conter informações confidenciais ou privilegiadas. Caso não seja o destinatário desta mensagem ou caso ela lhe tenha sido enviada por engano, pedimos a gentileza de eliminar esta mensagem e todos os seus anexos imediatamente. Utilizar, divulgar a quaisquer terceiros ou copiar esta mensagem para qualquer fim é expressamente proibido e punido por lei."

"This message may contain privileged or confidential information. If you are not the intended recipient of this message or if you have received it in error, please kindly delete this message and all its attachments immediately. Unauthorized use, disclosure to any third parties or copying of this message is expressly prohibited and may be subject to the penalties of law."

Ben Rohlfs

unread,
Jun 21, 2022, 3:23:12 AM6/21/22
to Marcelo Ávila de Oliveira, Repo and Gerrit Discussion
From https://gerrit-review.googlesource.com/c/gerrit/+/339538: There is a "show all entries toggle" on the change page:
image.png

The logic for deciding, if a message is initially shown or only when switching that toggle is implemented here:

So if a message has a tag, then we hide the message, if there is another message with the same tag, but on a newer patchset.

HTH Ben



--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CALELEUnMrk3YnF9iWU%3DaSSwkWq%2BMM%2Be-fQvytkAqjYYy9t9HFw%40mail.gmail.com.

Sven Selberg

unread,
Jun 21, 2022, 3:52:57 AM6/21/22
to Repo and Gerrit Discussion
On Tuesday, June 21, 2022 at 9:23:12 AM UTC+2 bro...@google.com wrote:
From https://gerrit-review.googlesource.com/c/gerrit/+/339538: There is a "show all entries toggle" on the change page:

Did you mean https://gerrit-review.googlesource.com/c/gerrit/+/264181?
Great feature by the way.

David Ostrovsky

unread,
Jun 21, 2022, 3:53:12 AM6/21/22
to Repo and Gerrit Discussion
bro...@google.com schrieb am Dienstag, 21. Juni 2022 um 09:23:12 UTC+2:
From https://gerrit-review.googlesource.com/c/gerrit/+/339538: There is a "show all entries toggle" on the change page:
image.png

The logic for deciding, if a message is initially shown or only when switching that toggle is implemented here:

So if a message has a tag, then we hide the message, if there is another message with the same tag, but on a newer patchset.

Also related here, that the Jenkins Gerrit Trigger plugin was extended in
this PR: [1] to add "autogenerated" prefix to the jenkins-gerrit-trigger tag.

Marcelo Ávila de Oliveira

unread,
Jun 21, 2022, 11:32:38 AM6/21/22
to Ben Rohlfs, Repo and Gerrit Discussion
Em ter., 21 de jun. de 2022 às 04:23, Ben Rohlfs <bro...@google.com> escreveu:
From https://gerrit-review.googlesource.com/c/gerrit/+/339538: There is a "show all entries toggle" on the change page:
image.png

The logic for deciding, if a message is initially shown or only when switching that toggle is implemented here:

So if a message has a tag, then we hide the message, if there is another message with the same tag, but on a newer patchset.

Thanks for your answer. Two additional questions:

- So, the "autogenerated:" prefix is not used, correct? All tags are filtered in the Web UI.
- I noticed that the "Uploaded patch set x" user comments are filtered (only the last one is shown). Do they receive tags automatically?

Nasser Grainawi

unread,
Jun 22, 2022, 3:30:09 PM6/22/22
to Marcelo Ávila de Oliveira, Ben Rohlfs, Repo and Gerrit Discussion
On Tue, Jun 21, 2022 at 9:32 AM Marcelo Ávila de Oliveira <mav...@cpqd.com.br> wrote:
Em ter., 21 de jun. de 2022 às 04:23, Ben Rohlfs <bro...@google.com> escreveu:
From https://gerrit-review.googlesource.com/c/gerrit/+/339538: There is a "show all entries toggle" on the change page:
image.png

The logic for deciding, if a message is initially shown or only when switching that toggle is implemented here:

So if a message has a tag, then we hide the message, if there is another message with the same tag, but on a newer patchset.

Thanks for your answer. Two additional questions:

- So, the "autogenerated:" prefix is not used, correct? All tags are filtered in the Web UI.
- I noticed that the "Uploaded patch set x" user comments are filtered (only the last one is shown). Do they receive tags automatically?

Those messages are created on the server when it creates the patch set and since [1] those messages do have an autogenerated tag.

[1] 89132: Add concept of auto generated messages to Gerrit (backend) | https://gerrit-review.googlesource.com/c/gerrit/+/89132
 

"Esta mensagem pode conter informações confidenciais ou privilegiadas. Caso não seja o destinatário desta mensagem ou caso ela lhe tenha sido enviada por engano, pedimos a gentileza de eliminar esta mensagem e todos os seus anexos imediatamente. Utilizar, divulgar a quaisquer terceiros ou copiar esta mensagem para qualquer fim é expressamente proibido e punido por lei."

"This message may contain privileged or confidential information. If you are not the intended recipient of this message or if you have received it in error, please kindly delete this message and all its attachments immediately. Unauthorized use, disclosure to any third parties or copying of this message is expressly prohibited and may be subject to the penalties of law."

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages