Inconsistency between a project's Prolog submit rule and "Merged" commit dashboard

[Holger Abel]

Hi guys.  This is a minor issue but I was hoping you could help me out at some point.  I'm using Gerrit 2.7-rc2.

Using the steps documented to modify submit rules via Prolog, I copied the "1+1=2 Code-Review" code and added it to one of our projects via the rules.pl file.  The logic works great.

The inconsistency is that when I go to the "Merged" dashboard for a commit related to that project, the "CR" column shows "+1" instead of the expected check mark.  So even though the submit was only allowed after two reviewers gave each a +1 to the commit (expected behavior based on the submit rule used), the dashboard doesn't seem to reflect this fact.

Just wanted to know if this is a bug or I can change something in the "Merged" dashboard for this to be reported correctly.

Thank you as always.

[Dave Borowitz]

This is a bug, we're probably only showing the check for the max value rather than checking if the label is actually approved.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
 
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Holger Abel]

Hi Dave,
Thank you for your quick reply.  I will capture a bug in the "Issue Tracker" to somehow document this.

Thanks again and best regards,
Holger