Fwd: Pagination of user queries.

[Marija Savtchouk]

Thank you,

Marija Savtchouk

---------- Forwarded message ---------
From: Marija Savtchouk <mariasa...@google.com>
Date: Thu, Nov 3, 2022 at 10:13 AM
Subject: Pagination of user queries.
To: <kaushik....@linaro.org>
Cc: <nasser....@linaro.org>, <marti...@linaro.org>, <repo-d...@google.com>

Hi Kaushik,

Hope you don't mind me raising this topic.
Following up on my question about the change https://gerrit-review.googlesource.com/c/gerrit/+/344334 and potential extension.
From the comment, the pagination was only meant to address performance of
Elasticsearch index backend for unlimited queries, and you don't think there will be any performance benefit for the queries with a small limit.

The case I had in mind is the pagination from the user dashboard. I.e. I am not sure how it is for Elastic, but typically, when using the query with offset, e.g. https://gerrit-review.googlesource.com/changes/?S=25&n=25, the index will just  recalculate all results and throw the first S=25 away. This may be noticeably slower if a user pages deeply into the dashboard. 

Does this problem also exist for Elastic? Would you be interested in extending your work to user queries (e.g. would your installation benefit from that)?

Any insights how it is solved for you appreciated!

Thank you,

Marija Savtchouk

[Kaushik Lingarkar]

Hello Marija, I may have misunderstood your question. I was thinking you meant, paginate first 25 results by having a page-size smaller than 25. Thanks for detailing the actual use-case you had in mind. Anyways, yes, with the current pagination implementation, the performance will be progressively slower the as we go deep into the user dashboard pages. The same behavior exists for ElasticSearch too. We currently do not have plans to improve that. I'd be interested in attempting to improve it, however we are currently crunched for time,  moreover, I don't have good ideas on how to solve that at the moment. I can help with reviews if someone else does want to work on improving that.

[Marija Savtchouk]

Hi Kaushik,

Thank you for the context.

This is one of the items that we might be working on, but we don't have an ETA for that currently.

I will keep you in the loop.

Thank you,

Marija Savtchouk

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/3420fb52-478c-482b-bd73-e61e00b13df6n%40googlegroups.com.

[Kaushik Lingarkar]

On Monday, 7 November 2022 at 01:20:42 UTC-8 mariasa...@google.com wrote:

Hi Kaushik,

Thank you for the context.

This is one of the items that we might be working on, but we don't have an ETA for that currently.

I will keep you in the loop.

Sounds good. Thanks.