How to trigger re-verify?

2,650 views
Skip to first unread message

Anthony Wong

unread,
Jun 29, 2012, 6:00:44 PM6/29/12
to repo-d...@googlegroups.com
Hi

Right now, I'm triggering the verify script in the patchset-created hook, due to a flaky build environment, through no fault of the committer, it fails the verifier script.

What would you recommend for re-triggering the verifier script? Have the user commit --amend, and push (to force another patchset-created hook), magic phrase in a comment and instrument the comment-added hook), modify Gerrit to add a button in the Gerrit UI?

Thanks
Anthony

Magnus Bäck

unread,
Jun 29, 2012, 8:34:57 PM6/29/12
to Repo and Gerrit Discussion
Having verification builds run on the Gerrit server doesn't scale anyway, so if you're serious about deploying Gerrit I suggest you look into running a separate CI system. For example, Jenkins has a Gerrit plugin that listens to patch set events and triggers builds accordingly, and if a build fails because of test or environment flakiness you can retrigger the build from the Jenkins UI (to which there will be a link from Gerrit).

-- 
Magnus Bäck

Anthony Wong

unread,
Jun 30, 2012, 1:28:44 PM6/30/12
to repo-d...@googlegroups.com
Yes, the script triggers the build system, do I have to use Jenkins?

Magnus Bäck

unread,
Jun 30, 2012, 4:47:15 PM6/30/12
to repo-d...@googlegroups.com
On Saturday, June 30, 2012 at 13:28 EDT,
Anthony Wong <won...@gmail.com> wrote:

> Yes, the script triggers the build system, do I have to use Jenkins?

Of course not, but I think you should use a tool that has support for
retries (automatic or manual). Gerrit itself doesn't provide this
functionality, and requiring users to upload new patch sets just to
trigger rebuilds is just not a good idea.

--
Magnus Bäck
ba...@google.com

Jay Soffian

unread,
Jul 11, 2012, 11:34:03 AM7/11/12
to repo-d...@googlegroups.com
We use the Build Bot as one of our build systems and I simply modified
it to listen for add-comment events. It looks for comments of
"@rebuild" and "@clobber".

j.
Reply all
Reply to author
Forward
0 new messages