reviewers-by-blame on stable-2.15 busted with NoteDb

[Richard Christie]

We got a complaint from end users that since updating to 2.15 and NoteDB, the reviewers-by-blame plugin no longer works. Gerrit's error log shows it dying due to trying to access ReviewDB for data,

com.googlesource.gerrit.plugins.reviewersbyblame.ChangeUpdatedListener : This table has been migrated to NoteDb

java.lang.UnsupportedOperationException: This table has been migrated to NoteDb

at com.google.gerrit.reviewdb.server.DisallowReadFromChangesReviewDbWrapper$PatchSets.get(DisallowReadFromChangesReviewDbWrapper.java:212)

at com.googlesource.gerrit.plugins.reviewersbyblame.ChangeUpdatedListener.onEvent(ChangeUpdatedListener.java:118)

        ...

Line number may not be exact as I started hacking the plugin to be more verbose in chasing where this was happening.

A few questions:

• Is MonoRail the right place to log bugs against no-core plugins? Searching, it seemed to know about it as a component but searching showed nothing there's no category for non-polygerrit plugin; unless that is taken to mean any plugin for gerrit (UI based or not). I took it to mean specifically plugins for the UI.
  
• Is anyone already aware of this and have a fix to hand?
• If not, shall I just go and (try and) fix it?

[David Ostrovsky]

Yes, Gerrit issue tracker is the right place to report issues for non core plugin. 

• Is anyone already aware of this and have a fix to hand?

Apparently you are the first plugin user that migrated to 2.15 release.  

• If not, shall I just go and (try and) fix it?

As always contribution is welcomed. You can check reviewers plugins, that was

fixed to work against NoteDb and propose a similar fix.

[Richard Christie]

Thanks. I pushed a fix for it [1], there seemed to be several ways of loading changes now (e.g. via REST api call internally) so feel free to suggest a different approach if you don't like this one. Also a little unclear on what the status is with change numbers these days. Reading comments here makes me think they are considered somewhat historical/legacy now and that search should be done via id + branch, hence the approach I took.

[1] https://gerrit-review.googlesource.com/c/plugins/reviewers-by-blame/+/192110