[DISCUSSION] Making :v in kaka schema names as default

63 views
Skip to first unread message

Harsha Chintalapani

unread,
May 5, 2017, 12:33:11 AM5/5/17
to Registry
currently, users while registering schema for Kafka need to provide :v or :k indicating if the schema is for value or key respectively. This is confusing for users especially when they are
trying to register using UI they forget to add :v and when using schema registry client it will not find the schema. My proposal is to make this optional i.e by default we assume the schema is for value
so if for topic "truck_events" they can register a schema with "truck_events" this will be for value and if they want a schema for key they need to append ":k". We should honor both the schema name with :v or without it for value schema.

aiyer

unread,
May 5, 2017, 12:37:55 AM5/5/17
to Registry
Yes it makes sense to interpret the schema as default for "value" without appending :v. Right now appending :v is a source of confusion and can be missed easily.

Satish Duggana

unread,
May 5, 2017, 1:16:11 AM5/5/17
to Arun Iyer, Registry

+1 to have schema name for values with kafka topic’s name itself as it is causing confusion to users when they manually register schemas. This will not cause any schema name collisions as kafka does not allow topic names containing ‘:’ character.

 

This breaks backward compatibility with KafkaAvroSerializer as it publishes or retrieves with <topic-name>“:v”. We can put a note on this in immediate minor release in which this fix will go.

There can be usecases where same schema registry server is used across multiple kafka clusters and there can be same topic names and it may cause schema name collisions for those topics. But there can be suggestion to suffix cluster-names along with topic name and the same can be done in Kafka ser/des by having some property for the suffix.

 

Thanks,

Satish.


CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.

--
You received this message because you are subscribed to the Google Groups "Registry" group.
To unsubscribe from this group and stop receiving emails from it, send an email to registry+u...@googlegroups.com.
To post to this group, send email to regi...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/registry/9b8f2e04-3f75-4d52-a68c-b6f4926d7349%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Michael Andre Pearce

unread,
May 23, 2017, 3:30:58 AM5/23/17
to Registry
ive raised a PR to make this config configurable (keeping the new defaults) to hopefully alleviate any transition issues, it should be just config to change it back to :v if a user wishes if this PR get merged (this also assists in migrating from a confluent schema repo where -value and -key is suffixed by their serdes)

Harsha

unread,
May 23, 2017, 10:56:16 AM5/23/17
to Registry, Michael Andre Pearce
Thanks Michael. I think this requires client side changes as well, as SchemaRegsitryClient now needs to understand :v in schema name. 
We’ve seen lot of users trip on this as they are registering schema hence the motivation to remove this. Do you foresee migration issues?
We are looking to add listeners feature which allows users to configure external registry services to pull the data from them and also provide a import tool to pull in schemas and re-register them in our SchemaRegistry. Users will need to start using AvroDeserailzer/Serializer from registry project anyway. Would like to now your thoughts?

Thanks,
Harsha
Reply all
Reply to author
Forward
0 new messages