RedisTimeSeries-py TS.INCRBY supports TIMESTAMP argument?

15 views
Skip to first unread message

Matthew Anthony

unread,
Jan 31, 2020, 4:10:01 PM1/31/20
to RedisTimeSeries Discussion Forum
The redis-cli documentation for TS.INCRBY states

TS.INCRBY key value [TIMESTAMP timestamp] [RETENTION retentionTime] [UNCOMPRESSED] [LABELS label value..]

However the python client signature for the method is

def incrby(self, key, value, time_bucket=None, retention_msecs=None, uncompressed=False, labels={}):
"""
Increases latest value in ``key`` by ``value``.
``timeBucket`` resets counter. In milliseconds.
If ``key`` is created, ``retention_msecs`` and ``labels`` are
applied.
"""


 which suggests it doesn't support the TIMESTAMP argument.. Can this be confirmed? If it does support it, how would one go about using it?

The documentation on the python client is a bit lacking :-/

Ariel Shtul

unread,
Feb 2, 2020, 8:06:15 AM2/2/20
to RedisTimeSeries Discussion Forum
Hello Matthew,

You are indeed correct and the python client was not in line with the module.

I have already fixed it and published a PR. It will be review and published soon.

Thank you for the feedback,

Ariel

Matthew Anthony

unread,
Feb 3, 2020, 9:48:33 AM2/3/20
to RedisTimeSeries Discussion Forum
Thanks - will the documentation be updated also?


Matt

Ariel Shtul

unread,
Feb 3, 2020, 1:58:07 PM2/3/20
to RedisTimeSeries Discussion Forum
Hi Matt,

Documentation for function has been updated as well and will be published on PyPi soon.

Regards,

Ariel 
Reply all
Reply to author
Forward
0 new messages